Uh oh!
There was an error while loading. Please reload this page.
docs(deps): correct the retired-patch comment and record the chia-0.36 cascade blocker - #301
Merged
Merged
Conversation
…6 blocker The dig-gossip entry in dig-node-core/Cargo.toml claimed the vendored chia-protocol/chia-sdk-client forks are re-declared in the workspace `[patch.crates-io]` section. That section is RETIRED (root Cargo.toml:43) — dig-gossip 0.23.0 deleted both forks — so the comment described a mechanism that no longer exists, along with the #1529 three-rev lockstep it implied. A false manifest comment is how the next lane reasons wrongly about the version line, which is exactly what this one was doing. Also records, at the declaration that causes it, the measured reason the chia 0.26 -> 0.36.1 uplift cannot be a dig-node-local edit: dig-gossip depends on dig-peer-protocol "0.6", whose only published 0.6.x (0.6.0) declares chia-protocol 0.26 and chia-sdk-client 0.28. chia-protocol 0.26.0 therefore enters the graph through a path no dig-node manifest can edit. Comment-only; `cargo metadata` resolves identically and Cargo.lock is unchanged apart from the workspace version bump. Refs: DIG-Network/dig_ecosystem#2761 Co-Authored-By: Claude <noreply@anthropic.com>
MichaelTaylor3d
marked this pull request as ready for review
August 22, 2026 15:59
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR is, and what it is NOT
WU4 of DIG-Network/dig_ecosystem#2761 asked for the whole dig-node workspace to move from
chia 0.26 / chia-wallet-sdk 0.30 to chia-protocol 0.36.1 / chia-wallet-sdk 0.34, in one unit,
verified by
cargo tree -dreporting no duplicates.That is not achievable by any edit to this repo. The brief said to report the shape rather
than half-land it, so this PR carries only the manifest-comment correction the brief also asked
for, plus the measurement recorded where the next lane will read it.
The blocker, measured
chia-protocol 0.26.0enters this workspace through a path no dig-node manifest can edit:dig-peer-protocol0.6.0 is the ONLY published 0.6.x, and it declareschia-protocol = "0.26",chia-sdk-client = "0.28",chia-traits/chia-sha2/chia-ssl/chia_streamable_macro = "0.26".There is no 0.7.
^0.6can therefore only ever resolve to the 0.26 line.dig-peer-protocolmain is stillversion = "0.6.0"onchia-protocol = "0.26"— the uplifthas not been started there.
dig-gossipmain (0.28.0) still declaresdig-peer-protocol = "0.6"andchia-protocol = "0.26".It is unpublished, and its publish is itself guarded pending dig-peer-protocol (#681).
So WU4 is a release-first cascade across three repos, not a single-repo edit:
dig-peer-protocol -> dig-gossip -> dig-node.
Why landing the dig-node half alone would be worse than not doing it
crates/dig-node-core/src/seams/dig_peer/store_melted.rs:44importsBytes32fromdig_gossip(i.e. chia-protocol 0.26). The same file drives
digstore_chain'sChainReadstrait, whosepush(SpendBundle)/estimate_fee(SpendBundle)(:1378,:1381) sit besideconfirm_melt_via_chain— the read that authorizes a store DELETE.
Uplifting dig-node alone moves
digstore-chain/chia-protocolto 0.36.1 whiledig_gossipkeepshanding this file 0.26
Bytes32. Those become two different types inside the melt-authorizationpath, forcing precisely the cross-version
Bytes32/SpendBundleshim the epic exists to remove.profile_sync.rs:78crosses the same boundary.Everything else is ready — the cascade is the only thing missing
Verified on crates.io, all already on chia-protocol 0.36.1 / chia-wallet-sdk 0.34:
chia-peer"0.1")chia-query=0.5.1+ 0.6.2 (two lines)chia ^0.26dig-chainsource-interfacedatalayer-driverdig-wallet-backenddig-merkledig-clvmdig-constantsdig-peer-protocolThe
chia = "0.26"umbrella (dig-node-service/Cargo.toml:229,dig-wallet/Cargo.toml:35) isconfirmed unbumpable: the published
chiaversions go... 0.29.0, 0.32.0, 0.42.0 ...with no 0.36,so those two declarations must be replaced by the individual facade crates. That replacement is
straightforward and is part of the dig-node unit once the cascade unblocks it.
Correction to the epic's acceptance criterion
cargo tree -dcan never be clean forchia-bls,chia-sha2orchia-traits, even after a perfectmigration.
chia-wallet-sdk 0.34's own tree contains four chia-bls lines simultaneously:0.28.2viaclvmr 0.16.4(whichchia-protocol 0.36.1itself requires)0.42.1viachialisp 0.4.6<-chia-sdk-types 0.340.22.0viaclvm_tools_rs 0.3.0<-chia-sdk-types 0.340.36.1viachia-protocol 0.36.1These are upstream-internal and do not cross any DIG API boundary. The checkable invariant should be
one
chia-protocol, onechia-wallet-sdk, onechia-query, onedig-chainsource-interface, onechia-sdk-*— the types that actually cross our trait boundaries.What is in the diff
crates/dig-node-core/Cargo.toml:219-239— the dig-gossip comment claimed the vendoredchia-protocol/chia-sdk-client forks are re-declared in the workspace
[patch.crates-io]. Thatsection is RETIRED (root
Cargo.toml:43); dig-gossip 0.23.0 deleted both forks. Corrected, and theblocker above recorded at the declaration that causes it.
crates/dig-node-core/Cargo.toml:244-245— same stale[patch.crates-io]reference in thedig-constants rationale, repointed.
Cargo.toml— workspace version 0.136.2 -> 0.136.3.Blast radius
Comment-only plus a version string. No symbol is edited, so no
impactquery applies; per CLAUDE.md§2.0 bound (2) the analysis was done by resolution instead —
cargo metadatasucceeds andCargo.lockis byte-identical apart from the workspace version bump, which is the strongestavailable evidence that the dependency graph is untouched.
Version bump
Patch (0.136.2 -> 0.136.3). Comments and a version string; no behaviour change, no API change,
no resolution change.
Refs: DIG-Network/dig_ecosystem#2761