Uh oh!
There was an error while loading. Please reload this page.
[v7r2]Client: protect documentation generation against py3 - #5233
Merged
Conversation
chaenforce-pushed
the
rel-v7r2_FIX_addFunctions
branch
from
June 29, 2021 18:58
12b8f69 to
0923c8cComparechrisburr
approved these changes
Jun 30, 2021
chaen
marked this pull request as ready for review
July 1, 2021 08:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change of
importlib_resources(python/importlib_resources#221) introduced a change of behavior (python/importlib_resources#230)With
importlib_resources>=5.2.0,pathwould not throw an error if the resource does not exist, butfp.read_textwould raiseFileNotFoundError, so i just shifted the block in thetry/exceptBEGINRELEASENOTES
*Core
CHANGE: protect client doc generation against new importlib_resources
ENDRELEASENOTES