feat(duely): send internal auth in service requests - #340
Open
DIvanCode wants to merge 1 commit into
Open
Conversation
DIvanCodeforce-pushed
the
codex/322-duely-internal-auth
branch
from
September 7, 2026 17:58
36ac571 to
8434880CompareDIvanCodeforce-pushed
the
codex/322-duely-internal-auth
branch
from
September 7, 2026 18:02
8434880 to
9c869d6CompareDIvanCode
marked this pull request as ready for review
September 7, 2026 18:03
SummarySummary
CoverageDuely.Application.Services - 88.3%
Duely.Application.UseCases - 92.4%
Duely.Domain.Models - 89%
Duely.Domain.Services - 93.1%
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:9c869d6abf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - "5001:5001" | ||
| env: | ||
| ASPNETCORE_ENVIRONMENT: "Production" | ||
| InternalAuthKey: "{{ internal_auth_key }}" |
There was a problem hiding this comment.
If internal_auth_key is undefined or blank, this is the first place it is consumed: the playbook has already ensured the network, pulled both images, and run the migration in the preceding tasks, while a blank value is accepted and starts Duely with unusable service credentials. Because the Duely pull-request workflow automatically deploys the revision, add a pre-task assertion that the key is defined and nonempty before any deployment side effects.
AGENTS.md reference: AGENTS.md:L32-L32
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#322
Duely now reads
InternalAuthKeyand sends it with every request to Taski, Exesh, and Analyzer. The configured header is redacted from HTTP client logs. Local configuration usesINTERNAL_AUTH_KEY_LOCAL_VALUE; the deployment playbook readsinternal_auth_keyfrom the encrypted credentials file and validates it before any deployment work begins.Operator action before Ready for review: add the same non-local
internal_auth_keyto the encrypted credentials for Duely, Taski, Exesh, and later Analyzer. Do not commit the plaintext value.Validation:
dotnet test --configuration Release— 447 passedansible-playbook --syntax-checkwith temporary non-secret test variables