feat(taski): send internal auth to exesh - #341
Draft
DIvanCode wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#323
Taski now reads
InternalAuthKeyand sends it to Exesh both when creating an execution and when polling its message history. Local and end-to-end configurations useINTERNAL_AUTH_KEY_LOCAL_VALUE; the deployment playbook readsinternal_auth_keyfrom encrypted credentials and validates it before deployment work begins. The execution and REST polling process documentation reflects the authenticated requests.Operator action before Ready for review: add the same non-local
internal_auth_keyto the encrypted credentials used by Duely, Taski, Exesh, and later Analyzer. Do not commit the plaintext value.Validation:
go test ./..../e2e/taski-exesh/run.sh— accepted A+B solutionansible-playbook --syntax-checkwith temporary non-secret test variables