feat(landing): add guest landing page - #95
Merged
Conversation
DIvanCode
marked this pull request as ready for review
August 11, 2026 18:42
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4b61d2d7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
DIvanCode
marked this pull request as draft
August 11, 2026 19:13
DIvanCode
marked this pull request as ready for review
August 11, 2026 19:29
DIvanCode
marked this pull request as draft
August 11, 2026 19:55
DIvanCode
marked this pull request as ready for review
August 11, 2026 19:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/while preserving the existing authenticatedHomePage/auth?tab=register, hide the redundant Header Войти action on/auth, and keep a logout recovery action when a saved-session check failsWhy
Unauthenticated visitors were redirected straight to the auth form, so the product had no public introduction or registration-first entry point. The persisted user snapshot also cannot be treated as proof that a restored token is still valid.
User impact
Guests now get a compact CoDuels introduction with theme-matched duel imagery and direct login/registration paths. Authenticated users retain the current HomePage and profile menu after server validation. A transient non-401 session-check failure no longer leaves the Header without a way to log out.
Verification
pnpm lint— passed (4 pre-existing warnings, no errors)pnpm test— passed, 30 files / 96 testspnpm buildwithVITE_BASE_URL=__VITE_BASE_URL__— passedpnpm fsd:lint— repository baseline remains 13 errors / 11 warnings; no findings point to changed files530client /826scroll height)/authhas no Header login action503exposes logout and returns to the landingWhat to test manually
Prerequisites: a logged-out browser and one valid CoDuels account.
/at 100% browser zoom and confirm the compact scale, duel image, and three steps look balanced; reduce the window height and confirm the page scrolls./authopens without another Войти action in the Header./, select Хочу участвовать!, confirm/auth?tab=registeropens registration, then reload and confirm registration remains selected./; confirm the landing does not flash, the existing HomePage appears, Начать still opens the duel mode selection, and the profile menu remains available.Closes #94