feat(box): add single-host Compose deployment - #120
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 35926904 | Triggered | Username Password | 8e8156c | env/duely-migration.env | View secret |
| 35926904 | Triggered | Username Password | 8e8156c | env/duely.env | View secret |
| 35926904 | Triggered | Username Password | 639825a | Box/docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
653c0ce to
165e9b8CompareUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1d495da335
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ASPNETCORE_ENVIRONMENT=Production | ||
| # Ключ подписи JWT. Обязательно замените его перед публичным запуском. | ||
| JwtToken__SecretKey=CHANGE_ME |
There was a problem hiding this comment.
Provide a JWT placeholder that can actually sign tokens
When this stack is started with the advertised out-of-box defaults, CHANGE_ME is only 9 bytes, below the 32-byte minimum for the HMAC-SHA256 key used to issue Duely JWTs. Token generation therefore fails at runtime during registration or login, leaving the application unusable even for a private smoke test; use a sufficiently long non-production placeholder while retaining the instruction to replace it.
Useful? React with 👍 / 👎.
| driver_opts: | ||
| type: none | ||
| o: bind | ||
| device: /tasks/storage |
There was a problem hiding this comment.
Provision the task-storage bind source before startup
On a fresh host where /tasks/storage does not already exist, the local volume driver's bind mount cannot be created and docker compose up fails while mounting taski-storage. Nothing in this deployment creates or populates that absolute host path, so the purported autonomous stack does not start without undocumented preparation; add a setup step that provisions the task storage or use a source that Compose can create.
Useful? React with 👍 / 👎.
Что изменено
Box/;Box/docker-compose.ymlиспользует релизные образы CoDuels1.0.0и одну сетьcoduels;Box/env/*.envсодержат только нетопологические прикладные настройки;Otel__IsEnabled=false;/api, WebSocket и/exesh-dashboard/;duely-postgres,taski-postgres,exesh-postgres; временные Exesh storage volumes отсутствуют.Зависимость
Образы
1.0.0были собраны до REST-only defaults из Backend PR #338. Перед рабочим запуском Box нужно выпустить новую версию образов из обновлённого Backend и заменить закреплённые теги в Compose.Проверка
docker compose -f Box/docker-compose.yml config --quiet;nginx:1.29.2 nginx -t;Box;go test ./..., 445 Duely tests и Taski–Exesh e2e с verdictAccepted.Полный Box stack локально не запускался.
Closes#119.