stable/redis-ha Consistently use labels.standard - #414
Open
Kidswiss wants to merge 1 commit into
Open
Conversation
Not escaping the `.Chart.version` cleanly in labels can lead to issues while using the chart via flux helm controller. Because the controller tracks the digest of any given chart and appends it to the chart version with a `+` which will result in invalid labels. Signed-off-by: Simon Beck <simon.beck@vshn.ch>
Kidswissforce-pushed
the
fix/standard_labels
branch
from
August 12, 2026 11:44
98daeb2 to
1054f2fCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Not escaping the
.Chart.versioncleanly in labels can lead to issues while using the chart via flux helm controller.Because the controller tracks the digest of any given chart and appends it to the chart version with a
+which will result in invalid labels.Special notes for your reviewer:
Please check if I really caught all instances.
Checklist
[stable/mychartname])