Skip to content

Exposing the transaction used in class Database. - #2038

Merged
mgravell merged 1 commit into
DapperLib:mainfrom
kbilsted:feature/rainbow_expose_tx
Feb 15, 2024
Merged

Exposing the transaction used in class Database.#2038
mgravell merged 1 commit into
DapperLib:mainfrom
kbilsted:feature/rainbow_expose_tx

Conversation

@kbilsted

Copy link
Copy Markdown
Contributor

This enables to do queries not supported by rainbow within the same transaction

Closes#1944

@kbilsted

Copy link
Copy Markdown
ContributorAuthor

The build pipeline is failing on installing dependencies so it cannot run the tests

@kbilsted
kbilstedforce-pushed the feature/rainbow_expose_tx branch from 128037e to 11ebdaeCompareFebruary 11, 2024 23:48
@kbilsted

Copy link
Copy Markdown
ContributorAuthor

still errors in the pipeline. please help

Packages requiring reboot:
- vcredist140 (exit code 3010)
The recent package changes indicate a reboot is necessary.
Please reboot at your earliest convenience.
Command exited with code 3010```

Comment threadDapper.Rainbow/Database.cs Outdated
/// <summary>
/// Get access to the underlying transaction
/// </summary>
public DbTransaction Transaction;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

property please - i.e. add {get;}

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mgravell

Copy link
Copy Markdown
Member

gotta love CI servers :/ working on it: #2042

@mgravell

Copy link
Copy Markdown
Member

CI issue fixed

@kbilsted
kbilstedforce-pushed the feature/rainbow_expose_tx branch from 11ebdae to 15cc99aCompareFebruary 14, 2024 20:53
This enables to do queries not supported by rainbow within the same transaction
ClosesDapperLib#1944
@kbilsted
kbilstedforce-pushed the feature/rainbow_expose_tx branch from 15cc99a to e0a1bccCompareFebruary 14, 2024 20:55
@mgravell
mgravell merged commit 4f8e92f into DapperLib:mainFeb 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dapper.rainbow external transaction support

2 participants

@kbilsted@mgravell