Uh oh!
There was an error while loading. Please reload this page.
Fix #2113 - #2118
Merged
Merged
Conversation
goerch
commented
Oct 3, 2024
| { | ||
| return default; | ||
| } | ||
| return new CommandDefinition(parameters is DynamicParameters ? parameters : null, flags); |
ContributorAuthor
There was a problem hiding this comment.
On a second thought: is it better to mask out some of the command flags?
JamalQasem
commented
Oct 4, 2024
CI is broken ? Tests run successfully on a local machine. |
mgravell
approved these changes
Oct 7, 2024
mgravell
commented
Oct 7, 2024
Member
CI looks to be a postgresql change on the default image. Checking. |
This was referenced Jul 24, 2025
This was referenced Aug 5, 2025
This was referenced Aug 20, 2025
This was referenced Nov 14, 2025
This was referenced Dec 1, 2025
This was referenced Dec 15, 2025
This was referenced Jan 11, 2026
This was referenced Jul 10, 2026
This was referenced Jul 17, 2026
This was referenced Jul 25, 2026
This was referenced Aug 2, 2026
This was referenced Aug 10, 2026
This was referenced Aug 28, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We also can't use
NoCacheto work around the problems in #2117. This PR seems to makeNoCachework for our use case. Thanks to @Dot-H for providing test cases.