Support Dapper overloads with CommandDefinition

[batwad]

I am using the Dapper overloads which accept a CommandDefinition because I want to pass CancellationToken, for example:

        var result = await conn.ExecuteScalarAsync<string>(new CommandDefinition("sp_CrunchNumbers",
            new
            {
                WarpFactor = 43
            },
            commandType: CommandType.StoredProcedure,
            cancellationToken: cancellationToken));

The analyzer doesn't seem to detect this usage and generate code.

If I change to the overload which takes multiple args then it does generate code, however this doesn't support CancellationToken.

        var result = await conn.ExecuteScalarAsync<string>("sp_CrunchNumbers",
            new
            {
                WarpFactor = 43
            },
            commandType: CommandType.StoredProcedure);

[giammin]

I was going crazy trying to figure out why no code was generated then I found this issue...

Are there any technical issues to implement this feature?

[DeagleGross]

Sorry, did not find time for that yet. Will try to prioritize that :)

[goremykin]

@DeagleGross, I see that the PR was created a few months ago. Are there any blockers preventing it from being merged? Do you need any help?

[DeagleGross]

@goremykin there are some changes to be made, but it's up to Marc to review and merge changes once they are of a good quality.

[adelinn]

Would be awesome if CommandDefinition becomes available win DapperAOT

[srs-adamr]

Hit this in production with native AOT (PublishAot=true, TreatWarningsAsErrors=true). The build succeeds with zero warnings, but at runtime Dapper.SqlMapper.CreateParamInfoGenerator throws PlatformNotSupportedException: Dynamic code generation is not supported on this platform.

Beyond adding CommandDefinition support, could the analyzer emit a diagnostic when it encounters a [module: DapperAot] assembly with call sites it can't intercept? Silent fallthrough to reflection-based Dapper is the worst failure mode under AOT — it's invisible at build time and only surfaces at runtime on the specific code path.

Workaround: switch from new CommandDefinition(sql, params, commandTimeout: 30) to the inline overload (sql, params, commandTimeout: 30).