Uh oh!
There was an error while loading. Please reload this page.
fix: remove return from finally block to resolve Python 3.14 SyntaxWa… - #767
Merged
Conversation
…rning Python 3.14 raises a SyntaxWarning for inside a block. Move the blocking_response return to after the try/except/finally in _LambdaDecorator.__call__, preserving all AppSec blocking execution paths. Add a regression test confirming handler exceptions still propagate when AppSec is enabled and no blocking response is active. Signed-off-by: Jordan <jordan.storms@datadoghq.com>
3 tasks
purple4reina
approved these changes
Apr 1, 2026
Signed-off-by: Jordan <jordan.storms@datadoghq.com>
Signed-off-by: Jordan <jordan.storms@datadoghq.com>
jcstorms1force-pushed
the
storms/community-pr-759
branch
from
April 2, 2026 16:18
7a87602 to
c9da727CompareUh oh!
There was an error while loading. Please reload this page.
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a community PR #759
Removes return self.blocking_response from the finally block in _LambdaDecorator.call and defers it to after the try/except/finally block, eliminating the SyntaxWarning: 'return' in a 'finally' block emitted by Python 3.14 at cold start.
Motivation
Python 3.14 introduced a SyntaxWarning for return/break/continue inside finally blocks because a return in finally silently suppresses any exception actively propagating through the try/except. This warning was firing on every Lambda cold start and polluting CloudWatch logs for anyone running on the Python 3.14 runtime.
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply