Fix dashboard list logging and restricted monitor filtering

[riyazsh]

Summary

• Fix the dashboard-list integration-dashboard drop log call to use only supported logger kwargs
• Keep dropped integration dashboard IDs in the log message for operator visibility
• Extend --skip-monitors-with-restricted-roles to filter monitors with v2 restriction_policy bindings as well as flat restricted_roles
• Add regression coverage for dashboard-list logging and monitor restriction-policy filtering

Context

PR #683 added the correct behavior for dashboard lists: integration dashboards are not portable across orgs, so list membership should drop integration_* entries before create/update. The code path logged dropped_dashboard_ids as an extra keyword argument, but the sync-cli Log.info wrapper only accepts _id and resource_type. That caused Log.info() got an unexpected keyword argument 'dropped_dashboard_ids' before the drop could complete.

For restricted monitors, the existing skip flag only filtered the legacy flat restricted_roles field. Some monitors express access control through restriction_policy.bindings[].principals instead. With this change, the same explicit skip flag also filters those monitors so DDR runs emit an intentional filtered outcome instead of trying to create/update a monitor whose access-control principals are not ready in the destination org.

Testing

• python -m pytest tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m black --line-length 120 --check datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m ruff --line-length 120 datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py

[riyazsh]

Summary

• Fix the dashboard-list integration-dashboard drop log call to use only supported logger kwargs
• Keep dropped integration dashboard IDs in the log message for operator visibility
• Extend --skip-monitors-with-restricted-roles to filter monitors with v2 restriction_policy bindings as well as flat restricted_roles
• Add regression coverage for dashboard-list logging and monitor restriction-policy filtering

Context

PR #683 added the correct behavior for dashboard lists: integration dashboards are not portable across orgs, so list membership should drop integration_* entries before create/update. The code path logged dropped_dashboard_ids as an extra keyword argument, but the sync-cli Log.info wrapper only accepts _id and resource_type. That caused Log.info() got an unexpected keyword argument 'dropped_dashboard_ids' before the drop could complete.

For restricted monitors, the existing skip flag only filtered the legacy flat restricted_roles field. Some monitors express access control through restriction_policy.bindings[].principals instead. With this change, the same explicit skip flag also filters those monitors so DDR runs emit an intentional filtered outcome instead of trying to create/update a monitor whose access-control principals are not ready in the destination org.

Testing

• python -m pytest tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m black --line-length 120 --check datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m ruff --line-length 120 datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py

[riyazsh]

Summary

• Fix the dashboard-list integration-dashboard drop log call to use only supported logger kwargs
• Keep dropped integration dashboard IDs in the log message for operator visibility
• Extend --skip-monitors-with-restricted-roles to filter monitors with v2 restriction_policy bindings as well as flat restricted_roles
• Add regression coverage for dashboard-list logging and monitor restriction-policy filtering

Context

PR #683 added the correct behavior for dashboard lists: integration dashboards are not portable across orgs, so list membership should drop integration_* entries before create/update. The code path logged dropped_dashboard_ids as an extra keyword argument, but the sync-cli Log.info wrapper only accepts _id and resource_type. That caused Log.info() got an unexpected keyword argument 'dropped_dashboard_ids' before the drop could complete.

For restricted monitors, the existing skip flag only filtered the legacy flat restricted_roles field. Some monitors express access control through restriction_policy.bindings[].principals instead. With this change, the same explicit skip flag also filters those monitors so DDR runs emit an intentional filtered outcome instead of trying to create/update a monitor whose access-control principals are not ready in the destination org.

Testing

• python -m pytest tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m black --line-length 120 --check datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m ruff --line-length 120 datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py

[riyazsh]

Summary

• Fix the dashboard-list integration-dashboard drop log call to use only supported logger kwargs
• Keep dropped integration dashboard IDs in the log message for operator visibility
• Extend --skip-monitors-with-restricted-roles to filter monitors with v2 restriction_policy bindings as well as flat restricted_roles
• Add regression coverage for dashboard-list logging and monitor restriction-policy filtering

Context

PR #683 added the correct behavior for dashboard lists: integration dashboards are not portable across orgs, so list membership should drop integration_* entries before create/update. The code path logged dropped_dashboard_ids as an extra keyword argument, but the sync-cli Log.info wrapper only accepts _id and resource_type. That caused Log.info() got an unexpected keyword argument 'dropped_dashboard_ids' before the drop could complete.

For restricted monitors, the existing skip flag only filtered the legacy flat restricted_roles field. Some monitors express access control through restriction_policy.bindings[].principals instead. With this change, the same explicit skip flag also filters those monitors so DDR runs emit an intentional filtered outcome instead of trying to create/update a monitor whose access-control principals are not ready in the destination org.

Testing

• python -m pytest tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m black --line-length 120 --check datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m ruff --line-length 120 datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py

[riyazsh]

Summary

• Fix the dashboard-list integration-dashboard drop log call to use only supported logger kwargs
• Keep dropped integration dashboard IDs in the log message for operator visibility
• Extend --skip-monitors-with-restricted-roles to filter monitors with v2 restriction_policy bindings as well as flat restricted_roles
• Add regression coverage for dashboard-list logging and monitor restriction-policy filtering

Context

PR #683 added the correct behavior for dashboard lists: integration dashboards are not portable across orgs, so list membership should drop integration_* entries before create/update. The code path logged dropped_dashboard_ids as an extra keyword argument, but the sync-cli Log.info wrapper only accepts _id and resource_type. That caused Log.info() got an unexpected keyword argument 'dropped_dashboard_ids' before the drop could complete.

For restricted monitors, the existing skip flag only filtered the legacy flat restricted_roles field. Some monitors express access control through restriction_policy.bindings[].principals instead. With this change, the same explicit skip flag also filters those monitors so DDR runs emit an intentional filtered outcome instead of trying to create/update a monitor whose access-control principals are not ready in the destination org.

Testing

• python -m pytest tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m black --line-length 120 --check datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m ruff --line-length 120 datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py

[riyazsh]

Summary

• Fix the dashboard-list integration-dashboard drop log call to use only supported logger kwargs
• Keep dropped integration dashboard IDs in the log message for operator visibility
• Extend --skip-monitors-with-restricted-roles to filter monitors with v2 restriction_policy bindings as well as flat restricted_roles
• Add regression coverage for dashboard-list logging and monitor restriction-policy filtering

Context

PR #683 added the correct behavior for dashboard lists: integration dashboards are not portable across orgs, so list membership should drop integration_* entries before create/update. The code path logged dropped_dashboard_ids as an extra keyword argument, but the sync-cli Log.info wrapper only accepts _id and resource_type. That caused Log.info() got an unexpected keyword argument 'dropped_dashboard_ids' before the drop could complete.

For restricted monitors, the existing skip flag only filtered the legacy flat restricted_roles field. Some monitors express access control through restriction_policy.bindings[].principals instead. With this change, the same explicit skip flag also filters those monitors so DDR runs emit an intentional filtered outcome instead of trying to create/update a monitor whose access-control principals are not ready in the destination org.

Testing

• python -m pytest tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m black --line-length 120 --check datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m ruff --line-length 120 datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py

[riyazsh]

Summary

• Fix the dashboard-list integration-dashboard drop log call to use only supported logger kwargs
• Keep dropped integration dashboard IDs in the log message for operator visibility
• Extend --skip-monitors-with-restricted-roles to filter monitors with v2 restriction_policy bindings as well as flat restricted_roles
• Add regression coverage for dashboard-list logging and monitor restriction-policy filtering

Context

PR #683 added the correct behavior for dashboard lists: integration dashboards are not portable across orgs, so list membership should drop integration_* entries before create/update. The code path logged dropped_dashboard_ids as an extra keyword argument, but the sync-cli Log.info wrapper only accepts _id and resource_type. That caused Log.info() got an unexpected keyword argument 'dropped_dashboard_ids' before the drop could complete.

For restricted monitors, the existing skip flag only filtered the legacy flat restricted_roles field. Some monitors express access control through restriction_policy.bindings[].principals instead. With this change, the same explicit skip flag also filters those monitors so DDR runs emit an intentional filtered outcome instead of trying to create/update a monitor whose access-control principals are not ready in the destination org.

Testing

• python -m pytest tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m black --line-length 120 --check datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m ruff --line-length 120 datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py

[riyazsh]

Summary

• Fix the dashboard-list integration-dashboard drop log call to use only supported logger kwargs
• Keep dropped integration dashboard IDs in the log message for operator visibility
• Extend --skip-monitors-with-restricted-roles to filter monitors with v2 restriction_policy bindings as well as flat restricted_roles
• Add regression coverage for dashboard-list logging and monitor restriction-policy filtering

Context

PR #683 added the correct behavior for dashboard lists: integration dashboards are not portable across orgs, so list membership should drop integration_* entries before create/update. The code path logged dropped_dashboard_ids as an extra keyword argument, but the sync-cli Log.info wrapper only accepts _id and resource_type. That caused Log.info() got an unexpected keyword argument 'dropped_dashboard_ids' before the drop could complete.

For restricted monitors, the existing skip flag only filtered the legacy flat restricted_roles field. Some monitors express access control through restriction_policy.bindings[].principals instead. With this change, the same explicit skip flag also filters those monitors so DDR runs emit an intentional filtered outcome instead of trying to create/update a monitor whose access-control principals are not ready in the destination org.

Testing

• python -m pytest tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m black --line-length 120 --check datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py
• python -m ruff --line-length 120 datadog_sync/model/monitors.py datadog_sync/commands/shared/options.py tests/unit/test_monitors.py tests/unit/test_dashboard_lists.py