Skip to content

[branch-48] Fix duplicates on Join creation during physical planning - #33

Merged
LiaCastaneda merged 1 commit into
branch-48from
lia/cherry-pick-duplicate-names-error-2
Jul 7, 2025
Merged

[branch-48] Fix duplicates on Join creation during physical planning#33
LiaCastaneda merged 1 commit into
branch-48from
lia/cherry-pick-duplicate-names-error-2

Conversation

@LiaCastaneda

@LiaCastanedaLiaCastaneda commented Jun 19, 2025•
edited
Loading

Copy link
Copy Markdown

@LiaCastaneda
LiaCastanedaforce-pushed the lia/cherry-pick-duplicate-names-error-2 branch from 6287611 to ed6b3a5CompareJune 19, 2025 12:40
@LiaCastanedaLiaCastaneda changed the title Fix duplicates on Join creation during physcial planningFix duplicates on Join creation during physical planningJun 19, 2025
@LiaCastaneda
LiaCastanedaforce-pushed the lia/cherry-pick-duplicate-names-error-2 branch from ed6b3a5 to 2825428CompareJuly 7, 2025 14:18
@LiaCastaneda
Fix duplicate field name error in Join::try_new_with_project_input du…
6971955
…ring physical planning (apache#16454)
* Fix duplicates on Join creation during physcial planning
* Add Substrait reproducer
* Better error message & more doc
* Handle case for right/left/full joins as well
@LiaCastaneda
LiaCastanedaforce-pushed the lia/cherry-pick-duplicate-names-error-2 branch from 2825428 to 6971955CompareJuly 7, 2025 14:20
@LiaCastaneda
LiaCastaneda marked this pull request as ready for review July 7, 2025 14:32
fmonjalet
fmonjalet approved these changes Jul 7, 2025
View reviewed changes

@fmonjaletfmonjalet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, you can also add -x to your cherry pick command to include the original commit ref (don't mind for this one)

@LiaCastaneda

LiaCastaneda commented Jul 7, 2025

Copy link
Copy Markdown
Author

/merge

@dd-devflow

dd-devflowBot commented Jul 7, 2025•
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-07 14:53:32 UTC ℹ️ Start processing command /merge

2025-07-07 14:53:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in branch-48 is approximately 0s (p90).

2025-07-07 15:20:35 UTC⚠️MergeQueue: This merge request build was cancelled

lia.castaneda@datadoghq.com cancelled this merge request build since it was merged manually

@LiaCastaneda

LiaCastaneda commented Jul 7, 2025

Copy link
Copy Markdown
Author

/remove

@dd-devflow

dd-devflowBot commented Jul 7, 2025•
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-07 15:20:21 UTC ℹ️ Start processing command /remove

2025-07-07 15:20:32 UTC ℹ️ Devflow:/remove

@LiaCastaneda
LiaCastaneda merged commit fc37f3b into branch-48Jul 7, 2025
55 of 57 checks passed
@gabotechsgabotechs changed the title Fix duplicates on Join creation during physical planning[branch-48] Fix duplicates on Join creation during physical planningAug 4, 2025
@LiaCastaneda
LiaCastaneda deleted the lia/cherry-pick-duplicate-names-error-2 branch January 13, 2026 18:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmonjaletfmonjaletfmonjalet approved these changes
@gabotechsgabotechsgabotechs approved these changes

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LiaCastaneda@fmonjalet@gabotechs