Changed order of clients and server shutdown to prevent freeze on GitLab CI. by AlexeyKuznetsov-DD · Pull Request #10104 · DataDog/dd-trace-java

AlexeyKuznetsov-DD · 2025-12-08T21:36:12Z

What Does This Do

Refactored test to follow the proper cleanup pattern: resources should be released in reverse order of their creation, and dependencies (clients) should be cleaned up before the things they depend on (the server).

Motivation

Test is freezing from time to time (not too often, but still) on GitLab CI with thread dump like:

"Test worker" #1 [48480] prio=5 os_prio=0 cpu=6671.20ms elapsed=1145.91s tid=0x00007f48f8032b90 nid=48480 in Object.wait() [0x00007f48fedb4000]
java.lang.Thread.State: WAITING (on object monitor)
at java.lang.Object.wait0(java.base@21.0.9/Native Method)
- waiting on <no object reference available>
at java.lang.Object.wait(java.base@21.0.9/Object.java:366)
at java.lang.Object.wait(java.base@21.0.9/Object.java:339)
at io.netty.util.concurrent.DefaultPromise.awaitUninterruptibly(DefaultPromise.java:286)
- locked <0x00000000c38034f8> (a io.netty.util.concurrent.DefaultPromise)
at io.netty.util.concurrent.DefaultPromise.syncUninterruptibly(DefaultPromise.java:225)
at io.netty.util.concurrent.DefaultPromise.syncUninterruptibly(DefaultPromise.java:32)
at org.redisson.connection.MasterSlaveConnectionManager.shutdown(MasterSlaveConnectionManager.java:472)
at org.redisson.Redisson.shutdown(Redisson.java:301)
at org.redisson.RedissonClient$shutdown$7.call(Unknown Source)
at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
at RedissonClientTest.cleanupSpec(RedissonClientTest.groovy:53)

Additional Notes

…Lab CI. This follows the proper cleanup pattern: resources should be released in reverse order of their creation, and dependencies (clients) should be cleaned up before the things they depend on (the server).

pr-commenter · 2025-12-08T22:19:54Z

Benchmarks

⚠️Warning: Baseline build not found for merge-base commit. Comparing against the latest commit on master instead.

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/redison-spec-cleanup-fix
git_commit_date	1765222535	1765229055
git_commit_sha	`94e770c`	`827bf4a`
release_version	1.57.0-SNAPSHOT~94e770cd67	1.57.0-SNAPSHOT~827bf4a800

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765231387	1765231387
ci_job_id	1277560012	1277560012
ci_pipeline_id	85420055	85420055
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-7df0s9ai 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-7df0s9ai 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~827bf4a800, baseline=1.57.0-SNAPSHOT~94e770cd67
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088433
Total [baseline] (10.842 s) : 0, 10841546
Agent [candidate] (1.082 s) : 0, 1081834
Total [candidate] (10.847 s) : 0, 10846908
section appsec
Agent [baseline] (1.274 s) : 0, 1273555
Total [baseline] (11.078 s) : 0, 11077842
Agent [candidate] (1.262 s) : 0, 1262305
Total [candidate] (11.137 s) : 0, 11137353
section iast
Agent [baseline] (1.224 s) : 0, 1224228
Total [baseline] (11.113 s) : 0, 11113032
Agent [candidate] (1.224 s) : 0, 1224134
Total [candidate] (11.071 s) : 0, 11071409
section profiling
Agent [baseline] (1.205 s) : 0, 1204866
Total [baseline] (10.989 s) : 0, 10989049
Agent [candidate] (1.205 s) : 0, 1204958
Total [candidate] (11.031 s) : 0, 11030709

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	appsec	1.274 s	185.122 ms (17.0%)
Agent	iast	1.224 s	135.795 ms (12.5%)
Agent	profiling	1.205 s	116.433 ms (10.7%)
Total	tracing	10.842 s	-
Total	appsec	11.078 s	236.296 ms (2.2%)
Total	iast	11.113 s	271.486 ms (2.5%)
Total	profiling	10.989 s	147.503 ms (1.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.082 s	-
Agent	appsec	1.262 s	180.471 ms (16.7%)
Agent	iast	1.224 s	142.3 ms (13.2%)
Agent	profiling	1.205 s	123.123 ms (11.4%)
Total	tracing	10.847 s	-
Total	appsec	11.137 s	290.445 ms (2.7%)
Total	iast	11.071 s	224.501 ms (2.1%)
Total	profiling	11.031 s	183.801 ms (1.7%)

gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~827bf4a800, baseline=1.57.0-SNAPSHOT~94e770cd67
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (653.538 ms) : 0, 653538
BytebuddyAgent [candidate] (649.116 ms) : 0, 649116
GlobalTracer [baseline] (283.282 ms) : 0, 283282
GlobalTracer [candidate] (282.034 ms) : 0, 282034
AppSec [baseline] (32.661 ms) : 0, 32661
AppSec [candidate] (32.307 ms) : 0, 32307
Debugger [baseline] (68.723 ms) : 0, 68723
Debugger [candidate] (68.292 ms) : 0, 68292
Remote Config [baseline] (639.242 µs) : 0, 639
Remote Config [candidate] (691.357 µs) : 0, 691
Telemetry [baseline] (9.046 ms) : 0, 9046
Telemetry [candidate] (9.044 ms) : 0, 9044
Flare Poller [baseline] (3.764 ms) : 0, 3764
Flare Poller [candidate] (3.782 ms) : 0, 3782
section appsec
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (694.462 ms) : 0, 694462
BytebuddyAgent [candidate] (688.198 ms) : 0, 688198
GlobalTracer [baseline] (261.432 ms) : 0, 261432
GlobalTracer [candidate] (258.824 ms) : 0, 258824
AppSec [baseline] (175.914 ms) : 0, 175914
AppSec [candidate] (173.875 ms) : 0, 173875
Debugger [baseline] (66.467 ms) : 0, 66467
Debugger [candidate] (66.7 ms) : 0, 66700
Remote Config [baseline] (690.337 µs) : 0, 690
Remote Config [candidate] (701.691 µs) : 0, 702
Telemetry [baseline] (8.987 ms) : 0, 8987
Telemetry [candidate] (9.025 ms) : 0, 9025
Flare Poller [baseline] (3.843 ms) : 0, 3843
Flare Poller [candidate] (3.886 ms) : 0, 3886
IAST [baseline] (24.896 ms) : 0, 24896
IAST [candidate] (24.448 ms) : 0, 24448
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (791.569 ms) : 0, 791569
BytebuddyAgent [candidate] (791.485 ms) : 0, 791485
GlobalTracer [baseline] (255.675 ms) : 0, 255675
GlobalTracer [candidate] (255.388 ms) : 0, 255388
AppSec [baseline] (35.37 ms) : 0, 35370
AppSec [candidate] (35.341 ms) : 0, 35341
Debugger [baseline] (65.656 ms) : 0, 65656
Debugger [candidate] (66.037 ms) : 0, 66037
Remote Config [baseline] (592.546 µs) : 0, 593
Remote Config [candidate] (589.371 µs) : 0, 589
Telemetry [baseline] (8.377 ms) : 0, 8377
Telemetry [candidate] (8.394 ms) : 0, 8394
Flare Poller [baseline] (3.467 ms) : 0, 3467
Flare Poller [candidate] (3.462 ms) : 0, 3462
IAST [baseline] (27.002 ms) : 0, 27002
IAST [candidate] (26.946 ms) : 0, 26946
section profiling
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (702.85 ms) : 0, 702850
BytebuddyAgent [candidate] (702.136 ms) : 0, 702136
GlobalTracer [baseline] (220.797 ms) : 0, 220797
GlobalTracer [candidate] (221.158 ms) : 0, 221158
AppSec [baseline] (32.296 ms) : 0, 32296
AppSec [candidate] (32.296 ms) : 0, 32296
Debugger [baseline] (67.859 ms) : 0, 67859
Debugger [candidate] (67.976 ms) : 0, 67976
Remote Config [baseline] (625.528 µs) : 0, 626
Remote Config [candidate] (659.967 µs) : 0, 660
Telemetry [baseline] (8.91 ms) : 0, 8910
Telemetry [candidate] (8.937 ms) : 0, 8937
Flare Poller [baseline] (3.781 ms) : 0, 3781
Flare Poller [candidate] (3.773 ms) : 0, 3773
ProfilingAgent [baseline] (97.11 ms) : 0, 97110
ProfilingAgent [candidate] (97.315 ms) : 0, 97315
Profiling [baseline] (97.694 ms) : 0, 97694
Profiling [candidate] (97.88 ms) : 0, 97880

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~827bf4a800, baseline=1.57.0-SNAPSHOT~94e770cd67
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077791
Total [baseline] (8.742 s) : 0, 8742280
Agent [candidate] (1.079 s) : 0, 1078573
Total [candidate] (8.728 s) : 0, 8727798
section iast
Agent [baseline] (1.219 s) : 0, 1219236
Total [baseline] (9.459 s) : 0, 9459294
Agent [candidate] (1.23 s) : 0, 1229545
Total [candidate] (9.441 s) : 0, 9440875

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.078 s	-
Agent	iast	1.219 s	141.445 ms (13.1%)
Total	tracing	8.742 s	-
Total	iast	9.459 s	717.014 ms (8.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.079 s	-
Agent	iast	1.23 s	150.972 ms (14.0%)
Total	tracing	8.728 s	-
Total	iast	9.441 s	713.077 ms (8.2%)

gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~827bf4a800, baseline=1.57.0-SNAPSHOT~94e770cd67
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (647.061 ms) : 0, 647061
BytebuddyAgent [candidate] (647.747 ms) : 0, 647747
GlobalTracer [baseline] (281.021 ms) : 0, 281021
GlobalTracer [candidate] (281.41 ms) : 0, 281410
AppSec [baseline] (32.333 ms) : 0, 32333
AppSec [candidate] (32.214 ms) : 0, 32214
Debugger [baseline] (67.288 ms) : 0, 67288
Debugger [candidate] (67.148 ms) : 0, 67148
Remote Config [baseline] (655.406 µs) : 0, 655
Remote Config [candidate] (645.357 µs) : 0, 645
Telemetry [baseline] (8.993 ms) : 0, 8993
Telemetry [candidate] (9.015 ms) : 0, 9015
Flare Poller [baseline] (3.821 ms) : 0, 3821
Flare Poller [candidate] (3.755 ms) : 0, 3755
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (788.579 ms) : 0, 788579
BytebuddyAgent [candidate] (796.559 ms) : 0, 796559
GlobalTracer [baseline] (255.408 ms) : 0, 255408
GlobalTracer [candidate] (256.71 ms) : 0, 256710
AppSec [baseline] (34.61 ms) : 0, 34610
AppSec [candidate] (35.403 ms) : 0, 35403
Debugger [baseline] (64.958 ms) : 0, 64958
Debugger [candidate] (64.69 ms) : 0, 64690
Remote Config [baseline] (584.034 µs) : 0, 584
Remote Config [candidate] (566.495 µs) : 0, 566
Telemetry [baseline] (8.334 ms) : 0, 8334
Telemetry [candidate] (8.369 ms) : 0, 8369
Flare Poller [baseline] (3.45 ms) : 0, 3450
Flare Poller [candidate] (3.439 ms) : 0, 3439
IAST [baseline] (26.857 ms) : 0, 26857
IAST [candidate] (27.006 ms) : 0, 27006

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/redison-spec-cleanup-fix
git_commit_date	1765222535	1765229055
git_commit_sha	`94e770c`	`827bf4a`
release_version	1.57.0-SNAPSHOT~94e770cd67	1.57.0-SNAPSHOT~827bf4a800

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765231814	1765231814
ci_job_id	1277560014	1277560014
ci_pipeline_id	85420055	85420055
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-dp7ljouw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-dp7ljouw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	better [-192.709µs; -81.311µs] or [-6.437%; -2.716%]	better [-665.243µs; -225.389µs] or [-7.924%; -2.685%]	unstable [-74.664op/s; +188.102op/s] or [-6.116%; +15.408%]	2.857ms	7.950ms	1277.531op/s	2.994ms	8.396ms	1220.812op/s

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~827bf4a800, baseline=1.57.0-SNAPSHOT~94e770cd67
dateFormat X
axisFormat %s
section baseline
no_agent (1.22 ms) : 1208, 1233
. : milestone, 1220,
iast (3.299 ms) : 3259, 3339
. : milestone, 3299,
iast_FULL (5.849 ms) : 5790, 5907
. : milestone, 5849,
iast_GLOBAL (3.76 ms) : 3704, 3817
. : milestone, 3760,
profiling (2.141 ms) : 2122, 2160
. : milestone, 2141,
tracing (1.836 ms) : 1821, 1852
. : milestone, 1836,
section candidate
no_agent (1.215 ms) : 1203, 1227
. : milestone, 1215,
iast (3.222 ms) : 3175, 3269
. : milestone, 3222,
iast_FULL (5.861 ms) : 5802, 5920
. : milestone, 5861,
iast_GLOBAL (3.59 ms) : 3537, 3643
. : milestone, 3590,
profiling (2.1 ms) : 2081, 2119
. : milestone, 2100,
tracing (1.81 ms) : 1795, 1826
. : milestone, 1810,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.22 ms [1.208 ms, 1.233 ms]	-
iast	3.299 ms [3.259 ms, 3.339 ms]	2.079 ms (170.3%)
iast_FULL	5.849 ms [5.79 ms, 5.907 ms]	4.628 ms (379.2%)
iast_GLOBAL	3.76 ms [3.704 ms, 3.817 ms]	2.54 ms (208.1%)
profiling	2.141 ms [2.122 ms, 2.16 ms]	920.371 µs (75.4%)
tracing	1.836 ms [1.821 ms, 1.852 ms]	615.93 µs (50.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.215 ms [1.203 ms, 1.227 ms]	-
iast	3.222 ms [3.175 ms, 3.269 ms]	2.007 ms (165.1%)
iast_FULL	5.861 ms [5.802 ms, 5.92 ms]	4.646 ms (382.2%)
iast_GLOBAL	3.59 ms [3.537 ms, 3.643 ms]	2.374 ms (195.3%)
profiling	2.1 ms [2.081 ms, 2.119 ms]	884.224 µs (72.7%)
tracing	1.81 ms [1.795 ms, 1.826 ms]	595.007 µs (49.0%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~827bf4a800, baseline=1.57.0-SNAPSHOT~94e770cd67
dateFormat X
axisFormat %s
section baseline
no_agent (18.181 ms) : 17999, 18363
. : milestone, 18181,
appsec (18.732 ms) : 18544, 18920
. : milestone, 18732,
code_origins (17.627 ms) : 17455, 17800
. : milestone, 17627,
iast (17.471 ms) : 17300, 17643
. : milestone, 17471,
profiling (19.008 ms) : 18817, 19199
. : milestone, 19008,
tracing (17.722 ms) : 17546, 17898
. : milestone, 17722,
section candidate
no_agent (18.143 ms) : 17958, 18328
. : milestone, 18143,
appsec (18.809 ms) : 18621, 18997
. : milestone, 18809,
code_origins (17.836 ms) : 17660, 18012
. : milestone, 17836,
iast (17.846 ms) : 17671, 18021
. : milestone, 17846,
profiling (20.118 ms) : 19904, 20331
. : milestone, 20118,
tracing (17.716 ms) : 17540, 17892
. : milestone, 17716,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.181 ms [17.999 ms, 18.363 ms]	-
appsec	18.732 ms [18.544 ms, 18.92 ms]	551.055 µs (3.0%)
code_origins	17.627 ms [17.455 ms, 17.8 ms]	-553.586 µs (-3.0%)
iast	17.471 ms [17.3 ms, 17.643 ms]	-709.757 µs (-3.9%)
profiling	19.008 ms [18.817 ms, 19.199 ms]	826.98 µs (4.5%)
tracing	17.722 ms [17.546 ms, 17.898 ms]	-459.399 µs (-2.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.143 ms [17.958 ms, 18.328 ms]	-
appsec	18.809 ms [18.621 ms, 18.997 ms]	665.882 µs (3.7%)
code_origins	17.836 ms [17.66 ms, 18.012 ms]	-307.707 µs (-1.7%)
iast	17.846 ms [17.671 ms, 18.021 ms]	-297.022 µs (-1.6%)
profiling	20.118 ms [19.904 ms, 20.331 ms]	1.974 ms (10.9%)
tracing	17.716 ms [17.54 ms, 17.892 ms]	-426.907 µs (-2.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/redison-spec-cleanup-fix
git_commit_date	1765222535	1765229055
git_commit_sha	`94e770c`	`827bf4a`
release_version	1.57.0-SNAPSHOT~94e770cd67	1.57.0-SNAPSHOT~827bf4a800

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1765231525	1765231525
ci_job_id	1277560017	1277560017
ci_pipeline_id	85420055	85420055
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-psxnfcc1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-psxnfcc1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:dacapo:tomcat:appsec	better [-1.350ms; -1.005ms] or [-36.494%; -27.172%]	2.521ms	3.699ms

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~827bf4a800, baseline=1.57.0-SNAPSHOT~94e770cd67
dateFormat X
axisFormat %s
section baseline
no_agent (15.652 s) : 15652000, 15652000
. : milestone, 15652000,
appsec (14.411 s) : 14411000, 14411000
. : milestone, 14411000,
iast (18.053 s) : 18053000, 18053000
. : milestone, 18053000,
iast_GLOBAL (17.96 s) : 17960000, 17960000
. : milestone, 17960000,
profiling (15.108 s) : 15108000, 15108000
. : milestone, 15108000,
tracing (14.655 s) : 14655000, 14655000
. : milestone, 14655000,
section candidate
no_agent (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
appsec (14.621 s) : 14621000, 14621000
. : milestone, 14621000,
iast (18.446 s) : 18446000, 18446000
. : milestone, 18446000,
iast_GLOBAL (18.102 s) : 18102000, 18102000
. : milestone, 18102000,
profiling (14.583 s) : 14583000, 14583000
. : milestone, 14583000,
tracing (14.781 s) : 14781000, 14781000
. : milestone, 14781000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.652 s [15.652 s, 15.652 s]	-
appsec	14.411 s [14.411 s, 14.411 s]	-1.241 s (-7.9%)
iast	18.053 s [18.053 s, 18.053 s]	2.401 s (15.3%)
iast_GLOBAL	17.96 s [17.96 s, 17.96 s]	2.308 s (14.7%)
profiling	15.108 s [15.108 s, 15.108 s]	-544.0 ms (-3.5%)
tracing	14.655 s [14.655 s, 14.655 s]	-997.0 ms (-6.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.975 s [14.975 s, 14.975 s]	-
appsec	14.621 s [14.621 s, 14.621 s]	-354.0 ms (-2.4%)
iast	18.446 s [18.446 s, 18.446 s]	3.471 s (23.2%)
iast_GLOBAL	18.102 s [18.102 s, 18.102 s]	3.127 s (20.9%)
profiling	14.583 s [14.583 s, 14.583 s]	-392.0 ms (-2.6%)
tracing	14.781 s [14.781 s, 14.781 s]	-194.0 ms (-1.3%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~827bf4a800, baseline=1.57.0-SNAPSHOT~94e770cd67
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.699 ms) : 3479, 3919
. : milestone, 3699,
iast (2.227 ms) : 2163, 2291
. : milestone, 2227,
iast_GLOBAL (2.271 ms) : 2206, 2336
. : milestone, 2271,
profiling (2.088 ms) : 2034, 2143
. : milestone, 2088,
tracing (2.042 ms) : 1992, 2093
. : milestone, 2042,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.521 ms) : 2467, 2576
. : milestone, 2521,
iast (2.22 ms) : 2156, 2285
. : milestone, 2220,
iast_GLOBAL (2.268 ms) : 2203, 2333
. : milestone, 2268,
profiling (2.07 ms) : 2018, 2122
. : milestone, 2070,
tracing (2.053 ms) : 2002, 2104
. : milestone, 2053,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.468 ms, 1.491 ms]	-
appsec	3.699 ms [3.479 ms, 3.919 ms]	2.22 ms (150.0%)
iast	2.227 ms [2.163 ms, 2.291 ms]	747.394 µs (50.5%)
iast_GLOBAL	2.271 ms [2.206 ms, 2.336 ms]	791.657 µs (53.5%)
profiling	2.088 ms [2.034 ms, 2.143 ms]	608.964 µs (41.2%)
tracing	2.042 ms [1.992 ms, 2.093 ms]	562.924 µs (38.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.48 ms [1.468 ms, 1.491 ms]	-
appsec	2.521 ms [2.467 ms, 2.576 ms]	1.042 ms (70.4%)
iast	2.22 ms [2.156 ms, 2.285 ms]	740.901 µs (50.1%)
iast_GLOBAL	2.268 ms [2.203 ms, 2.333 ms]	788.402 µs (53.3%)
profiling	2.07 ms [2.018 ms, 2.122 ms]	590.173 µs (39.9%)
tracing	2.053 ms [2.002 ms, 2.104 ms]	573.498 µs (38.8%)

Changed order of clients and server shutdown to prevent freeze on Git…
827bf4a
…Lab CI. This follows the proper cleanup pattern: resources should be released in reverse order of their creation, and dependencies (clients) should be cleaned up before the things they depend on (the server).

AlexeyKuznetsov-DD requested a review from sarahchen6 December 8, 2025 21:36

AlexeyKuznetsov-DD self-assigned this Dec 8, 2025

AlexeyKuznetsov-DD added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes inst: redis Redis instrumentation labels Dec 8, 2025

AlexeyKuznetsov-DD temporarily deployed to ci-build December 8, 2025 21:36 — with GitHub Actions Inactive

AlexeyKuznetsov-DD marked this pull request as ready for review December 8, 2025 21:37

AlexeyKuznetsov-DD requested a review from a team as a code owner December 8, 2025 21:37

bric3 approved these changes Dec 9, 2025
View reviewed changes

AlexeyKuznetsov-DD merged commit a10ebc2 into masterDec 9, 2025
548 of 550 checks passed

AlexeyKuznetsov-DD deleted the alexeyk/redison-spec-cleanup-fix branch December 9, 2025 15:10

github-actionsBot added this to the 1.57.0 milestone Dec 9, 2025

Navigation Menu

Uh oh!

Changed order of clients and server shutdown to prevent freeze on GitLab CI. - #10104

Changed order of clients and server shutdown to prevent freeze on GitLab CI.#10104
AlexeyKuznetsov-DD merged 1 commit into
masterfrom
alexeyk/redison-spec-cleanup-fix

AlexeyKuznetsov-DD commented Dec 8, 2025•
edited
Loading

Uh oh!

pr-commenterBot commented Dec 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

AlexeyKuznetsov-DD commented Dec 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Uh oh!

pr-commenterBot commented Dec 8, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AlexeyKuznetsov-DD commented Dec 8, 2025•
edited
Loading