Uh oh!
There was an error while loading. Please reload this page.
Migrate dd-trace-api Groovy files to Java (part 1) - #10759
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intoMar 10, 2026
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~4d4977aee7, baseline=1.61.0-SNAPSHOT~08d4d6a17b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060029
Total [baseline] (8.822 s) : 0, 8822357
Agent [candidate] (1.062 s) : 0, 1061501
Total [candidate] (8.856 s) : 0, 8855750
section iast
Agent [baseline] (1.227 s) : 0, 1226768
Total [baseline] (9.505 s) : 0, 9504599
Agent [candidate] (1.226 s) : 0, 1226304
Total [candidate] (9.516 s) : 0, 9516496
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~4d4977aee7, baseline=1.61.0-SNAPSHOT~08d4d6a17b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (629.45 ms) : 0, 629450
BytebuddyAgent [candidate] (629.65 ms) : 0, 629650
AgentMeter [baseline] (29.164 ms) : 0, 29164
AgentMeter [candidate] (29.067 ms) : 0, 29067
GlobalTracer [baseline] (257.061 ms) : 0, 257061
GlobalTracer [candidate] (257.064 ms) : 0, 257064
AppSec [baseline] (31.718 ms) : 0, 31718
AppSec [candidate] (31.599 ms) : 0, 31599
Debugger [baseline] (58.915 ms) : 0, 58915
Debugger [candidate] (58.834 ms) : 0, 58834
Remote Config [baseline] (599.394 µs) : 0, 599
Remote Config [candidate] (589.033 µs) : 0, 589
Telemetry [baseline] (8.616 ms) : 0, 8616
Telemetry [candidate] (8.68 ms) : 0, 8680
Flare Poller [baseline] (7.228 ms) : 0, 7228
Flare Poller [candidate] (8.667 ms) : 0, 8667
section iast
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (796.033 ms) : 0, 796033
BytebuddyAgent [candidate] (796.602 ms) : 0, 796602
AgentMeter [baseline] (11.345 ms) : 0, 11345
AgentMeter [candidate] (11.337 ms) : 0, 11337
GlobalTracer [baseline] (247.83 ms) : 0, 247830
GlobalTracer [candidate] (247.275 ms) : 0, 247275
IAST [baseline] (25.219 ms) : 0, 25219
IAST [candidate] (25.165 ms) : 0, 25165
AppSec [baseline] (26.578 ms) : 0, 26578
AppSec [candidate] (27.201 ms) : 0, 27201
Debugger [baseline] (62.265 ms) : 0, 62265
Debugger [candidate] (61.279 ms) : 0, 61279
Remote Config [baseline] (526.301 µs) : 0, 526
Remote Config [candidate] (522.551 µs) : 0, 523
Telemetry [baseline] (14.803 ms) : 0, 14803
Telemetry [candidate] (14.78 ms) : 0, 14780
Flare Poller [baseline] (4.872 ms) : 0, 4872
Flare Poller [candidate] (4.874 ms) : 0, 4874
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~4d4977aee7, baseline=1.61.0-SNAPSHOT~08d4d6a17b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055870
Total [baseline] (10.947 s) : 0, 10947089
Agent [candidate] (1.056 s) : 0, 1055713
Total [candidate] (10.949 s) : 0, 10948569
section appsec
Agent [baseline] (1.243 s) : 0, 1243497
Total [baseline] (11.072 s) : 0, 11072408
Agent [candidate] (1.251 s) : 0, 1251315
Total [candidate] (11.132 s) : 0, 11131728
section iast
Agent [baseline] (1.226 s) : 0, 1225607
Total [baseline] (11.305 s) : 0, 11304623
Agent [candidate] (1.223 s) : 0, 1222511
Total [candidate] (11.347 s) : 0, 11347282
section profiling
Agent [baseline] (1.177 s) : 0, 1177375
Total [baseline] (10.93 s) : 0, 10930023
Agent [candidate] (1.182 s) : 0, 1182012
Total [candidate] (11.009 s) : 0, 11008536
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~4d4977aee7, baseline=1.61.0-SNAPSHOT~08d4d6a17b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (626.982 ms) : 0, 626982
BytebuddyAgent [candidate] (626.617 ms) : 0, 626617
AgentMeter [baseline] (29.131 ms) : 0, 29131
AgentMeter [candidate] (29.18 ms) : 0, 29180
GlobalTracer [baseline] (256.256 ms) : 0, 256256
GlobalTracer [candidate] (256.355 ms) : 0, 256355
AppSec [baseline] (31.418 ms) : 0, 31418
AppSec [candidate] (31.531 ms) : 0, 31531
Debugger [baseline] (59.192 ms) : 0, 59192
Debugger [candidate] (59.261 ms) : 0, 59261
Remote Config [baseline] (594.352 µs) : 0, 594
Remote Config [candidate] (581.735 µs) : 0, 582
Telemetry [baseline] (8.619 ms) : 0, 8619
Telemetry [candidate] (8.61 ms) : 0, 8610
Flare Poller [baseline] (6.505 ms) : 0, 6505
Flare Poller [candidate] (6.453 ms) : 0, 6453
section appsec
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (657.198 ms) : 0, 657198
BytebuddyAgent [candidate] (661.054 ms) : 0, 661054
AgentMeter [baseline] (11.982 ms) : 0, 11982
AgentMeter [candidate] (12.042 ms) : 0, 12042
GlobalTracer [baseline] (257.525 ms) : 0, 257525
GlobalTracer [candidate] (259.15 ms) : 0, 259150
IAST [baseline] (23.952 ms) : 0, 23952
IAST [candidate] (24.106 ms) : 0, 24106
AppSec [baseline] (177.017 ms) : 0, 177017
AppSec [candidate] (178.06 ms) : 0, 178060
Debugger [baseline] (64.502 ms) : 0, 64502
Debugger [candidate] (66.174 ms) : 0, 66174
Remote Config [baseline] (575.661 µs) : 0, 576
Remote Config [candidate] (577.208 µs) : 0, 577
Telemetry [baseline] (9.764 ms) : 0, 9764
Telemetry [candidate] (9.0 ms) : 0, 9000
Flare Poller [baseline] (3.613 ms) : 0, 3613
Flare Poller [candidate] (3.639 ms) : 0, 3639
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (794.714 ms) : 0, 794714
BytebuddyAgent [candidate] (793.08 ms) : 0, 793080
AgentMeter [baseline] (11.269 ms) : 0, 11269
AgentMeter [candidate] (11.288 ms) : 0, 11288
GlobalTracer [baseline] (247.016 ms) : 0, 247016
GlobalTracer [candidate] (246.483 ms) : 0, 246483
IAST [baseline] (25.14 ms) : 0, 25140
IAST [candidate] (25.046 ms) : 0, 25046
AppSec [baseline] (26.43 ms) : 0, 26430
AppSec [candidate] (26.263 ms) : 0, 26263
Debugger [baseline] (63.62 ms) : 0, 63620
Debugger [candidate] (63.148 ms) : 0, 63148
Remote Config [baseline] (529.416 µs) : 0, 529
Remote Config [candidate] (524.073 µs) : 0, 524
Telemetry [baseline] (14.885 ms) : 0, 14885
Telemetry [candidate] (14.753 ms) : 0, 14753
Flare Poller [baseline] (4.87 ms) : 0, 4870
Flare Poller [candidate] (4.848 ms) : 0, 4848
section profiling
crashtracking [baseline] (1.163 ms) : 0, 1163
crashtracking [candidate] (1.162 ms) : 0, 1162
BytebuddyAgent [baseline] (679.533 ms) : 0, 679533
BytebuddyAgent [candidate] (682.259 ms) : 0, 682259
AgentMeter [baseline] (8.571 ms) : 0, 8571
AgentMeter [candidate] (8.622 ms) : 0, 8622
GlobalTracer [baseline] (214.576 ms) : 0, 214576
GlobalTracer [candidate] (215.706 ms) : 0, 215706
AppSec [baseline] (31.935 ms) : 0, 31935
AppSec [candidate] (31.985 ms) : 0, 31985
Debugger [baseline] (64.07 ms) : 0, 64070
Debugger [candidate] (63.629 ms) : 0, 63629
Remote Config [baseline] (587.475 µs) : 0, 587
Remote Config [candidate] (587.501 µs) : 0, 588
Telemetry [baseline] (9.012 ms) : 0, 9012
Telemetry [candidate] (9.683 ms) : 0, 9683
Flare Poller [baseline] (3.483 ms) : 0, 3483
Flare Poller [candidate] (3.543 ms) : 0, 3543
ProfilingAgent [baseline] (93.909 ms) : 0, 93909
ProfilingAgent [candidate] (93.963 ms) : 0, 93963
Profiling [baseline] (94.478 ms) : 0, 94478
Profiling [candidate] (94.529 ms) : 0, 94529
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~4d4977aee7, baseline=1.61.0-SNAPSHOT~08d4d6a17b
dateFormat X
axisFormat %s
section baseline
no_agent (19.35 ms) : 19148, 19552
. : milestone, 19350,
appsec (18.822 ms) : 18633, 19011
. : milestone, 18822,
code_origins (17.748 ms) : 17574, 17923
. : milestone, 17748,
iast (17.643 ms) : 17466, 17819
. : milestone, 17643,
profiling (19.09 ms) : 18898, 19282
. : milestone, 19090,
tracing (17.689 ms) : 17515, 17863
. : milestone, 17689,
section candidate
no_agent (19.004 ms) : 18809, 19199
. : milestone, 19004,
appsec (18.728 ms) : 18534, 18922
. : milestone, 18728,
code_origins (17.916 ms) : 17741, 18092
. : milestone, 17916,
iast (17.543 ms) : 17367, 17719
. : milestone, 17543,
profiling (19.843 ms) : 19644, 20043
. : milestone, 19843,
tracing (18.925 ms) : 18733, 19118
. : milestone, 18925,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~4d4977aee7, baseline=1.61.0-SNAPSHOT~08d4d6a17b
dateFormat X
axisFormat %s
section baseline
no_agent (1.181 ms) : 1170, 1193
. : milestone, 1181,
iast (3.132 ms) : 3091, 3172
. : milestone, 3132,
iast_FULL (6.165 ms) : 6102, 6228
. : milestone, 6165,
iast_GLOBAL (3.598 ms) : 3546, 3649
. : milestone, 3598,
profiling (2.005 ms) : 1987, 2023
. : milestone, 2005,
tracing (1.862 ms) : 1846, 1878
. : milestone, 1862,
section candidate
no_agent (1.182 ms) : 1171, 1194
. : milestone, 1182,
iast (3.122 ms) : 3082, 3162
. : milestone, 3122,
iast_FULL (5.804 ms) : 5745, 5862
. : milestone, 5804,
iast_GLOBAL (3.617 ms) : 3550, 3684
. : milestone, 3617,
profiling (2.078 ms) : 2058, 2099
. : milestone, 2078,
tracing (1.828 ms) : 1813, 1844
. : milestone, 1828,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~4d4977aee7, baseline=1.61.0-SNAPSHOT~08d4d6a17b
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.835 ms) : 3613, 4056
. : milestone, 3835,
iast (2.257 ms) : 2188, 2327
. : milestone, 2257,
iast_GLOBAL (2.296 ms) : 2226, 2365
. : milestone, 2296,
profiling (2.092 ms) : 2036, 2149
. : milestone, 2092,
tracing (2.061 ms) : 2007, 2114
. : milestone, 2061,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.574 ms) : 2516, 2632
. : milestone, 2574,
iast (2.257 ms) : 2188, 2327
. : milestone, 2257,
iast_GLOBAL (2.305 ms) : 2235, 2376
. : milestone, 2305,
profiling (2.082 ms) : 2027, 2137
. : milestone, 2082,
tracing (2.074 ms) : 2020, 2128
. : milestone, 2074,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~4d4977aee7, baseline=1.61.0-SNAPSHOT~08d4d6a17b
dateFormat X
axisFormat %s
section baseline
no_agent (15.569 s) : 15569000, 15569000
. : milestone, 15569000,
appsec (15.029 s) : 15029000, 15029000
. : milestone, 15029000,
iast (18.094 s) : 18094000, 18094000
. : milestone, 18094000,
iast_GLOBAL (17.782 s) : 17782000, 17782000
. : milestone, 17782000,
profiling (14.778 s) : 14778000, 14778000
. : milestone, 14778000,
tracing (15.051 s) : 15051000, 15051000
. : milestone, 15051000,
section candidate
no_agent (15.018 s) : 15018000, 15018000
. : milestone, 15018000,
appsec (15.043 s) : 15043000, 15043000
. : milestone, 15043000,
iast (18.132 s) : 18132000, 18132000
. : milestone, 18132000,
iast_GLOBAL (17.776 s) : 17776000, 17776000
. : milestone, 17776000,
profiling (14.597 s) : 14597000, 14597000
. : milestone, 14597000,
tracing (15.216 s) : 15216000, 15216000
. : milestone, 15216000,
|
Contributor
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
sarahchen6force-pushed
the
sarahchen6/g2j-dd-trace-api-migration-pt-1
branch
from
March 6, 2026 20:51
d509566 to
4d4977aComparesarahchen6
commented
Mar 9, 2026
ContributorAuthor
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 101294031 took longer than expected. The current limit for the base branch 'master' is 120 minutes. Possible reasons:
|
sarahchen6
commented
Mar 9, 2026
ContributorAuthor
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 101386827 took longer than expected. The current limit for the base branch 'master' is 120 minutes. Possible reasons:
|
sarahchen6
commented
Mar 9, 2026
ContributorAuthor
At least one problem with the merge queue right now is that muzzle tests are failing :( |
sarahchen6
commented
Mar 10, 2026
ContributorAuthor
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-mergequeue-cf854dBot
merged commit Mar 10, 2026
97429bd
into
master
574 of 576 checks passed
Uh oh!
There was an error while loading. Please reload this page.
gh-worker-dd-mergequeue-cf854dBot
deleted the
sarahchen6/g2j-dd-trace-api-migration-pt-1
branch
March 10, 2026 18:42
bric3
reviewed
Mar 11, 2026
| assertEquals("SecureRandom init exception", error.getCause().getMessage()); | ||
| } | ||
| @org.junit.jupiter.api.Test |
Comment on lines
+22
to
+30
| value = { | ||
| "false|RANDOM", | ||
| "false|SEQUENTIAL", | ||
| "false|SECURE_RANDOM", | ||
| "true|RANDOM", | ||
| "true|SEQUENTIAL", | ||
| "true|SECURE_RANDOM" | ||
| }, | ||
| delimiter = '|') |
Contributor
There was a problem hiding this comment.
polish: I think you could skip having to define the delimiter if using a comma instead.
Comment on lines
+39
to
+43
| assertNotNull(traceId); | ||
| assertFalse(traceId.equals(null)); | ||
| assertFalse(traceId.equals("foo")); | ||
| assertNotEquals(DDTraceId.ZERO, traceId); | ||
| assertTrue(traceId.equals(traceId)); |
Contributor
There was a problem hiding this comment.
todo: THere's maybe something to tweak in the skill, here the asserts looks wrong, assertEquals / assertNotEquals should have been used rather that assertFalse(a.equals(b)).
sarahchen6
commented
Mar 11, 2026
ContributorAuthor
Thanks @bric3 ! I will include these in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Migrate
dd-trace-apimodule from Groovy to Java, using the /migrate-groovy-to-java Claude skill. This is part 1 with three file changes to make the PRs easier to review.Motivation
This is part of a broader initiative to migrate all testing in this repo to JUnit.
Additional Notes
We can see in the Gitlab tests tab (e.g. for test_base: [8, 4/4]) that the migrated Java tests ran successfully. The migration was done with Claude Sonnet 4.6, and I reviewed the code after with some minor clean up to remove an unnecessary comment.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note:Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.