Skip to content

Add logging utility module - #10879

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
masterfrom
bbujon/http-api-step
Mar 19, 2026
Merged

Add logging utility module#10879
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
masterfrom
bbujon/http-api-step

Conversation

@PerfectSlayer

Copy link
Copy Markdown
Collaborator

What Does This Do

This PR introduces an :logging-utils module for RatelimitedLogger and IOLogger.
Additionally, Spock tests were migrated to JUnit.

Motivation

The goal is to move them away from the :internal-api module so they can be reused in various components without having to rely on the global internal APIs.

Additional Notes

The PR is split in 3 PR:

  • the 1st one creates the module (move of the existing code)
  • the 2nd one migrate the tests (dedicated commit to ease the review)
  • the 3rd one is the refactoring to use the new module instead of the class from internal API (again, to ease the review due to the multiple package updates needed)

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note:Once your PR is ready to merge, add it to the merge queue by commenting /merge./merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@PerfectSlayerPerfectSlayer added tag: no release notes Changes to exclude from release notes type: refactoring comp: platform Platform labels Mar 17, 2026
@pr-commenter

pr-commenterBot commented Mar 17, 2026

Copy link
Copy Markdown

Debugger benchmarks

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
ci_job_date17739085041773908850
end_time2026-03-19T08:23:052026-03-19T08:28:51
git_branchmasterbbujon/http-api-step
git_commit_shac51637a8eda1df
start_time2026-03-19T08:21:452026-03-19T08:27:31
See matching parameters
BaselineCandidate
ci_job_id15203733461520373346
ci_pipeline_id103432928103432928
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date17739079281773907928

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenarioΔ mean agg_http_req_duration_minΔ mean agg_http_req_duration_p50Δ mean agg_http_req_duration_p75Δ mean agg_http_req_duration_p99Δ mean throughput
scenario:noprobeunstable
[-37.685µs; +21.760µs] or [-13.332%; +7.698%]
unstable
[-52.643µs; +29.948µs] or [-16.070%; +9.142%]
unstable
[-65.306µs; +40.594µs] or [-18.989%; +11.803%]
unstable
[-78.781µs; +169.820µs] or [-8.315%; +17.925%]
same
scenario:basicsamesamesameunstable
[+37.218µs; +212.557µs] or [+5.480%; +31.299%]
unstable
[-97.923op/s; +240.171op/s] or [-3.721%; +9.126%]
scenario:loopsamesamesamesamesame
Request duration reports for reports
gantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (327.579 µs) : 278, 377
. : milestone, 328,
basic (277.23 µs) : 270, 284
. : milestone, 277,
loop (8.959 ms) : 8953, 8964
. : milestone, 8959,
section candidate
noprobe (316.231 µs) : 291, 341
. : milestone, 316,
basic (278.654 µs) : 272, 286
. : milestone, 279,
loop (8.958 ms) : 8954, 8962
. : milestone, 8958,
Loading
  • baseline results
ScenarioRequest median duration [CI 0.99]
noprobe327.579 µs [277.834 µs, 377.323 µs]
basic277.23 µs [270.123 µs, 284.336 µs]
loop8.959 ms [8.953 ms, 8.964 ms]
  • candidate results
ScenarioRequest median duration [CI 0.99]
noprobe316.231 µs [291.403 µs, 341.058 µs]
basic278.654 µs [271.635 µs, 285.673 µs]
loop8.958 ms [8.954 ms, 8.962 ms]

@pr-commenter

pr-commenterBot commented Mar 17, 2026

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmasterbbujon/http-api-step
git_commit_date17744486231774454804
git_commit_shafd087775829d3b
release_version1.61.0-SNAPSHOT~fd087771cb1.61.0-SNAPSHOT~5829d3b3a2
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17744565241774456524
ci_job_id15380794101538079410
ci_pipeline_id104366806104366806
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-zfyrx7zua-project-304-concurrent-3-14n89vuh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-zfyrx7zua-project-304-concurrent-3-14n89vuh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
moduleAgentAgent
parentNoneNone

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics.

Startup time reports for insecure-bank
gantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~5829d3b3a2, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062500
Total [baseline] (8.904 s) : 0, 8904089
Agent [candidate] (1.06 s) : 0, 1059924
Total [candidate] (8.824 s) : 0, 8823946
section iast
Agent [baseline] (1.233 s) : 0, 1232906
Total [baseline] (9.534 s) : 0, 9534419
Agent [candidate] (1.23 s) : 0, 1230292
Total [candidate] (9.547 s) : 0, 9546936
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing1.062 s-
Agentiast1.233 s170.406 ms (16.0%)
Totaltracing8.904 s-
Totaliast9.534 s630.33 ms (7.1%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing1.06 s-
Agentiast1.23 s170.368 ms (16.1%)
Totaltracing8.824 s-
Totaliast9.547 s722.991 ms (8.2%)
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~5829d3b3a2, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (632.572 ms) : 0, 632572
BytebuddyAgent [candidate] (631.245 ms) : 0, 631245
AgentMeter [baseline] (29.605 ms) : 0, 29605
AgentMeter [candidate] (29.519 ms) : 0, 29519
GlobalTracer [baseline] (258.364 ms) : 0, 258364
GlobalTracer [candidate] (257.718 ms) : 0, 257718
AppSec [baseline] (31.972 ms) : 0, 31972
AppSec [candidate] (31.714 ms) : 0, 31714
Debugger [baseline] (59.844 ms) : 0, 59844
Debugger [candidate] (59.58 ms) : 0, 59580
Remote Config [baseline] (580.15 µs) : 0, 580
Remote Config [candidate] (586.609 µs) : 0, 587
Telemetry [baseline] (7.993 ms) : 0, 7993
Telemetry [candidate] (8.062 ms) : 0, 8062
Flare Poller [baseline] (4.225 ms) : 0, 4225
Flare Poller [candidate] (4.247 ms) : 0, 4247
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (799.487 ms) : 0, 799487
BytebuddyAgent [candidate] (798.454 ms) : 0, 798454
AgentMeter [baseline] (11.47 ms) : 0, 11470
AgentMeter [candidate] (11.389 ms) : 0, 11389
GlobalTracer [baseline] (248.825 ms) : 0, 248825
GlobalTracer [candidate] (248.401 ms) : 0, 248401
AppSec [baseline] (26.698 ms) : 0, 26698
AppSec [candidate] (26.566 ms) : 0, 26566
Debugger [baseline] (68.967 ms) : 0, 68967
Debugger [candidate] (67.856 ms) : 0, 67856
Remote Config [baseline] (527.209 µs) : 0, 527
Remote Config [candidate] (524.513 µs) : 0, 525
Telemetry [baseline] (10.418 ms) : 0, 10418
Telemetry [candidate] (10.707 ms) : 0, 10707
Flare Poller [baseline] (3.561 ms) : 0, 3561
Flare Poller [candidate] (3.812 ms) : 0, 3812
IAST [baseline] (25.573 ms) : 0, 25573
IAST [candidate] (25.364 ms) : 0, 25364
Loading
Startup time reports for petclinic
gantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~5829d3b3a2, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061474
Total [baseline] (11.156 s) : 0, 11156284
Agent [candidate] (1.059 s) : 0, 1058648
Total [candidate] (11.131 s) : 0, 11130843
section appsec
Agent [baseline] (1.247 s) : 0, 1246678
Total [baseline] (11.175 s) : 0, 11175108
Agent [candidate] (1.249 s) : 0, 1249194
Total [candidate] (11.189 s) : 0, 11188649
section iast
Agent [baseline] (1.23 s) : 0, 1229968
Total [baseline] (11.292 s) : 0, 11292297
Agent [candidate] (1.228 s) : 0, 1227881
Total [candidate] (11.225 s) : 0, 11225095
section profiling
Agent [baseline] (1.183 s) : 0, 1183343
Total [baseline] (11.127 s) : 0, 11127058
Agent [candidate] (1.18 s) : 0, 1180344
Total [candidate] (10.965 s) : 0, 10964694
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing1.061 s-
Agentappsec1.247 s185.204 ms (17.4%)
Agentiast1.23 s168.494 ms (15.9%)
Agentprofiling1.183 s121.869 ms (11.5%)
Totaltracing11.156 s-
Totalappsec11.175 s18.824 ms (0.2%)
Totaliast11.292 s136.013 ms (1.2%)
Totalprofiling11.127 s-29.226 ms (-0.3%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing1.059 s-
Agentappsec1.249 s190.546 ms (18.0%)
Agentiast1.228 s169.234 ms (16.0%)
Agentprofiling1.18 s121.697 ms (11.5%)
Totaltracing11.131 s-
Totalappsec11.189 s57.806 ms (0.5%)
Totaliast11.225 s94.252 ms (0.8%)
Totalprofiling10.965 s-166.149 ms (-1.5%)
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~5829d3b3a2, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (630.546 ms) : 0, 630546
BytebuddyAgent [candidate] (630.122 ms) : 0, 630122
AgentMeter [baseline] (29.387 ms) : 0, 29387
AgentMeter [candidate] (29.375 ms) : 0, 29375
GlobalTracer [baseline] (257.569 ms) : 0, 257569
GlobalTracer [candidate] (257.259 ms) : 0, 257259
AppSec [baseline] (31.748 ms) : 0, 31748
AppSec [candidate] (31.72 ms) : 0, 31720
Debugger [baseline] (60.601 ms) : 0, 60601
Debugger [candidate] (60.207 ms) : 0, 60207
Remote Config [baseline] (607.81 µs) : 0, 608
Remote Config [candidate] (583.891 µs) : 0, 584
Telemetry [baseline] (8.835 ms) : 0, 8835
Telemetry [candidate] (8.696 ms) : 0, 8696
Flare Poller [baseline] (4.952 ms) : 0, 4952
Flare Poller [candidate] (3.495 ms) : 0, 3495
section appsec
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (658.293 ms) : 0, 658293
BytebuddyAgent [candidate] (659.925 ms) : 0, 659925
AgentMeter [baseline] (12.103 ms) : 0, 12103
AgentMeter [candidate] (12.119 ms) : 0, 12119
GlobalTracer [baseline] (258.32 ms) : 0, 258320
GlobalTracer [candidate] (258.78 ms) : 0, 258780
IAST [baseline] (24.136 ms) : 0, 24136
IAST [candidate] (24.232 ms) : 0, 24232
AppSec [baseline] (177.237 ms) : 0, 177237
AppSec [candidate] (177.79 ms) : 0, 177790
Debugger [baseline] (66.532 ms) : 0, 66532
Debugger [candidate] (66.311 ms) : 0, 66311
Remote Config [baseline] (644.678 µs) : 0, 645
Remote Config [candidate] (626.64 µs) : 0, 627
Telemetry [baseline] (8.339 ms) : 0, 8339
Telemetry [candidate] (8.461 ms) : 0, 8461
Flare Poller [baseline] (3.581 ms) : 0, 3581
Flare Poller [candidate] (3.603 ms) : 0, 3603
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (797.317 ms) : 0, 797317
BytebuddyAgent [candidate] (795.97 ms) : 0, 795970
AgentMeter [baseline] (11.397 ms) : 0, 11397
AgentMeter [candidate] (11.385 ms) : 0, 11385
GlobalTracer [baseline] (247.819 ms) : 0, 247819
GlobalTracer [candidate] (247.56 ms) : 0, 247560
IAST [baseline] (25.314 ms) : 0, 25314
IAST [candidate] (25.383 ms) : 0, 25383
AppSec [baseline] (26.58 ms) : 0, 26580
AppSec [candidate] (26.571 ms) : 0, 26571
Debugger [baseline] (70.494 ms) : 0, 70494
Debugger [candidate] (70.749 ms) : 0, 70749
Remote Config [baseline] (532.525 µs) : 0, 533
Remote Config [candidate] (530.825 µs) : 0, 531
Telemetry [baseline] (9.696 ms) : 0, 9696
Telemetry [candidate] (9.136 ms) : 0, 9136
Flare Poller [baseline] (3.471 ms) : 0, 3471
Flare Poller [candidate] (3.338 ms) : 0, 3338
section profiling
crashtracking [baseline] (1.166 ms) : 0, 1166
crashtracking [candidate] (1.163 ms) : 0, 1163
BytebuddyAgent [baseline] (682.922 ms) : 0, 682922
BytebuddyAgent [candidate] (682.071 ms) : 0, 682071
AgentMeter [baseline] (9.036 ms) : 0, 9036
AgentMeter [candidate] (8.972 ms) : 0, 8972
GlobalTracer [baseline] (215.278 ms) : 0, 215278
GlobalTracer [candidate] (214.576 ms) : 0, 214576
AppSec [baseline] (32.153 ms) : 0, 32153
AppSec [candidate] (32.043 ms) : 0, 32043
Debugger [baseline] (65.767 ms) : 0, 65767
Debugger [candidate] (64.974 ms) : 0, 64974
Remote Config [baseline] (556.739 µs) : 0, 557
Remote Config [candidate] (570.542 µs) : 0, 571
Telemetry [baseline] (7.712 ms) : 0, 7712
Telemetry [candidate] (8.451 ms) : 0, 8451
Flare Poller [baseline] (3.438 ms) : 0, 3438
Flare Poller [candidate] (3.456 ms) : 0, 3456
ProfilingAgent [baseline] (94.366 ms) : 0, 94366
ProfilingAgent [candidate] (93.363 ms) : 0, 93363
Profiling [baseline] (94.934 ms) : 0, 94934
Profiling [candidate] (93.915 ms) : 0, 93915
Loading

Load

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmasterbbujon/http-api-step
git_commit_date17744486231774454804
git_commit_shafd087775829d3b
release_version1.61.0-SNAPSHOT~fd087771cb1.61.0-SNAPSHOT~5829d3b3a2
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17744570471774457047
ci_job_id15380794181538079418
ci_pipeline_id104366806104366806
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-zfyrx7zua-project-304-concurrent-1-7suxkja1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-zfyrx7zua-project-304-concurrent-1-7suxkja1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.

scenarioΔ mean agg_http_req_duration_p50Δ mean agg_http_req_duration_p95Δ mean throughputcandidate mean agg_http_req_duration_p50candidate mean agg_http_req_duration_p95candidate mean throughputbaseline mean agg_http_req_duration_p50baseline mean agg_http_req_duration_p95baseline mean throughput
scenario:load:insecure-bank:iast:high_loadbetter
[-250.669µs; -99.686µs] or [-9.595%; -3.816%]
unsure
[-544.126µs; -67.046µs] or [-7.226%; -0.890%]
unstable
[-103.932op/s; +210.244op/s] or [-7.505%; +15.182%]
2.437ms7.224ms1437.938op/s2.613ms7.530ms1384.781op/s
scenario:load:petclinic:no_agent:high_loadbetter
[-2.237ms; -0.718ms] or [-11.778%; -3.783%]
unstable
[-3.968ms; -0.718ms] or [-12.523%; -2.266%]
unstable
[-8.912op/s; +48.725op/s] or [-3.739%; +20.443%]
17.514ms29.341ms258.250op/s18.992ms31.684ms238.344op/s
scenario:load:petclinic:code_origins:high_loadworse
[+550.413µs; +1365.887µs] or [+3.174%; +7.875%]
unsure
[+0.350ms; +1.678ms] or [+1.238%; +5.930%]
unstable
[-39.989op/s; +16.364op/s] or [-15.203%; +6.221%]
18.302ms29.316ms251.219op/s17.344ms28.302ms263.031op/s
Request duration reports for insecure-bank
gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~5829d3b3a2, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section baseline
no_agent (1.168 ms) : 1156, 1179
. : milestone, 1168,
iast (3.305 ms) : 3267, 3344
. : milestone, 3305,
iast_FULL (6.035 ms) : 5974, 6096
. : milestone, 6035,
iast_GLOBAL (3.5 ms) : 3441, 3559
. : milestone, 3500,
profiling (2.106 ms) : 2086, 2127
. : milestone, 2106,
tracing (1.772 ms) : 1759, 1786
. : milestone, 1772,
section candidate
no_agent (1.182 ms) : 1170, 1193
. : milestone, 1182,
iast (3.18 ms) : 3132, 3229
. : milestone, 3180,
iast_FULL (6.004 ms) : 5944, 6064
. : milestone, 6004,
iast_GLOBAL (3.476 ms) : 3422, 3531
. : milestone, 3476,
profiling (2.16 ms) : 2139, 2180
. : milestone, 2160,
tracing (1.843 ms) : 1826, 1859
. : milestone, 1843,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent1.168 ms [1.156 ms, 1.179 ms]-
iast3.305 ms [3.267 ms, 3.344 ms]2.138 ms (183.1%)
iast_FULL6.035 ms [5.974 ms, 6.096 ms]4.867 ms (416.8%)
iast_GLOBAL3.5 ms [3.441 ms, 3.559 ms]2.332 ms (199.8%)
profiling2.106 ms [2.086 ms, 2.127 ms]938.79 µs (80.4%)
tracing1.772 ms [1.759 ms, 1.786 ms]604.818 µs (51.8%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent1.182 ms [1.17 ms, 1.193 ms]-
iast3.18 ms [3.132 ms, 3.229 ms]1.999 ms (169.2%)
iast_FULL6.004 ms [5.944 ms, 6.064 ms]4.822 ms (408.2%)
iast_GLOBAL3.476 ms [3.422 ms, 3.531 ms]2.295 ms (194.2%)
profiling2.16 ms [2.139 ms, 2.18 ms]978.032 µs (82.8%)
tracing1.843 ms [1.826 ms, 1.859 ms]661.071 µs (56.0%)
Request duration reports for petclinic
gantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~5829d3b3a2, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section baseline
no_agent (19.586 ms) : 19380, 19792
. : milestone, 19586,
appsec (18.644 ms) : 18452, 18836
. : milestone, 18644,
code_origins (17.734 ms) : 17561, 17907
. : milestone, 17734,
iast (17.98 ms) : 17801, 18158
. : milestone, 17980,
profiling (18.682 ms) : 18494, 18871
. : milestone, 18682,
tracing (17.655 ms) : 17480, 17831
. : milestone, 17655,
section candidate
no_agent (18.068 ms) : 17884, 18252
. : milestone, 18068,
appsec (18.529 ms) : 18343, 18715
. : milestone, 18529,
code_origins (18.585 ms) : 18398, 18772
. : milestone, 18585,
iast (17.721 ms) : 17547, 17895
. : milestone, 17721,
profiling (19.011 ms) : 18823, 19199
. : milestone, 19011,
tracing (17.755 ms) : 17584, 17927
. : milestone, 17755,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent19.586 ms [19.38 ms, 19.792 ms]-
appsec18.644 ms [18.452 ms, 18.836 ms]-942.125 µs (-4.8%)
code_origins17.734 ms [17.561 ms, 17.907 ms]-1.851 ms (-9.5%)
iast17.98 ms [17.801 ms, 18.158 ms]-1.606 ms (-8.2%)
profiling18.682 ms [18.494 ms, 18.871 ms]-903.659 µs (-4.6%)
tracing17.655 ms [17.48 ms, 17.831 ms]-1.931 ms (-9.9%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent18.068 ms [17.884 ms, 18.252 ms]-
appsec18.529 ms [18.343 ms, 18.715 ms]461.248 µs (2.6%)
code_origins18.585 ms [18.398 ms, 18.772 ms]517.435 µs (2.9%)
iast17.721 ms [17.547 ms, 17.895 ms]-346.867 µs (-1.9%)
profiling19.011 ms [18.823 ms, 19.199 ms]942.893 µs (5.2%)
tracing17.755 ms [17.584 ms, 17.927 ms]-312.441 µs (-1.7%)

Dacapo

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmasterbbujon/http-api-step
git_commit_date17744486231774454804
git_commit_shafd087775829d3b
release_version1.61.0-SNAPSHOT~fd087771cb1.61.0-SNAPSHOT~5829d3b3a2
See matching parameters
BaselineCandidate
applicationbiojavabiojava
ci_job_date17744568381774456838
ci_job_id15380794201538079420
ci_pipeline_id104366806104366806
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-zfyrx7zua-project-304-concurrent-1-sj8qef85 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-zfyrx7zua-project-304-concurrent-1-sj8qef85 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat
gantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~5829d3b3a2, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.843 ms) : 3621, 4065
. : milestone, 3843,
iast (2.263 ms) : 2194, 2333
. : milestone, 2263,
iast_GLOBAL (2.311 ms) : 2242, 2381
. : milestone, 2311,
profiling (2.114 ms) : 2058, 2171
. : milestone, 2114,
tracing (2.088 ms) : 2033, 2142
. : milestone, 2088,
section candidate
no_agent (1.477 ms) : 1465, 1489
. : milestone, 1477,
appsec (3.841 ms) : 3616, 4066
. : milestone, 3841,
iast (2.266 ms) : 2196, 2336
. : milestone, 2266,
iast_GLOBAL (2.311 ms) : 2241, 2381
. : milestone, 2311,
profiling (2.102 ms) : 2047, 2158
. : milestone, 2102,
tracing (2.074 ms) : 2021, 2128
. : milestone, 2074,
Loading
  • baseline results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent1.477 ms [1.465 ms, 1.488 ms]-
appsec3.843 ms [3.621 ms, 4.065 ms]2.366 ms (160.3%)
iast2.263 ms [2.194 ms, 2.333 ms]786.46 µs (53.3%)
iast_GLOBAL2.311 ms [2.242 ms, 2.381 ms]834.63 µs (56.5%)
profiling2.114 ms [2.058 ms, 2.171 ms]637.312 µs (43.2%)
tracing2.088 ms [2.033 ms, 2.142 ms]610.787 µs (41.4%)
  • candidate results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent1.477 ms [1.465 ms, 1.489 ms]-
appsec3.841 ms [3.616 ms, 4.066 ms]2.364 ms (160.1%)
iast2.266 ms [2.196 ms, 2.336 ms]788.865 µs (53.4%)
iast_GLOBAL2.311 ms [2.241 ms, 2.381 ms]834.096 µs (56.5%)
profiling2.102 ms [2.047 ms, 2.158 ms]625.315 µs (42.3%)
tracing2.074 ms [2.021 ms, 2.128 ms]597.127 µs (40.4%)
Execution time for biojava
gantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~5829d3b3a2, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section baseline
no_agent (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
appsec (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
iast (18.134 s) : 18134000, 18134000
. : milestone, 18134000,
iast_GLOBAL (17.87 s) : 17870000, 17870000
. : milestone, 17870000,
profiling (14.8 s) : 14800000, 14800000
. : milestone, 14800000,
tracing (14.86 s) : 14860000, 14860000
. : milestone, 14860000,
section candidate
no_agent (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
appsec (14.798 s) : 14798000, 14798000
. : milestone, 14798000,
iast (18.012 s) : 18012000, 18012000
. : milestone, 18012000,
iast_GLOBAL (18.176 s) : 18176000, 18176000
. : milestone, 18176000,
profiling (15.186 s) : 15186000, 15186000
. : milestone, 15186000,
tracing (14.728 s) : 14728000, 14728000
. : milestone, 14728000,
Loading
  • baseline results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent14.949 s [14.949 s, 14.949 s]-
appsec14.881 s [14.881 s, 14.881 s]-68.0 ms (-0.5%)
iast18.134 s [18.134 s, 18.134 s]3.185 s (21.3%)
iast_GLOBAL17.87 s [17.87 s, 17.87 s]2.921 s (19.5%)
profiling14.8 s [14.8 s, 14.8 s]-149.0 ms (-1.0%)
tracing14.86 s [14.86 s, 14.86 s]-89.0 ms (-0.6%)
  • candidate results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent15.038 s [15.038 s, 15.038 s]-
appsec14.798 s [14.798 s, 14.798 s]-240.0 ms (-1.6%)
iast18.012 s [18.012 s, 18.012 s]2.974 s (19.8%)
iast_GLOBAL18.176 s [18.176 s, 18.176 s]3.138 s (20.9%)
profiling15.186 s [15.186 s, 15.186 s]148.0 ms (1.0%)
tracing14.728 s [14.728 s, 14.728 s]-310.0 ms (-2.1%)

@PerfectSlayer
PerfectSlayer marked this pull request as ready for review March 18, 2026 08:02
@PerfectSlayer
PerfectSlayer requested review from a team as code ownersMarch 18, 2026 08:02
@PerfectSlayer
PerfectSlayer requested review from AlexeyKuznetsov-DD, mcculls and tylfin and removed request for a teamMarch 18, 2026 08:02

@AlexeyKuznetsov-DDAlexeyKuznetsov-DD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

Comment threaddd-java-agent/agent-debugger/build.gradle Outdated
Comment threadutils/logging-utils/src/test/java/datadog/logging/IOLoggerTest.java Outdated
@mcculls

Copy link
Copy Markdown
Contributor

FYI looking at the final dd-java-agent jar, two copies of RatelimitedLogger and IOLogger are ending up in the jar:

 0 02-01-1980 00:00 shared/datadog/trace/agent/logging/
871 02-01-1980 00:00 shared/datadog/trace/agent/logging/IOLogger$Response.classdata
3292 02-01-1980 00:00 shared/datadog/trace/agent/logging/IOLogger.classdata
3096 02-01-1980 00:00 shared/datadog/trace/agent/logging/RatelimitedLogger.classdata
0 02-01-1980 00:00 datadog/trace/agent/logging/
871 02-01-1980 00:00 datadog/trace/agent/logging/IOLogger$Response.class
3292 02-01-1980 00:00 datadog/trace/agent/logging/IOLogger.class
3096 02-01-1980 00:00 datadog/trace/agent/logging/RatelimitedLogger.class

@mcculls

Copy link
Copy Markdown
Contributor

@PerfectSlayer adding this patch should fix the duplicate content:

diff --git a/dd-java-agent/build.gradle b/dd-java-agent/build.gradle
index d081d1330c..a34b233cea 100644
--- a/dd-java-agent/build.gradle
+++ b/dd-java-agent/build.gradle
@@ -251,6 +251,7 @@ def sharedShadowJar = tasks.register('sharedShadowJar', ShadowJar) {
exclude(project(':internal-api'))
exclude(project(':components:context'))
exclude(project(':utils:config-utils'))
+ exclude(project(':utils:logging-utils'))
exclude(project(':utils:time-utils'))
exclude(project(':products:metrics:metrics-api'))
exclude(project(':products:metrics:metrics-agent'))

@PerfectSlayer

PerfectSlayer commented Mar 18, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Thanks for the fix!

FYI looking at the final dd-java-agent jar, two copies of RatelimitedLogger and IOLogger are ending up in the jar:

Don't we have a gradle task for this case? Should it have been capture by CI?

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

FYI looking at the final dd-java-agent jar, two copies of RatelimitedLogger and IOLogger are ending up in the jar:

Don't we have a gradle task for this case? Should it have been capture by CI?

I recall we should have something like:

> Task :dd-java-agent:generateAgentJarIndex
[main] WARN datadog.trace.bootstrap.AgentJarIndex - Detected duplicate content 'dd-trace-core.version' under 'appsec', already seen in trace. Ensure your content is under a distinct directory.
.....

Or it is something different?
I like the idea to capture that on CI 👍

@PerfectSlayer

Copy link
Copy Markdown
CollaboratorAuthor

Yeah, it remembers it too now.
I wonder too if it would be useful on CI or if it will flake 🤔 (but I can see why there should be other cases when we would allow it). Nonetheless, it's still useful to not break the build by default as you may want duplication when experimenting with refactoring.

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

Yeah, it remembers it too now. I wonder too if it would be useful on CI or if it will flake 🤔 (but I can see why there should be other cases when we would allow it). Nonetheless, it's still useful to not break the build by default as you may want duplication when experimenting with refactoring.

We can show warnings on PRs and fail in Merge Queue?

@PerfectSlayer

Copy link
Copy Markdown
CollaboratorAuthor

We can show warnings on PRs and fail in Merge Queue?

We already run different tasks on PR check vs MQ. So we can have a proper task that would fail we trigger on MQ pipelines only.

@PerfectSlayer

Copy link
Copy Markdown
CollaboratorAuthor

adding this patch should fix the duplicate content:

Thanks! Fixed duplicated classes in 77d7a40395289c0474885dc84aad4a783811fe80

@PerfectSlayer

Copy link
Copy Markdown
CollaboratorAuthor

Rebasing to include #10780

@PerfectSlayer

Copy link
Copy Markdown
CollaboratorAuthor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Mar 19, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-03-19 08:13:41 UTC ℹ️ Start processing command /merge


2026-03-19 08:13:46 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-03-19 09:08:07 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 3h (p90).


2026-03-19 10:07:24 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit f452dff into masterMar 19, 2026
572 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the bbujon/http-api-step branch March 19, 2026 10:07
@github-actionsgithub-actionsBot added this to the 1.61.0 milestone Mar 19, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: platformPlatformtag: no release notesChanges to exclude from release notestype: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@PerfectSlayer@mcculls@AlexeyKuznetsov-DD@jpbempel