Uh oh!
There was an error while loading. Please reload this page.
Migrate OpenTelemetry instrumentation tests to JUnit - #11081
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~68ddac64f0, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1068377
Total [baseline] (8.871 s) : 0, 8870780
Agent [candidate] (1.062 s) : 0, 1062468
Total [candidate] (8.83 s) : 0, 8829567
section iast
Agent [baseline] (1.253 s) : 0, 1253103
Total [baseline] (9.518 s) : 0, 9517859
Agent [candidate] (1.241 s) : 0, 1241447
Total [candidate] (9.483 s) : 0, 9482609
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~68ddac64f0, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.242 ms) : 0, 1242
crashtracking [candidate] (1.235 ms) : 0, 1235
BytebuddyAgent [baseline] (639.796 ms) : 0, 639796
BytebuddyAgent [candidate] (634.771 ms) : 0, 634771
AgentMeter [baseline] (29.679 ms) : 0, 29679
AgentMeter [candidate] (29.378 ms) : 0, 29378
GlobalTracer [baseline] (249.945 ms) : 0, 249945
GlobalTracer [candidate] (249.045 ms) : 0, 249045
AppSec [baseline] (32.827 ms) : 0, 32827
AppSec [candidate] (32.845 ms) : 0, 32845
Debugger [baseline] (60.066 ms) : 0, 60066
Debugger [candidate] (59.68 ms) : 0, 59680
Remote Config [baseline] (611.121 µs) : 0, 611
Remote Config [candidate] (604.152 µs) : 0, 604
Telemetry [baseline] (9.14 ms) : 0, 9140
Telemetry [candidate] (9.154 ms) : 0, 9154
Flare Poller [baseline] (8.943 ms) : 0, 8943
Flare Poller [candidate] (9.794 ms) : 0, 9794
section iast
crashtracking [baseline] (1.232 ms) : 0, 1232
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (830.486 ms) : 0, 830486
BytebuddyAgent [candidate] (821.909 ms) : 0, 821909
AgentMeter [baseline] (11.377 ms) : 0, 11377
AgentMeter [candidate] (11.285 ms) : 0, 11285
GlobalTracer [baseline] (239.072 ms) : 0, 239072
GlobalTracer [candidate] (237.502 ms) : 0, 237502
IAST [baseline] (27.534 ms) : 0, 27534
IAST [candidate] (27.393 ms) : 0, 27393
AppSec [baseline] (32.466 ms) : 0, 32466
AppSec [candidate] (31.418 ms) : 0, 31418
Debugger [baseline] (62.884 ms) : 0, 62884
Debugger [candidate] (62.924 ms) : 0, 62924
Remote Config [baseline] (541.503 µs) : 0, 542
Remote Config [candidate] (519.108 µs) : 0, 519
Telemetry [baseline] (7.892 ms) : 0, 7892
Telemetry [candidate] (7.936 ms) : 0, 7936
Flare Poller [baseline] (3.445 ms) : 0, 3445
Flare Poller [candidate] (3.378 ms) : 0, 3378
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~68ddac64f0, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062529
Total [baseline] (11.0 s) : 0, 11000498
Agent [candidate] (1.066 s) : 0, 1065961
Total [candidate] (11.059 s) : 0, 11058660
section appsec
Agent [baseline] (1.268 s) : 0, 1268225
Total [baseline] (11.029 s) : 0, 11029072
Agent [candidate] (1.27 s) : 0, 1270073
Total [candidate] (11.069 s) : 0, 11069366
section iast
Agent [baseline] (1.246 s) : 0, 1246209
Total [baseline] (11.306 s) : 0, 11306287
Agent [candidate] (1.245 s) : 0, 1244825
Total [candidate] (11.332 s) : 0, 11331800
section profiling
Agent [baseline] (1.192 s) : 0, 1191642
Total [baseline] (11.038 s) : 0, 11038114
Agent [candidate] (1.194 s) : 0, 1193758
Total [candidate] (11.028 s) : 0, 11027974
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~68ddac64f0, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.241 ms) : 0, 1241
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (634.916 ms) : 0, 634916
BytebuddyAgent [candidate] (636.13 ms) : 0, 636130
AgentMeter [baseline] (29.469 ms) : 0, 29469
AgentMeter [candidate] (29.476 ms) : 0, 29476
GlobalTracer [baseline] (248.604 ms) : 0, 248604
GlobalTracer [candidate] (249.132 ms) : 0, 249132
AppSec [baseline] (32.709 ms) : 0, 32709
AppSec [candidate] (32.934 ms) : 0, 32934
Debugger [baseline] (60.587 ms) : 0, 60587
Debugger [candidate] (60.8 ms) : 0, 60800
Remote Config [baseline] (599.701 µs) : 0, 600
Remote Config [candidate] (590.679 µs) : 0, 591
Telemetry [baseline] (8.397 ms) : 0, 8397
Telemetry [candidate] (9.997 ms) : 0, 9997
Flare Poller [baseline] (9.921 ms) : 0, 9921
Flare Poller [candidate] (9.748 ms) : 0, 9748
section appsec
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (675.776 ms) : 0, 675776
BytebuddyAgent [candidate] (677.522 ms) : 0, 677522
AgentMeter [baseline] (12.239 ms) : 0, 12239
AgentMeter [candidate] (12.248 ms) : 0, 12248
GlobalTracer [baseline] (249.806 ms) : 0, 249806
GlobalTracer [candidate] (250.205 ms) : 0, 250205
IAST [baseline] (24.669 ms) : 0, 24669
IAST [candidate] (24.648 ms) : 0, 24648
AppSec [baseline] (185.774 ms) : 0, 185774
AppSec [candidate] (185.72 ms) : 0, 185720
Debugger [baseline] (65.152 ms) : 0, 65152
Debugger [candidate] (65.267 ms) : 0, 65267
Remote Config [baseline] (582.793 µs) : 0, 583
Remote Config [candidate] (581.807 µs) : 0, 582
Telemetry [baseline] (7.827 ms) : 0, 7827
Telemetry [candidate] (7.911 ms) : 0, 7911
Flare Poller [baseline] (7.92 ms) : 0, 7920
Flare Poller [candidate] (6.277 ms) : 0, 6277
section iast
crashtracking [baseline] (1.234 ms) : 0, 1234
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (823.967 ms) : 0, 823967
BytebuddyAgent [candidate] (823.32 ms) : 0, 823320
AgentMeter [baseline] (11.295 ms) : 0, 11295
AgentMeter [candidate] (11.294 ms) : 0, 11294
GlobalTracer [baseline] (238.363 ms) : 0, 238363
GlobalTracer [candidate] (237.823 ms) : 0, 237823
IAST [baseline] (28.24 ms) : 0, 28240
IAST [candidate] (28.253 ms) : 0, 28253
AppSec [baseline] (30.77 ms) : 0, 30770
AppSec [candidate] (31.393 ms) : 0, 31393
Debugger [baseline] (64.167 ms) : 0, 64167
Debugger [candidate] (63.351 ms) : 0, 63351
Remote Config [baseline] (532.938 µs) : 0, 533
Remote Config [candidate] (524.757 µs) : 0, 525
Telemetry [baseline] (8.018 ms) : 0, 8018
Telemetry [candidate] (8.052 ms) : 0, 8052
Flare Poller [baseline] (3.483 ms) : 0, 3483
Flare Poller [candidate] (3.431 ms) : 0, 3431
section profiling
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (696.925 ms) : 0, 696925
BytebuddyAgent [candidate] (697.091 ms) : 0, 697091
AgentMeter [baseline] (8.895 ms) : 0, 8895
AgentMeter [candidate] (8.939 ms) : 0, 8939
GlobalTracer [baseline] (207.795 ms) : 0, 207795
GlobalTracer [candidate] (209.239 ms) : 0, 209239
AppSec [baseline] (32.615 ms) : 0, 32615
AppSec [candidate] (32.953 ms) : 0, 32953
Debugger [baseline] (65.872 ms) : 0, 65872
Debugger [candidate] (66.099 ms) : 0, 66099
Remote Config [baseline] (593.049 µs) : 0, 593
Remote Config [candidate] (571.256 µs) : 0, 571
Telemetry [baseline] (8.117 ms) : 0, 8117
Telemetry [candidate] (8.073 ms) : 0, 8073
Flare Poller [baseline] (3.568 ms) : 0, 3568
Flare Poller [candidate] (3.567 ms) : 0, 3567
ProfilingAgent [baseline] (94.182 ms) : 0, 94182
ProfilingAgent [candidate] (94.133 ms) : 0, 94133
Profiling [baseline] (94.748 ms) : 0, 94748
Profiling [candidate] (94.684 ms) : 0, 94684
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~68ddac64f0, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section baseline
no_agent (1.25 ms) : 1238, 1262
. : milestone, 1250,
iast (3.32 ms) : 3275, 3365
. : milestone, 3320,
iast_FULL (5.893 ms) : 5834, 5952
. : milestone, 5893,
iast_GLOBAL (3.653 ms) : 3592, 3714
. : milestone, 3653,
profiling (2.34 ms) : 2316, 2365
. : milestone, 2340,
tracing (1.905 ms) : 1889, 1921
. : milestone, 1905,
section candidate
no_agent (1.257 ms) : 1245, 1269
. : milestone, 1257,
iast (3.386 ms) : 3338, 3434
. : milestone, 3386,
iast_FULL (5.95 ms) : 5890, 6009
. : milestone, 5950,
iast_GLOBAL (3.597 ms) : 3538, 3656
. : milestone, 3597,
profiling (2.317 ms) : 2295, 2339
. : milestone, 2317,
tracing (1.975 ms) : 1958, 1992
. : milestone, 1975,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~68ddac64f0, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section baseline
no_agent (18.056 ms) : 17871, 18242
. : milestone, 18056,
appsec (18.531 ms) : 18344, 18718
. : milestone, 18531,
code_origins (17.931 ms) : 17752, 18110
. : milestone, 17931,
iast (17.872 ms) : 17695, 18048
. : milestone, 17872,
profiling (18.75 ms) : 18560, 18940
. : milestone, 18750,
tracing (17.823 ms) : 17646, 17999
. : milestone, 17823,
section candidate
no_agent (18.973 ms) : 18784, 19161
. : milestone, 18973,
appsec (18.421 ms) : 18234, 18607
. : milestone, 18421,
code_origins (17.852 ms) : 17677, 18027
. : milestone, 17852,
iast (18.17 ms) : 17987, 18354
. : milestone, 18170,
profiling (18.229 ms) : 18047, 18412
. : milestone, 18229,
tracing (17.665 ms) : 17492, 17839
. : milestone, 17665,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~68ddac64f0, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section baseline
no_agent (1.494 ms) : 1483, 1506
. : milestone, 1494,
appsec (3.846 ms) : 3622, 4069
. : milestone, 3846,
iast (2.282 ms) : 2212, 2352
. : milestone, 2282,
iast_GLOBAL (2.326 ms) : 2256, 2396
. : milestone, 2326,
profiling (2.119 ms) : 2064, 2174
. : milestone, 2119,
tracing (2.082 ms) : 2029, 2136
. : milestone, 2082,
section candidate
no_agent (1.493 ms) : 1481, 1505
. : milestone, 1493,
appsec (3.866 ms) : 3640, 4092
. : milestone, 3866,
iast (2.284 ms) : 2214, 2353
. : milestone, 2284,
iast_GLOBAL (2.33 ms) : 2260, 2400
. : milestone, 2330,
profiling (2.113 ms) : 2058, 2168
. : milestone, 2113,
tracing (2.086 ms) : 2033, 2139
. : milestone, 2086,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~68ddac64f0, baseline=1.62.0-SNAPSHOT~da5e7c3da7
dateFormat X
axisFormat %s
section baseline
no_agent (14.981 s) : 14981000, 14981000
. : milestone, 14981000,
appsec (14.424 s) : 14424000, 14424000
. : milestone, 14424000,
iast (18.614 s) : 18614000, 18614000
. : milestone, 18614000,
iast_GLOBAL (17.896 s) : 17896000, 17896000
. : milestone, 17896000,
profiling (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
tracing (14.93 s) : 14930000, 14930000
. : milestone, 14930000,
section candidate
no_agent (15.379 s) : 15379000, 15379000
. : milestone, 15379000,
appsec (14.453 s) : 14453000, 14453000
. : milestone, 14453000,
iast (18.453 s) : 18453000, 18453000
. : milestone, 18453000,
iast_GLOBAL (18.007 s) : 18007000, 18007000
. : milestone, 18007000,
profiling (14.9 s) : 14900000, 14900000
. : milestone, 14900000,
tracing (14.815 s) : 14815000, 14815000
. : milestone, 14815000,
|
PerfectSlayerforce-pushed
the
bbujon/groovy-to-java
branch
3 times, most recently
from
April 13, 2026 14:04
5cdf944 to
b087d2cCompare
This was referenced Apr 13, 2026
PerfectSlayerforce-pushed
the
bbujon/groovy-to-java-doc
branch
2 times, most recently
from
April 21, 2026 13:58
5e10aca to
240ac19ComparePerfectSlayerforce-pushed
the
bbujon/groovy-to-java
branch
2 times, most recently
from
April 27, 2026 09:41
fed1c97 to
77d0f4bComparePerfectSlayer
marked this pull request as ready for review
April 27, 2026 09:42
PerfectSlayer
requested review from
a team, amarziali and bric3
and removed request for
a team and bric3April 27, 2026 09:42
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:77d0f4b555
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assertTraces(trace(span().operationName("internal").resourceName("some-name"))); | ||
| DDSpan ddSpan = writer.firstTrace().get(0); | ||
| assertEquals(expectedTraceId(traceId), ddSpan.getTraceId().toString()); |
There was a problem hiding this comment.
When these parameterized cases use 128-bit trace IDs with non-zero high bits, comparing ddSpan.getTraceId().toString() only checks the low 64-bit decimal representation, so the assertion would still pass if the DD span dropped the high-order trace-id bits during extraction. The deleted Spock assertion compared DDTraceId values directly; compare the DDTraceId object or toHexString() here so the migrated test still verifies the full propagated trace ID.
Useful? React with 👍 / 👎.
CollaboratorAuthor
There was a problem hiding this comment.
You miss the point...
PerfectSlayerforce-pushed
the
bbujon/groovy-to-java
branch
from
April 27, 2026 11:24
77d0f4b to
a3f4a87ComparePerfectSlayerforce-pushed
the
bbujon/groovy-to-java
branch
from
April 27, 2026 11:26
a3f4a87 to
1d39bd8ComparePerfectSlayerforce-pushed
the
bbujon/groovy-to-java
branch
from
April 29, 2026 08:20
1d39bd8 to
68ddac6Compare| @@ -7,5 +7,6 @@ | |||
| buildSrc/call-site-instrumentation-plugin | |||
| components/json | |||
| dd-java-agent/instrumentation/opentelemetry/opentelemetry-1.4 | |||
Contributor
There was a problem hiding this comment.
is it to track the migration and then we wipe it out?
CollaboratorAuthor
There was a problem hiding this comment.
I made this changes 3w ago. We were not discussing the deletion of this file back then 😅
amarziali
approved these changes
May 4, 2026
PerfectSlayerforce-pushed
the
bbujon/groovy-to-java
branch
from
May 4, 2026 12:09
68ddac6 to
3f978bdComparePerfectSlayer
commented
May 4, 2026
CollaboratorAuthor
/merge |
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'master' is 120 minutes. |
PerfectSlayer
commented
May 4, 2026
CollaboratorAuthor
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'master' is 120 minutes. |
PerfectSlayerforce-pushed
the
bbujon/groovy-to-java
branch
from
May 5, 2026 07:00
3f978bd to
667d910ComparePerfectSlayer
commented
May 5, 2026
CollaboratorAuthor
/merge |
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This pull request migrates the OpenTelemetry instrumentation tests to the Java testing tools.
The tests are the same with few small changes:
I spent a good amount of time reviewing them manually (maybe more than it took me to write them in the first place).
Motivation
Demonstrate the new Java testing tools for instrumentations.
The tests also now run twice faster.
Before:
After:
Additional Notes
This PR is part of some bigger improvements in stacked PRs:
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [APML-1247]
Note:Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.