Uh oh!
There was an error while loading. Please reload this page.
Upgrade smoke test dependencies only if >=48h old - #11215
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intoMay 6, 2026
Merged
Upgrade smoke test dependencies only if >=48h old#11215gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
Conversation
sarahchen6
commented
Apr 27, 2026
ContributorAuthor
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:27b94b1c4c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~79b5b639d7, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065845
Total [baseline] (8.856 s) : 0, 8855998
Agent [candidate] (1.064 s) : 0, 1064149
Total [candidate] (8.822 s) : 0, 8821717
section iast
Agent [baseline] (1.245 s) : 0, 1244777
Total [baseline] (9.531 s) : 0, 9531294
Agent [candidate] (1.245 s) : 0, 1245347
Total [candidate] (9.518 s) : 0, 9518306
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~79b5b639d7, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (638.83 ms) : 0, 638830
BytebuddyAgent [candidate] (636.505 ms) : 0, 636505
AgentMeter [baseline] (29.243 ms) : 0, 29243
AgentMeter [candidate] (29.543 ms) : 0, 29543
GlobalTracer [baseline] (248.321 ms) : 0, 248321
GlobalTracer [candidate] (248.763 ms) : 0, 248763
AppSec [baseline] (32.9 ms) : 0, 32900
AppSec [candidate] (32.726 ms) : 0, 32726
Debugger [baseline] (59.847 ms) : 0, 59847
Debugger [candidate] (59.947 ms) : 0, 59947
Remote Config [baseline] (604.303 µs) : 0, 604
Remote Config [candidate] (609.881 µs) : 0, 610
Telemetry [baseline] (9.104 ms) : 0, 9104
Telemetry [candidate] (8.38 ms) : 0, 8380
Flare Poller [baseline] (9.808 ms) : 0, 9808
Flare Poller [candidate] (10.538 ms) : 0, 10538
section iast
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (825.181 ms) : 0, 825181
BytebuddyAgent [candidate] (824.692 ms) : 0, 824692
AgentMeter [baseline] (11.274 ms) : 0, 11274
AgentMeter [candidate] (11.328 ms) : 0, 11328
GlobalTracer [baseline] (237.062 ms) : 0, 237062
GlobalTracer [candidate] (237.752 ms) : 0, 237752
IAST [baseline] (27.493 ms) : 0, 27493
IAST [candidate] (26.686 ms) : 0, 26686
AppSec [baseline] (32.032 ms) : 0, 32032
AppSec [candidate] (31.568 ms) : 0, 31568
Debugger [baseline] (62.567 ms) : 0, 62567
Debugger [candidate] (64.086 ms) : 0, 64086
Remote Config [baseline] (529.703 µs) : 0, 530
Remote Config [candidate] (532.498 µs) : 0, 532
Telemetry [baseline] (7.957 ms) : 0, 7957
Telemetry [candidate] (8.001 ms) : 0, 8001
Flare Poller [baseline] (3.377 ms) : 0, 3377
Flare Poller [candidate] (3.429 ms) : 0, 3429
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~79b5b639d7, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1070980
Total [baseline] (11.006 s) : 0, 11005924
Agent [candidate] (1.065 s) : 0, 1064748
Total [candidate] (11.004 s) : 0, 11004405
section appsec
Agent [baseline] (1.266 s) : 0, 1266348
Total [baseline] (11.03 s) : 0, 11029841
Agent [candidate] (1.266 s) : 0, 1265957
Total [candidate] (10.99 s) : 0, 10989579
section iast
Agent [baseline] (1.266 s) : 0, 1266107
Total [baseline] (11.374 s) : 0, 11374199
Agent [candidate] (1.245 s) : 0, 1245341
Total [candidate] (11.219 s) : 0, 11219027
section profiling
Agent [baseline] (1.186 s) : 0, 1185846
Total [baseline] (10.926 s) : 0, 10925971
Agent [candidate] (1.187 s) : 0, 1187047
Total [candidate] (10.999 s) : 0, 10998945
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~79b5b639d7, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.233 ms) : 0, 1233
crashtracking [candidate] (1.246 ms) : 0, 1246
BytebuddyAgent [baseline] (640.388 ms) : 0, 640388
BytebuddyAgent [candidate] (635.103 ms) : 0, 635103
AgentMeter [baseline] (29.607 ms) : 0, 29607
AgentMeter [candidate] (29.532 ms) : 0, 29532
GlobalTracer [baseline] (250.148 ms) : 0, 250148
GlobalTracer [candidate] (249.033 ms) : 0, 249033
AppSec [baseline] (32.884 ms) : 0, 32884
AppSec [candidate] (32.877 ms) : 0, 32877
Debugger [baseline] (60.469 ms) : 0, 60469
Debugger [candidate] (60.615 ms) : 0, 60615
Remote Config [baseline] (592.546 µs) : 0, 593
Remote Config [candidate] (590.54 µs) : 0, 591
Telemetry [baseline] (8.317 ms) : 0, 8317
Telemetry [candidate] (9.883 ms) : 0, 9883
Flare Poller [baseline] (11.236 ms) : 0, 11236
Flare Poller [candidate] (9.927 ms) : 0, 9927
section appsec
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (676.184 ms) : 0, 676184
BytebuddyAgent [candidate] (675.465 ms) : 0, 675465
AgentMeter [baseline] (12.242 ms) : 0, 12242
AgentMeter [candidate] (12.272 ms) : 0, 12272
GlobalTracer [baseline] (249.732 ms) : 0, 249732
GlobalTracer [candidate] (249.645 ms) : 0, 249645
IAST [baseline] (24.731 ms) : 0, 24731
IAST [candidate] (24.626 ms) : 0, 24626
AppSec [baseline] (185.062 ms) : 0, 185062
AppSec [candidate] (185.312 ms) : 0, 185312
Debugger [baseline] (64.966 ms) : 0, 64966
Debugger [candidate] (64.967 ms) : 0, 64967
Remote Config [baseline] (559.587 µs) : 0, 560
Remote Config [candidate] (588.562 µs) : 0, 589
Telemetry [baseline] (7.838 ms) : 0, 7838
Telemetry [candidate] (7.822 ms) : 0, 7822
Flare Poller [baseline] (6.695 ms) : 0, 6695
Flare Poller [candidate] (6.842 ms) : 0, 6842
section iast
crashtracking [baseline] (1.242 ms) : 0, 1242
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (841.78 ms) : 0, 841780
BytebuddyAgent [candidate] (823.488 ms) : 0, 823488
AgentMeter [baseline] (11.59 ms) : 0, 11590
AgentMeter [candidate] (11.34 ms) : 0, 11340
GlobalTracer [baseline] (240.323 ms) : 0, 240323
GlobalTracer [candidate] (238.27 ms) : 0, 238270
IAST [baseline] (27.634 ms) : 0, 27634
IAST [candidate] (26.64 ms) : 0, 26640
AppSec [baseline] (31.488 ms) : 0, 31488
AppSec [candidate] (33.108 ms) : 0, 33108
Debugger [baseline] (63.634 ms) : 0, 63634
Debugger [candidate] (63.235 ms) : 0, 63235
Remote Config [baseline] (533.054 µs) : 0, 533
Remote Config [candidate] (533.43 µs) : 0, 533
Telemetry [baseline] (7.998 ms) : 0, 7998
Telemetry [candidate] (7.995 ms) : 0, 7995
Flare Poller [baseline] (3.409 ms) : 0, 3409
Flare Poller [candidate] (3.438 ms) : 0, 3438
section profiling
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (691.879 ms) : 0, 691879
BytebuddyAgent [candidate] (692.371 ms) : 0, 692371
AgentMeter [baseline] (8.884 ms) : 0, 8884
AgentMeter [candidate] (8.913 ms) : 0, 8913
GlobalTracer [baseline] (207.73 ms) : 0, 207730
GlobalTracer [candidate] (207.699 ms) : 0, 207699
AppSec [baseline] (32.734 ms) : 0, 32734
AppSec [candidate] (32.589 ms) : 0, 32589
Debugger [baseline] (65.78 ms) : 0, 65780
Debugger [candidate] (65.874 ms) : 0, 65874
Remote Config [baseline] (578.757 µs) : 0, 579
Remote Config [candidate] (580.859 µs) : 0, 581
Telemetry [baseline] (8.132 ms) : 0, 8132
Telemetry [candidate] (8.077 ms) : 0, 8077
Flare Poller [baseline] (3.538 ms) : 0, 3538
Flare Poller [candidate] (3.596 ms) : 0, 3596
ProfilingAgent [baseline] (94.057 ms) : 0, 94057
ProfilingAgent [candidate] (94.82 ms) : 0, 94820
Profiling [baseline] (94.608 ms) : 0, 94608
Profiling [candidate] (95.388 ms) : 0, 95388
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 14 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~79b5b639d7, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section baseline
no_agent (1.266 ms) : 1253, 1279
. : milestone, 1266,
iast (3.321 ms) : 3275, 3368
. : milestone, 3321,
iast_FULL (6.281 ms) : 6215, 6346
. : milestone, 6281,
iast_GLOBAL (3.76 ms) : 3698, 3823
. : milestone, 3760,
profiling (2.043 ms) : 2025, 2061
. : milestone, 2043,
tracing (1.903 ms) : 1887, 1920
. : milestone, 1903,
section candidate
no_agent (1.261 ms) : 1248, 1274
. : milestone, 1261,
iast (3.537 ms) : 3481, 3592
. : milestone, 3537,
iast_FULL (6.004 ms) : 5943, 6064
. : milestone, 6004,
iast_GLOBAL (3.72 ms) : 3660, 3781
. : milestone, 3720,
profiling (2.075 ms) : 2056, 2093
. : milestone, 2075,
tracing (1.881 ms) : 1865, 1896
. : milestone, 1881,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~79b5b639d7, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section baseline
no_agent (18.572 ms) : 18384, 18761
. : milestone, 18572,
appsec (18.572 ms) : 18386, 18759
. : milestone, 18572,
code_origins (17.599 ms) : 17425, 17774
. : milestone, 17599,
iast (17.805 ms) : 17629, 17981
. : milestone, 17805,
profiling (18.404 ms) : 18222, 18585
. : milestone, 18404,
tracing (18.092 ms) : 17915, 18270
. : milestone, 18092,
section candidate
no_agent (18.435 ms) : 18241, 18630
. : milestone, 18435,
appsec (19.9 ms) : 19700, 20101
. : milestone, 19900,
code_origins (17.938 ms) : 17761, 18115
. : milestone, 17938,
iast (17.772 ms) : 17595, 17950
. : milestone, 17772,
profiling (18.173 ms) : 17994, 18352
. : milestone, 18173,
tracing (17.657 ms) : 17483, 17831
. : milestone, 17657,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~79b5b639d7, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section baseline
no_agent (1.488 ms) : 1477, 1500
. : milestone, 1488,
appsec (3.785 ms) : 3567, 4002
. : milestone, 3785,
iast (2.276 ms) : 2206, 2345
. : milestone, 2276,
iast_GLOBAL (2.322 ms) : 2252, 2392
. : milestone, 2322,
profiling (2.097 ms) : 2043, 2152
. : milestone, 2097,
tracing (2.084 ms) : 2030, 2138
. : milestone, 2084,
section candidate
no_agent (1.487 ms) : 1476, 1499
. : milestone, 1487,
appsec (3.772 ms) : 3553, 3991
. : milestone, 3772,
iast (2.288 ms) : 2218, 2358
. : milestone, 2288,
iast_GLOBAL (2.329 ms) : 2259, 2399
. : milestone, 2329,
profiling (2.488 ms) : 2334, 2643
. : milestone, 2488,
tracing (2.08 ms) : 2026, 2133
. : milestone, 2080,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~79b5b639d7, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section baseline
no_agent (14.852 s) : 14852000, 14852000
. : milestone, 14852000,
appsec (14.769 s) : 14769000, 14769000
. : milestone, 14769000,
iast (18.596 s) : 18596000, 18596000
. : milestone, 18596000,
iast_GLOBAL (18.23 s) : 18230000, 18230000
. : milestone, 18230000,
profiling (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
tracing (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
section candidate
no_agent (15.548 s) : 15548000, 15548000
. : milestone, 15548000,
appsec (14.966 s) : 14966000, 14966000
. : milestone, 14966000,
iast (18.942 s) : 18942000, 18942000
. : milestone, 18942000,
iast_GLOBAL (17.855 s) : 17855000, 17855000
. : milestone, 17855000,
profiling (15.761 s) : 15761000, 15761000
. : milestone, 15761000,
tracing (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
|
sarahchen6
commented
Apr 27, 2026
ContributorAuthor
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:5318987f46
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sarahchen6
commented
Apr 27, 2026
ContributorAuthor
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:f7c85866ff
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
sarahchen6
marked this pull request as ready for review
April 27, 2026 21:54
sarahchen6
requested review from
AlexeyKuznetsov-DD
and removed request for
a teamApril 27, 2026 21:54
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:f598eb4a94
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
sarahchen6
commented
Apr 28, 2026
ContributorAuthor
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:028c711657
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
sarahchen6
marked this pull request as draft
April 28, 2026 20:15
sarahchen6force-pushed
the
sarahchen6/implement-48h-cooldown
branch
from
May 5, 2026 20:47
3657510 to
bf40999Comparesarahchen6
marked this pull request as ready for review
May 5, 2026 20:48
daniel-mohedano
approved these changes
May 6, 2026
daniel-mohedano
left a comment
Contributor
There was a problem hiding this comment.
Left a minor nitpick, but overall LGTM! 🚀
Uh oh!
There was an error while loading. Please reload this page.
sarahchen6
commented
May 6, 2026
ContributorAuthor
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'master' is 120 minutes. |
sarahchen6
commented
May 6, 2026
ContributorAuthor
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-mergequeue-cf854dBot
merged commit May 6, 2026
cbf0d8b
into
master
755 of 757 checks passed
Uh oh!
There was an error while loading. Please reload this page.
gh-worker-dd-mergequeue-cf854dBot
deleted the
sarahchen6/implement-48h-cooldown
branch
May 6, 2026 23:48
sarahchen6
commented
May 7, 2026
ContributorAuthor
Verified the new workflow works! Workflow run: https://github.com/DataDog/dd-trace-java/actions/runs/25497440423/job/74820855449 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Only upgrade smoke test dependencies if they are at least 48 hours old. This PR specifically addresses the “Update smoke test latest versions” workflow. The “Update Gradle dependencies” workflow will be addressed in a follow-up PR.
Motivation
Require a 48-hour cooldown on external dependencies to reduce the risk of zero-day vulnerabilities.
Additional Notes
This PR was largely written by AI with my guidance on requirements and testing, followed by my review and tweaks for readability.
I added python tests for the scripts, but the actual changes need to land on
masterbefore the workflow can be tested. This is because the workflow depends on an octo-sts token that is only scoped tomaster(see failed test run).Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [APMLP-1148](https://datadoghq.atlassian.net/browse/APMLP-1148)
Note:Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.