Uh oh!
There was an error while loading. Please reload this page.
Use ParentBasedAlwaysOnSampler by default when OTLP traces export is enabled - #11225
Conversation
…, plus related tests
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~d183f39a7c, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062517
Total [baseline] (8.854 s) : 0, 8853566
Agent [candidate] (1.078 s) : 0, 1077859
Total [candidate] (8.871 s) : 0, 8871438
section iast
Agent [baseline] (1.243 s) : 0, 1243074
Total [baseline] (9.528 s) : 0, 9528476
Agent [candidate] (1.245 s) : 0, 1245328
Total [candidate] (9.526 s) : 0, 9525614
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~d183f39a7c, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.235 ms) : 0, 1235
crashtracking [candidate] (1.238 ms) : 0, 1238
BytebuddyAgent [baseline] (634.198 ms) : 0, 634198
BytebuddyAgent [candidate] (644.758 ms) : 0, 644758
AgentMeter [baseline] (29.447 ms) : 0, 29447
AgentMeter [candidate] (29.87 ms) : 0, 29870
GlobalTracer [baseline] (248.437 ms) : 0, 248437
GlobalTracer [candidate] (252.053 ms) : 0, 252053
AppSec [baseline] (32.579 ms) : 0, 32579
AppSec [candidate] (33.187 ms) : 0, 33187
Debugger [baseline] (60.443 ms) : 0, 60443
Debugger [candidate] (60.675 ms) : 0, 60675
Remote Config [baseline] (601.586 µs) : 0, 602
Remote Config [candidate] (619.945 µs) : 0, 620
Telemetry [baseline] (8.36 ms) : 0, 8360
Telemetry [candidate] (10.109 ms) : 0, 10109
Flare Poller [baseline] (11.351 ms) : 0, 11351
Flare Poller [candidate] (9.13 ms) : 0, 9130
section iast
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (823.284 ms) : 0, 823284
BytebuddyAgent [candidate] (825.022 ms) : 0, 825022
AgentMeter [baseline] (11.312 ms) : 0, 11312
AgentMeter [candidate] (11.322 ms) : 0, 11322
GlobalTracer [baseline] (237.405 ms) : 0, 237405
GlobalTracer [candidate] (237.491 ms) : 0, 237491
IAST [baseline] (26.592 ms) : 0, 26592
IAST [candidate] (27.548 ms) : 0, 27548
AppSec [baseline] (33.137 ms) : 0, 33137
AppSec [candidate] (32.163 ms) : 0, 32163
Debugger [baseline] (62.427 ms) : 0, 62427
Debugger [candidate] (62.576 ms) : 0, 62576
Remote Config [baseline] (529.143 µs) : 0, 529
Remote Config [candidate] (520.787 µs) : 0, 521
Telemetry [baseline] (7.821 ms) : 0, 7821
Telemetry [candidate] (7.982 ms) : 0, 7982
Flare Poller [baseline] (3.375 ms) : 0, 3375
Flare Poller [candidate] (3.374 ms) : 0, 3374
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~d183f39a7c, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063655
Total [baseline] (11.058 s) : 0, 11058406
Agent [candidate] (1.067 s) : 0, 1066659
Total [candidate] (11.064 s) : 0, 11064093
section appsec
Agent [baseline] (1.27 s) : 0, 1269995
Total [baseline] (11.074 s) : 0, 11073823
Agent [candidate] (1.272 s) : 0, 1271798
Total [candidate] (11.085 s) : 0, 11085473
section iast
Agent [baseline] (1.243 s) : 0, 1243442
Total [baseline] (11.323 s) : 0, 11323284
Agent [candidate] (1.241 s) : 0, 1240984
Total [candidate] (11.267 s) : 0, 11266912
section profiling
Agent [baseline] (1.189 s) : 0, 1188770
Total [baseline] (11.004 s) : 0, 11003637
Agent [candidate] (1.189 s) : 0, 1188562
Total [candidate] (11.019 s) : 0, 11018878
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~d183f39a7c, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.234 ms) : 0, 1234
BytebuddyAgent [baseline] (635.358 ms) : 0, 635358
BytebuddyAgent [candidate] (636.145 ms) : 0, 636145
AgentMeter [baseline] (29.509 ms) : 0, 29509
AgentMeter [candidate] (29.586 ms) : 0, 29586
GlobalTracer [baseline] (248.886 ms) : 0, 248886
GlobalTracer [candidate] (249.845 ms) : 0, 249845
AppSec [baseline] (32.588 ms) : 0, 32588
AppSec [candidate] (33.099 ms) : 0, 33099
Debugger [baseline] (60.419 ms) : 0, 60419
Debugger [candidate] (61.057 ms) : 0, 61057
Remote Config [baseline] (588.955 µs) : 0, 589
Remote Config [candidate] (611.599 µs) : 0, 612
Telemetry [baseline] (9.914 ms) : 0, 9914
Telemetry [candidate] (9.252 ms) : 0, 9252
Flare Poller [baseline] (9.144 ms) : 0, 9144
Flare Poller [candidate] (9.853 ms) : 0, 9853
section appsec
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.225 ms) : 0, 1225
BytebuddyAgent [baseline] (676.549 ms) : 0, 676549
BytebuddyAgent [candidate] (678.519 ms) : 0, 678519
AgentMeter [baseline] (12.32 ms) : 0, 12320
AgentMeter [candidate] (12.384 ms) : 0, 12384
GlobalTracer [baseline] (250.774 ms) : 0, 250774
GlobalTracer [candidate] (250.772 ms) : 0, 250772
IAST [baseline] (24.87 ms) : 0, 24870
IAST [candidate] (24.832 ms) : 0, 24832
AppSec [baseline] (186.535 ms) : 0, 186535
AppSec [candidate] (185.753 ms) : 0, 185753
Debugger [baseline] (65.263 ms) : 0, 65263
Debugger [candidate] (65.085 ms) : 0, 65085
Remote Config [baseline] (576.687 µs) : 0, 577
Remote Config [candidate] (588.82 µs) : 0, 589
Telemetry [baseline] (7.851 ms) : 0, 7851
Telemetry [candidate] (7.961 ms) : 0, 7961
Flare Poller [baseline] (6.817 ms) : 0, 6817
Flare Poller [candidate] (8.029 ms) : 0, 8029
section iast
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (823.033 ms) : 0, 823033
BytebuddyAgent [candidate] (820.949 ms) : 0, 820949
AgentMeter [baseline] (11.268 ms) : 0, 11268
AgentMeter [candidate] (11.27 ms) : 0, 11270
GlobalTracer [baseline] (237.131 ms) : 0, 237131
GlobalTracer [candidate] (237.9 ms) : 0, 237900
IAST [baseline] (27.352 ms) : 0, 27352
IAST [candidate] (26.455 ms) : 0, 26455
AppSec [baseline] (31.487 ms) : 0, 31487
AppSec [candidate] (32.307 ms) : 0, 32307
Debugger [baseline] (64.024 ms) : 0, 64024
Debugger [candidate] (63.079 ms) : 0, 63079
Remote Config [baseline] (523.684 µs) : 0, 524
Remote Config [candidate] (521.345 µs) : 0, 521
Telemetry [baseline] (7.976 ms) : 0, 7976
Telemetry [candidate] (7.966 ms) : 0, 7966
Flare Poller [baseline] (3.407 ms) : 0, 3407
Flare Poller [candidate] (3.364 ms) : 0, 3364
section profiling
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (694.248 ms) : 0, 694248
BytebuddyAgent [candidate] (693.435 ms) : 0, 693435
AgentMeter [baseline] (8.928 ms) : 0, 8928
AgentMeter [candidate] (8.903 ms) : 0, 8903
GlobalTracer [baseline] (207.977 ms) : 0, 207977
GlobalTracer [candidate] (207.989 ms) : 0, 207989
AppSec [baseline] (32.76 ms) : 0, 32760
AppSec [candidate] (32.846 ms) : 0, 32846
Debugger [baseline] (65.83 ms) : 0, 65830
Debugger [candidate] (66.165 ms) : 0, 66165
Remote Config [baseline] (580.314 µs) : 0, 580
Remote Config [candidate] (573.962 µs) : 0, 574
Telemetry [baseline] (8.07 ms) : 0, 8070
Telemetry [candidate] (8.097 ms) : 0, 8097
Flare Poller [baseline] (3.538 ms) : 0, 3538
Flare Poller [candidate] (3.6 ms) : 0, 3600
ProfilingAgent [baseline] (94.154 ms) : 0, 94154
ProfilingAgent [candidate] (94.406 ms) : 0, 94406
Profiling [baseline] (94.753 ms) : 0, 94753
Profiling [candidate] (94.957 ms) : 0, 94957
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 20 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~d183f39a7c, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section baseline
no_agent (1.245 ms) : 1233, 1258
. : milestone, 1245,
iast (3.283 ms) : 3236, 3330
. : milestone, 3283,
iast_FULL (6.055 ms) : 5992, 6118
. : milestone, 6055,
iast_GLOBAL (3.682 ms) : 3622, 3743
. : milestone, 3682,
profiling (2.436 ms) : 2411, 2461
. : milestone, 2436,
tracing (2.013 ms) : 1995, 2031
. : milestone, 2013,
section candidate
no_agent (1.276 ms) : 1263, 1288
. : milestone, 1276,
iast (3.398 ms) : 3351, 3446
. : milestone, 3398,
iast_FULL (6.033 ms) : 5973, 6093
. : milestone, 6033,
iast_GLOBAL (3.651 ms) : 3588, 3714
. : milestone, 3651,
profiling (2.345 ms) : 2321, 2368
. : milestone, 2345,
tracing (1.884 ms) : 1869, 1899
. : milestone, 1884,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~d183f39a7c, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section baseline
no_agent (18.233 ms) : 18046, 18419
. : milestone, 18233,
appsec (19.929 ms) : 19724, 20133
. : milestone, 19929,
code_origins (17.583 ms) : 17409, 17758
. : milestone, 17583,
iast (18.015 ms) : 17838, 18192
. : milestone, 18015,
profiling (18.469 ms) : 18282, 18657
. : milestone, 18469,
tracing (17.72 ms) : 17546, 17894
. : milestone, 17720,
section candidate
no_agent (18.27 ms) : 18086, 18454
. : milestone, 18270,
appsec (19.172 ms) : 18975, 19369
. : milestone, 19172,
code_origins (17.677 ms) : 17503, 17851
. : milestone, 17677,
iast (17.934 ms) : 17753, 18115
. : milestone, 17934,
profiling (18.356 ms) : 18174, 18538
. : milestone, 18356,
tracing (17.577 ms) : 17406, 17748
. : milestone, 17577,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~d183f39a7c, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1500
. : milestone, 1489,
appsec (3.759 ms) : 3541, 3977
. : milestone, 3759,
iast (2.275 ms) : 2206, 2345
. : milestone, 2275,
iast_GLOBAL (2.319 ms) : 2249, 2390
. : milestone, 2319,
profiling (2.102 ms) : 2048, 2157
. : milestone, 2102,
tracing (2.086 ms) : 2032, 2140
. : milestone, 2086,
section candidate
no_agent (1.487 ms) : 1476, 1499
. : milestone, 1487,
appsec (3.786 ms) : 3566, 4005
. : milestone, 3786,
iast (2.28 ms) : 2210, 2350
. : milestone, 2280,
iast_GLOBAL (2.332 ms) : 2262, 2403
. : milestone, 2332,
profiling (2.103 ms) : 2048, 2158
. : milestone, 2103,
tracing (2.079 ms) : 2026, 2133
. : milestone, 2079,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~d183f39a7c, baseline=1.62.0-SNAPSHOT~e6cac64dfd
dateFormat X
axisFormat %s
section baseline
no_agent (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
appsec (14.605 s) : 14605000, 14605000
. : milestone, 14605000,
iast (18.381 s) : 18381000, 18381000
. : milestone, 18381000,
iast_GLOBAL (17.81 s) : 17810000, 17810000
. : milestone, 17810000,
profiling (15.429 s) : 15429000, 15429000
. : milestone, 15429000,
tracing (14.839 s) : 14839000, 14839000
. : milestone, 14839000,
section candidate
no_agent (15.551 s) : 15551000, 15551000
. : milestone, 15551000,
appsec (14.801 s) : 14801000, 14801000
. : milestone, 14801000,
iast (18.49 s) : 18490000, 18490000
. : milestone, 18490000,
iast_GLOBAL (17.943 s) : 17943000, 17943000
. : milestone, 17943000,
profiling (15.677 s) : 15677000, 15677000
. : milestone, 15677000,
tracing (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
|
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
What Does This Do
Selects
ParentBasedAlwaysOnSamplerinSampler.Builder.forConfig()whendd.trace.otel.exporter=otlp, replacingAllSamplerandRateByServiceTraceSampler. User-configured samplers —RuleBasedTraceSampler(rules /DD_TRACE_SAMPLE_RATE),ForcePrioritySampler(dd.priority.sampling.force), andAsmStandaloneSampler— are preserved.Motivation
The OpenTelemetry Tracing SDK spec requires that only sampled spans reach the exporter, so the SDK sampler must emit a sampling decision. The upcoming OTLP writer implementation explicitly checks for sampling priority when deciding whether to include a span. Neither of the default-path samplers is suitable on the OTLP path:
AllSampler(priority sampling disabled) doesn't emit a sampling priority — it leaves the trace UNSET, which the upcoming OTLP exporter would discard.RateByServiceTraceSampler(the default) depends on the Datadog Agent for per-service rate updates, which isn't part of an OTLP-only deploymentAdditional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note:Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.