Skip to content

Report dropped stats aggregates in health metrics - #11231

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
andrea.marziali/add-metrics-on-drop
Apr 30, 2026
Merged

Report dropped stats aggregates in health metrics#11231
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
andrea.marziali/add-metrics-on-drop

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

ConflatingMetricsAggregatorbounds its aggregate cache tomaxAggregates` entries via an LRU eviction policy. When the limit is exceeded, the least-recently-used aggregate is silently discarded — its accumulated hit counts and durations are lost and never reported to the agent.

This PR wires the existing CommonKeyCleaner eviction callback into HealthMetrics, emitting a new StatsD counter stats.dropped_aggregates (tagged reason:lru_eviction) each time an aggregate is evicted.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note:Once your PR is ready to merge, add it to the merge queue by commenting /merge./merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@amarziali
amarziali requested a review from a team as a code ownerApril 29, 2026 12:24
@amarzialiamarziali added type: feature Enhancements and improvements comp: metrics Metrics labels Apr 29, 2026
@amarziali
amarziali requested a review from ygreeApril 29, 2026 12:24

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:58bde96499

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threaddd-trace-core/src/main/java/datadog/trace/common/metrics/Aggregator.java Outdated
@amarzialiamarziali added the tag: ai generated Largely based on code generated by an AI or LLM label Apr 29, 2026
@pr-commenter

pr-commenterBot commented Apr 29, 2026

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmasterandrea.marziali/add-metrics-on-drop
git_commit_date17774595101777468499
git_commit_shaf551ff9f1bc43a
release_version1.62.0-SNAPSHOT~f551ff99c21.62.0-SNAPSHOT~f1bc43ad38
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17774703931777470393
ci_job_id16421519491642151949
ci_pipeline_id110427860110427860
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-zfyrx7zua-project-304-concurrent-0-77a9zb8k 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-zfyrx7zua-project-304-concurrent-0-77a9zb8k 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
moduleAgentAgent
parentNoneNone

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics.

Startup time reports for petclinic
gantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063737
Total [baseline] (11.119 s) : 0, 11119171
Agent [candidate] (1.066 s) : 0, 1065618
Total [candidate] (11.094 s) : 0, 11094391
section appsec
Agent [baseline] (1.275 s) : 0, 1275301
Total [baseline] (11.097 s) : 0, 11096824
Agent [candidate] (1.27 s) : 0, 1269546
Total [candidate] (11.163 s) : 0, 11162933
section iast
Agent [baseline] (1.244 s) : 0, 1244153
Total [baseline] (11.344 s) : 0, 11343607
Agent [candidate] (1.247 s) : 0, 1246945
Total [candidate] (11.369 s) : 0, 11369074
section profiling
Agent [baseline] (1.189 s) : 0, 1189102
Total [baseline] (11.083 s) : 0, 11083469
Agent [candidate] (1.187 s) : 0, 1186725
Total [candidate] (11.114 s) : 0, 11114375
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing1.064 s-
Agentappsec1.275 s211.564 ms (19.9%)
Agentiast1.244 s180.416 ms (17.0%)
Agentprofiling1.189 s125.364 ms (11.8%)
Totaltracing11.119 s-
Totalappsec11.097 s-22.347 ms (-0.2%)
Totaliast11.344 s224.436 ms (2.0%)
Totalprofiling11.083 s-35.702 ms (-0.3%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing1.066 s-
Agentappsec1.27 s203.928 ms (19.1%)
Agentiast1.247 s181.328 ms (17.0%)
Agentprofiling1.187 s121.108 ms (11.4%)
Totaltracing11.094 s-
Totalappsec11.163 s68.542 ms (0.6%)
Totaliast11.369 s274.683 ms (2.5%)
Totalprofiling11.114 s19.984 ms (0.2%)
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.255 ms) : 0, 1255
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (635.402 ms) : 0, 635402
BytebuddyAgent [candidate] (636.01 ms) : 0, 636010
AgentMeter [baseline] (29.544 ms) : 0, 29544
AgentMeter [candidate] (29.424 ms) : 0, 29424
GlobalTracer [baseline] (249.477 ms) : 0, 249477
GlobalTracer [candidate] (249.373 ms) : 0, 249373
AppSec [baseline] (32.661 ms) : 0, 32661
AppSec [candidate] (32.772 ms) : 0, 32772
Debugger [baseline] (60.557 ms) : 0, 60557
Debugger [candidate] (60.375 ms) : 0, 60375
Remote Config [baseline] (618.976 µs) : 0, 619
Remote Config [candidate] (604.534 µs) : 0, 605
Telemetry [baseline] (8.383 ms) : 0, 8383
Telemetry [candidate] (8.314 ms) : 0, 8314
Flare Poller [baseline] (9.747 ms) : 0, 9747
Flare Poller [candidate] (11.369 ms) : 0, 11369
section appsec
crashtracking [baseline] (1.242 ms) : 0, 1242
crashtracking [candidate] (1.231 ms) : 0, 1231
BytebuddyAgent [baseline] (680.938 ms) : 0, 680938
BytebuddyAgent [candidate] (678.121 ms) : 0, 678121
AgentMeter [baseline] (12.406 ms) : 0, 12406
AgentMeter [candidate] (12.225 ms) : 0, 12225
GlobalTracer [baseline] (251.429 ms) : 0, 251429
GlobalTracer [candidate] (249.427 ms) : 0, 249427
IAST [baseline] (24.706 ms) : 0, 24706
IAST [candidate] (24.709 ms) : 0, 24709
AppSec [baseline] (186.226 ms) : 0, 186226
AppSec [candidate] (185.348 ms) : 0, 185348
Debugger [baseline] (65.111 ms) : 0, 65111
Debugger [candidate] (64.723 ms) : 0, 64723
Remote Config [baseline] (580.645 µs) : 0, 581
Remote Config [candidate] (571.51 µs) : 0, 572
Telemetry [baseline] (7.827 ms) : 0, 7827
Telemetry [candidate] (7.852 ms) : 0, 7852
Flare Poller [baseline] (7.93 ms) : 0, 7930
Flare Poller [candidate] (9.05 ms) : 0, 9050
section iast
crashtracking [baseline] (1.238 ms) : 0, 1238
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (822.796 ms) : 0, 822796
BytebuddyAgent [candidate] (824.266 ms) : 0, 824266
AgentMeter [baseline] (11.268 ms) : 0, 11268
AgentMeter [candidate] (11.311 ms) : 0, 11311
GlobalTracer [baseline] (237.86 ms) : 0, 237860
GlobalTracer [candidate] (238.179 ms) : 0, 238179
IAST [baseline] (27.433 ms) : 0, 27433
IAST [candidate] (26.845 ms) : 0, 26845
AppSec [baseline] (32.288 ms) : 0, 32288
AppSec [candidate] (33.354 ms) : 0, 33354
Debugger [baseline] (63.247 ms) : 0, 63247
Debugger [candidate] (63.577 ms) : 0, 63577
Remote Config [baseline] (523.542 µs) : 0, 524
Remote Config [candidate] (535.014 µs) : 0, 535
Telemetry [baseline] (7.973 ms) : 0, 7973
Telemetry [candidate] (8.03 ms) : 0, 8030
Flare Poller [baseline] (3.453 ms) : 0, 3453
Flare Poller [candidate] (3.46 ms) : 0, 3460
section profiling
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (694.082 ms) : 0, 694082
BytebuddyAgent [candidate] (692.499 ms) : 0, 692499
AgentMeter [baseline] (8.967 ms) : 0, 8967
AgentMeter [candidate] (8.944 ms) : 0, 8944
GlobalTracer [baseline] (208.328 ms) : 0, 208328
GlobalTracer [candidate] (207.891 ms) : 0, 207891
AppSec [baseline] (32.662 ms) : 0, 32662
AppSec [candidate] (32.857 ms) : 0, 32857
Debugger [baseline] (66.148 ms) : 0, 66148
Debugger [candidate] (65.645 ms) : 0, 65645
Remote Config [baseline] (580.916 µs) : 0, 581
Remote Config [candidate] (589.575 µs) : 0, 590
Telemetry [baseline] (8.114 ms) : 0, 8114
Telemetry [candidate] (8.072 ms) : 0, 8072
Flare Poller [baseline] (3.524 ms) : 0, 3524
Flare Poller [candidate] (3.522 ms) : 0, 3522
ProfilingAgent [baseline] (94.016 ms) : 0, 94016
ProfilingAgent [candidate] (94.085 ms) : 0, 94085
Profiling [baseline] (94.562 ms) : 0, 94562
Profiling [candidate] (94.645 ms) : 0, 94645
Loading
Startup time reports for insecure-bank
gantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065215
Total [baseline] (8.833 s) : 0, 8832595
Agent [candidate] (1.072 s) : 0, 1071694
Total [candidate] (8.882 s) : 0, 8881805
section iast
Agent [baseline] (1.246 s) : 0, 1245594
Total [baseline] (9.501 s) : 0, 9501393
Agent [candidate] (1.245 s) : 0, 1245180
Total [candidate] (9.547 s) : 0, 9547139
Loading
  • baseline results
ModuleVariantDurationΔ tracing
Agenttracing1.065 s-
Agentiast1.246 s180.38 ms (16.9%)
Totaltracing8.833 s-
Totaliast9.501 s668.798 ms (7.6%)
  • candidate results
ModuleVariantDurationΔ tracing
Agenttracing1.072 s-
Agentiast1.245 s173.486 ms (16.2%)
Totaltracing8.882 s-
Totaliast9.547 s665.334 ms (7.5%)
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.224 ms) : 0, 1224
crashtracking [candidate] (1.243 ms) : 0, 1243
BytebuddyAgent [baseline] (636.433 ms) : 0, 636433
BytebuddyAgent [candidate] (640.118 ms) : 0, 640118
AgentMeter [baseline] (29.339 ms) : 0, 29339
AgentMeter [candidate] (29.677 ms) : 0, 29677
GlobalTracer [baseline] (248.823 ms) : 0, 248823
GlobalTracer [candidate] (251.177 ms) : 0, 251177
AppSec [baseline] (32.934 ms) : 0, 32934
AppSec [candidate] (33.061 ms) : 0, 33061
Debugger [baseline] (59.937 ms) : 0, 59937
Debugger [candidate] (60.457 ms) : 0, 60457
Remote Config [baseline] (596.315 µs) : 0, 596
Remote Config [candidate] (617.48 µs) : 0, 617
Telemetry [baseline] (9.962 ms) : 0, 9962
Telemetry [candidate] (9.28 ms) : 0, 9280
Flare Poller [baseline] (9.93 ms) : 0, 9930
Flare Poller [candidate] (9.792 ms) : 0, 9792
section iast
crashtracking [baseline] (1.224 ms) : 0, 1224
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (824.801 ms) : 0, 824801
BytebuddyAgent [candidate] (823.686 ms) : 0, 823686
AgentMeter [baseline] (11.282 ms) : 0, 11282
AgentMeter [candidate] (11.284 ms) : 0, 11284
GlobalTracer [baseline] (238.126 ms) : 0, 238126
GlobalTracer [candidate] (238.54 ms) : 0, 238540
IAST [baseline] (25.924 ms) : 0, 25924
IAST [candidate] (26.633 ms) : 0, 26633
AppSec [baseline] (33.144 ms) : 0, 33144
AppSec [candidate] (33.327 ms) : 0, 33327
Debugger [baseline] (63.119 ms) : 0, 63119
Debugger [candidate] (62.543 ms) : 0, 62543
Remote Config [baseline] (531.16 µs) : 0, 531
Remote Config [candidate] (523.83 µs) : 0, 524
Telemetry [baseline] (7.898 ms) : 0, 7898
Telemetry [candidate] (7.913 ms) : 0, 7913
Flare Poller [baseline] (3.411 ms) : 0, 3411
Flare Poller [candidate] (3.358 ms) : 0, 3358
Loading

Load

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmasterandrea.marziali/add-metrics-on-drop
git_commit_date17774595101777468499
git_commit_shaf551ff9f1bc43a
release_version1.62.0-SNAPSHOT~f551ff99c21.62.0-SNAPSHOT~f1bc43ad38
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17774709691777470969
ci_job_id16421519521642151952
ci_pipeline_id110427860110427860
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-zfyrx7zua-project-304-concurrent-0-w77vhysn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-zfyrx7zua-project-304-concurrent-0-w77vhysn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 4 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.

scenarioΔ mean agg_http_req_duration_p50Δ mean agg_http_req_duration_p95Δ mean throughputcandidate mean agg_http_req_duration_p50candidate mean agg_http_req_duration_p95candidate mean throughputbaseline mean agg_http_req_duration_p50baseline mean agg_http_req_duration_p95baseline mean throughput
scenario:load:insecure-bank:iast:high_loadbetter
[-287.489µs; -202.457µs] or [-10.633%; -7.488%]
better
[-593.299µs; -184.119µs] or [-7.624%; -2.366%]
unstable
[-37.231op/s; +248.356op/s] or [-2.810%; +18.744%]
2.459ms7.394ms1430.531op/s2.704ms7.782ms1324.969op/s
scenario:load:petclinic:profiling:high_loadbetter
[-1.778ms; -0.866ms] or [-9.310%; -4.536%]
better
[-2.531ms; -1.122ms] or [-8.271%; -3.668%]
unstable
[-7.029op/s; +41.966op/s] or [-2.923%; +17.454%]
17.775ms28.774ms257.906op/s19.097ms30.601ms240.438op/s
Request duration reports for petclinic
gantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section baseline
no_agent (19.234 ms) : 19040, 19428
. : milestone, 19234,
appsec (18.675 ms) : 18484, 18867
. : milestone, 18675,
code_origins (18.05 ms) : 17870, 18230
. : milestone, 18050,
iast (18.948 ms) : 18758, 19138
. : milestone, 18948,
profiling (19.412 ms) : 19217, 19607
. : milestone, 19412,
tracing (17.718 ms) : 17542, 17893
. : milestone, 17718,
section candidate
no_agent (19.736 ms) : 19534, 19937
. : milestone, 19736,
appsec (18.651 ms) : 18463, 18839
. : milestone, 18651,
code_origins (18.577 ms) : 18392, 18761
. : milestone, 18577,
iast (18.527 ms) : 18343, 18710
. : milestone, 18527,
profiling (18.094 ms) : 17915, 18274
. : milestone, 18094,
tracing (17.856 ms) : 17682, 18030
. : milestone, 17856,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent19.234 ms [19.04 ms, 19.428 ms]-
appsec18.675 ms [18.484 ms, 18.867 ms]-558.923 µs (-2.9%)
code_origins18.05 ms [17.87 ms, 18.23 ms]-1.184 ms (-6.2%)
iast18.948 ms [18.758 ms, 19.138 ms]-286.125 µs (-1.5%)
profiling19.412 ms [19.217 ms, 19.607 ms]178.148 µs (0.9%)
tracing17.718 ms [17.542 ms, 17.893 ms]-1.516 ms (-7.9%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent19.736 ms [19.534 ms, 19.937 ms]-
appsec18.651 ms [18.463 ms, 18.839 ms]-1.085 ms (-5.5%)
code_origins18.577 ms [18.392 ms, 18.761 ms]-1.159 ms (-5.9%)
iast18.527 ms [18.343 ms, 18.71 ms]-1.209 ms (-6.1%)
profiling18.094 ms [17.915 ms, 18.274 ms]-1.642 ms (-8.3%)
tracing17.856 ms [17.682 ms, 18.03 ms]-1.88 ms (-9.5%)
Request duration reports for insecure-bank
gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section baseline
no_agent (1.242 ms) : 1231, 1253
. : milestone, 1242,
iast (3.457 ms) : 3406, 3508
. : milestone, 3457,
iast_FULL (5.981 ms) : 5921, 6041
. : milestone, 5981,
iast_GLOBAL (3.729 ms) : 3666, 3792
. : milestone, 3729,
profiling (2.249 ms) : 2228, 2271
. : milestone, 2249,
tracing (1.857 ms) : 1842, 1872
. : milestone, 1857,
section candidate
no_agent (1.254 ms) : 1242, 1266
. : milestone, 1254,
iast (3.197 ms) : 3157, 3236
. : milestone, 3197,
iast_FULL (5.957 ms) : 5897, 6017
. : milestone, 5957,
iast_GLOBAL (3.685 ms) : 3621, 3749
. : milestone, 3685,
profiling (2.392 ms) : 2368, 2415
. : milestone, 2392,
tracing (1.887 ms) : 1871, 1902
. : milestone, 1887,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent1.242 ms [1.231 ms, 1.253 ms]-
iast3.457 ms [3.406 ms, 3.508 ms]2.215 ms (178.3%)
iast_FULL5.981 ms [5.921 ms, 6.041 ms]4.739 ms (381.4%)
iast_GLOBAL3.729 ms [3.666 ms, 3.792 ms]2.487 ms (200.2%)
profiling2.249 ms [2.228 ms, 2.271 ms]1.007 ms (81.1%)
tracing1.857 ms [1.842 ms, 1.872 ms]614.687 µs (49.5%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent1.254 ms [1.242 ms, 1.266 ms]-
iast3.197 ms [3.157 ms, 3.236 ms]1.943 ms (154.9%)
iast_FULL5.957 ms [5.897 ms, 6.017 ms]4.703 ms (375.0%)
iast_GLOBAL3.685 ms [3.621 ms, 3.749 ms]2.431 ms (193.8%)
profiling2.392 ms [2.368 ms, 2.415 ms]1.137 ms (90.7%)
tracing1.887 ms [1.871 ms, 1.902 ms]632.695 µs (50.5%)

Dacapo

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmasterandrea.marziali/add-metrics-on-drop
git_commit_date17774595101777468499
git_commit_shaf551ff9f1bc43a
release_version1.62.0-SNAPSHOT~f551ff99c21.62.0-SNAPSHOT~f1bc43ad38
See matching parameters
BaselineCandidate
applicationbiojavabiojava
ci_job_date17774706881777470688
ci_job_id16421519551642151955
ci_pipeline_id110427860110427860
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_versionLinux runner-zfyrx7zua-project-304-concurrent-0-c9vy0d39 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/LinuxLinux runner-zfyrx7zua-project-304-concurrent-0-c9vy0d39 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat
gantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1501
. : milestone, 1489,
appsec (3.855 ms) : 3631, 4078
. : milestone, 3855,
iast (2.286 ms) : 2216, 2357
. : milestone, 2286,
iast_GLOBAL (2.338 ms) : 2266, 2409
. : milestone, 2338,
profiling (2.113 ms) : 2058, 2169
. : milestone, 2113,
tracing (2.087 ms) : 2033, 2141
. : milestone, 2087,
section candidate
no_agent (1.493 ms) : 1481, 1505
. : milestone, 1493,
appsec (3.866 ms) : 3643, 4088
. : milestone, 3866,
iast (2.284 ms) : 2213, 2355
. : milestone, 2284,
iast_GLOBAL (2.336 ms) : 2265, 2407
. : milestone, 2336,
profiling (2.11 ms) : 2055, 2166
. : milestone, 2110,
tracing (2.083 ms) : 2029, 2137
. : milestone, 2083,
Loading
  • baseline results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent1.489 ms [1.477 ms, 1.501 ms]-
appsec3.855 ms [3.631 ms, 4.078 ms]2.366 ms (158.9%)
iast2.286 ms [2.216 ms, 2.357 ms]797.476 µs (53.6%)
iast_GLOBAL2.338 ms [2.266 ms, 2.409 ms]848.723 µs (57.0%)
profiling2.113 ms [2.058 ms, 2.169 ms]624.465 µs (41.9%)
tracing2.087 ms [2.033 ms, 2.141 ms]598.155 µs (40.2%)
  • candidate results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent1.493 ms [1.481 ms, 1.505 ms]-
appsec3.866 ms [3.643 ms, 4.088 ms]2.372 ms (158.9%)
iast2.284 ms [2.213 ms, 2.355 ms]790.844 µs (53.0%)
iast_GLOBAL2.336 ms [2.265 ms, 2.407 ms]842.633 µs (56.4%)
profiling2.11 ms [2.055 ms, 2.166 ms]617.016 µs (41.3%)
tracing2.083 ms [2.029 ms, 2.137 ms]589.532 µs (39.5%)
Execution time for biojava
gantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~f1bc43ad38, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section baseline
no_agent (15.307 s) : 15307000, 15307000
. : milestone, 15307000,
appsec (14.627 s) : 14627000, 14627000
. : milestone, 14627000,
iast (18.335 s) : 18335000, 18335000
. : milestone, 18335000,
iast_GLOBAL (17.797 s) : 17797000, 17797000
. : milestone, 17797000,
profiling (14.923 s) : 14923000, 14923000
. : milestone, 14923000,
tracing (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
section candidate
no_agent (15.32 s) : 15320000, 15320000
. : milestone, 15320000,
appsec (14.672 s) : 14672000, 14672000
. : milestone, 14672000,
iast (18.696 s) : 18696000, 18696000
. : milestone, 18696000,
iast_GLOBAL (17.924 s) : 17924000, 17924000
. : milestone, 17924000,
profiling (15.119 s) : 15119000, 15119000
. : milestone, 15119000,
tracing (14.892 s) : 14892000, 14892000
. : milestone, 14892000,
Loading
  • baseline results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent15.307 s [15.307 s, 15.307 s]-
appsec14.627 s [14.627 s, 14.627 s]-680.0 ms (-4.4%)
iast18.335 s [18.335 s, 18.335 s]3.028 s (19.8%)
iast_GLOBAL17.797 s [17.797 s, 17.797 s]2.49 s (16.3%)
profiling14.923 s [14.923 s, 14.923 s]-384.0 ms (-2.5%)
tracing14.806 s [14.806 s, 14.806 s]-501.0 ms (-3.3%)
  • candidate results
VariantExecution Time [CI 0.99]Δ no_agent
no_agent15.32 s [15.32 s, 15.32 s]-
appsec14.672 s [14.672 s, 14.672 s]-648.0 ms (-4.2%)
iast18.696 s [18.696 s, 18.696 s]3.376 s (22.0%)
iast_GLOBAL17.924 s [17.924 s, 17.924 s]2.604 s (17.0%)
profiling15.119 s [15.119 s, 15.119 s]-201.0 ms (-1.3%)
tracing14.892 s [14.892 s, 14.892 s]-428.0 ms (-2.8%)

@amarziali

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ygreeygree left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@amarziali

Copy link
Copy Markdown
ContributorAuthor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Apr 30, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-04-30 06:56:42 UTC ℹ️ Start processing command /merge


2026-04-30 06:56:47 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-04-30 08:57:21 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

@amarziali

Copy link
Copy Markdown
ContributorAuthor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Apr 30, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-04-30 12:41:13 UTC ℹ️ Start processing command /merge


2026-04-30 12:41:18 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-04-30 14:24:56 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit 3afbc1d into masterApr 30, 2026
573 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the andrea.marziali/add-metrics-on-drop branch April 30, 2026 14:24
@github-actionsgithub-actionsBot added this to the 1.62.0 milestone Apr 30, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: metricsMetricstag: ai generatedLargely based on code generated by an AI or LLMtype: featureEnhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@amarziali@ygree