Uh oh!
There was an error while loading. Please reload this page.
Avoid feature discover and java.nio.* access in Bazel Mode - #11232
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits intoApr 30, 2026
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:40d7a0b9eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| DDAgentFeaturesDiscovery featuresDiscovery; | ||
| if (payloadFilesEnabled) { | ||
| featuresDiscovery = null; |
There was a problem hiding this comment.
When CI Visibility payload-files mode is enabled with the default tracer builder, setting this local featuresDiscovery to null does not actually avoid probing the agent: the constructor continues to create DefaultDataStreamsMonitoring, whose constructor unconditionally calls sharedCommunicationObjects.featuresDiscovery(config) in dd-trace-core/src/main/java/datadog/trace/core/datastreams/DefaultDataStreamsMonitoring.java:105 before data streams are conditionally registered. Hermetic Bazel runs will still create/schedule feature discovery as soon as the tracer starts, so payload-files mode needs to bypass that default data-streams initialization or use a no-op there too.
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| featuresDiscovery.discoverIfOutdated(); | ||
| DDAgentFeaturesDiscovery featuresDiscovery; | ||
| if (payloadFilesEnabled) { | ||
| featuresDiscovery = null; |
Contributor
There was a problem hiding this comment.
This might be a bit fragile to set this to null - have you considered introducing a NoopFeaturesDiscovery so that we never deal with null?
ContributorAuthor
There was a problem hiding this comment.
Good point! Addressed in 5a01757 with a NoopFeaturesDiscovery. Reverted the ordering changes also regarding when the discovery was being performed, as it now uses the Noop implementation when necessary 👍
| try (BufferedReader reader = Files.newBufferedReader(manifestPath)) { | ||
| private static boolean isManifestCompatible(String manifestPath) { | ||
| try (BufferedReader reader = | ||
| new BufferedReader(new InputStreamReader(new FileInputStream(manifestPath), "UTF-8"))) { |
Contributor
There was a problem hiding this comment.
using java.nio.charset.StandardCharsets.UTF_8 is acceptable
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~5a01757080, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063278
Total [baseline] (8.808 s) : 0, 8807892
Agent [candidate] (1.069 s) : 0, 1068954
Total [candidate] (8.887 s) : 0, 8887400
section iast
Agent [baseline] (1.242 s) : 0, 1242101
Total [baseline] (9.542 s) : 0, 9542007
Agent [candidate] (1.242 s) : 0, 1241907
Total [candidate] (9.518 s) : 0, 9518298
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~5a01757080, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.229 ms) : 0, 1229
crashtracking [candidate] (1.236 ms) : 0, 1236
BytebuddyAgent [baseline] (634.606 ms) : 0, 634606
BytebuddyAgent [candidate] (639.154 ms) : 0, 639154
AgentMeter [baseline] (29.464 ms) : 0, 29464
AgentMeter [candidate] (29.571 ms) : 0, 29571
GlobalTracer [baseline] (248.653 ms) : 0, 248653
GlobalTracer [candidate] (249.455 ms) : 0, 249455
AppSec [baseline] (32.829 ms) : 0, 32829
AppSec [candidate] (32.982 ms) : 0, 32982
Debugger [baseline] (59.828 ms) : 0, 59828
Debugger [candidate] (59.703 ms) : 0, 59703
Remote Config [baseline] (612.145 µs) : 0, 612
Remote Config [candidate] (632.571 µs) : 0, 633
Telemetry [baseline] (8.4 ms) : 0, 8400
Telemetry [candidate] (9.514 ms) : 0, 9514
Flare Poller [baseline] (11.608 ms) : 0, 11608
Flare Poller [candidate] (9.861 ms) : 0, 9861
section iast
crashtracking [baseline] (1.232 ms) : 0, 1232
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (822.075 ms) : 0, 822075
BytebuddyAgent [candidate] (822.587 ms) : 0, 822587
AgentMeter [baseline] (11.295 ms) : 0, 11295
AgentMeter [candidate] (11.369 ms) : 0, 11369
GlobalTracer [baseline] (237.532 ms) : 0, 237532
GlobalTracer [candidate] (236.608 ms) : 0, 236608
AppSec [baseline] (32.16 ms) : 0, 32160
AppSec [candidate] (32.029 ms) : 0, 32029
Debugger [baseline] (62.425 ms) : 0, 62425
Debugger [candidate] (62.071 ms) : 0, 62071
Remote Config [baseline] (530.54 µs) : 0, 531
Remote Config [candidate] (525.578 µs) : 0, 526
Telemetry [baseline] (7.904 ms) : 0, 7904
Telemetry [candidate] (7.969 ms) : 0, 7969
Flare Poller [baseline] (3.345 ms) : 0, 3345
Flare Poller [candidate] (3.359 ms) : 0, 3359
IAST [baseline] (27.522 ms) : 0, 27522
IAST [candidate] (27.307 ms) : 0, 27307
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~5a01757080, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068580
Total [baseline] (11.019 s) : 0, 11018787
Agent [candidate] (1.067 s) : 0, 1066537
Total [candidate] (10.919 s) : 0, 10918861
section appsec
Agent [baseline] (1.272 s) : 0, 1271614
Total [baseline] (11.074 s) : 0, 11074170
Agent [candidate] (1.273 s) : 0, 1273190
Total [candidate] (11.035 s) : 0, 11035292
section iast
Agent [baseline] (1.241 s) : 0, 1240849
Total [baseline] (11.181 s) : 0, 11180913
Agent [candidate] (1.252 s) : 0, 1251672
Total [candidate] (11.234 s) : 0, 11233507
section profiling
Agent [baseline] (1.186 s) : 0, 1186340
Total [baseline] (10.949 s) : 0, 10948588
Agent [candidate] (1.185 s) : 0, 1184938
Total [candidate] (10.982 s) : 0, 10982024
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~5a01757080, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.246 ms) : 0, 1246
BytebuddyAgent [baseline] (638.122 ms) : 0, 638122
BytebuddyAgent [candidate] (638.609 ms) : 0, 638609
AgentMeter [baseline] (29.581 ms) : 0, 29581
AgentMeter [candidate] (29.649 ms) : 0, 29649
GlobalTracer [baseline] (249.657 ms) : 0, 249657
GlobalTracer [candidate] (247.658 ms) : 0, 247658
AppSec [baseline] (32.931 ms) : 0, 32931
AppSec [candidate] (32.737 ms) : 0, 32737
Debugger [baseline] (60.838 ms) : 0, 60838
Debugger [candidate] (60.691 ms) : 0, 60691
Remote Config [baseline] (603.222 µs) : 0, 603
Remote Config [candidate] (631.858 µs) : 0, 632
Telemetry [baseline] (9.891 ms) : 0, 9891
Telemetry [candidate] (8.589 ms) : 0, 8589
Flare Poller [baseline] (9.762 ms) : 0, 9762
Flare Poller [candidate] (9.826 ms) : 0, 9826
section appsec
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.246 ms) : 0, 1246
BytebuddyAgent [baseline] (679.253 ms) : 0, 679253
BytebuddyAgent [candidate] (679.805 ms) : 0, 679805
AgentMeter [baseline] (12.378 ms) : 0, 12378
AgentMeter [candidate] (12.236 ms) : 0, 12236
GlobalTracer [baseline] (250.382 ms) : 0, 250382
GlobalTracer [candidate] (250.178 ms) : 0, 250178
AppSec [baseline] (185.265 ms) : 0, 185265
AppSec [candidate] (185.683 ms) : 0, 185683
Debugger [baseline] (64.734 ms) : 0, 64734
Debugger [candidate] (64.776 ms) : 0, 64776
Remote Config [baseline] (564.341 µs) : 0, 564
Remote Config [candidate] (566.571 µs) : 0, 567
Telemetry [baseline] (7.863 ms) : 0, 7863
Telemetry [candidate] (7.837 ms) : 0, 7837
Flare Poller [baseline] (7.368 ms) : 0, 7368
Flare Poller [candidate] (8.453 ms) : 0, 8453
IAST [baseline] (24.636 ms) : 0, 24636
IAST [candidate] (24.867 ms) : 0, 24867
section iast
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (820.956 ms) : 0, 820956
BytebuddyAgent [candidate] (828.965 ms) : 0, 828965
AgentMeter [baseline] (11.264 ms) : 0, 11264
AgentMeter [candidate] (11.485 ms) : 0, 11485
GlobalTracer [baseline] (237.032 ms) : 0, 237032
GlobalTracer [candidate] (238.155 ms) : 0, 238155
AppSec [baseline] (30.534 ms) : 0, 30534
AppSec [candidate] (30.641 ms) : 0, 30641
Debugger [baseline] (63.781 ms) : 0, 63781
Debugger [candidate] (63.276 ms) : 0, 63276
Remote Config [baseline] (515.571 µs) : 0, 516
Remote Config [candidate] (518.577 µs) : 0, 519
Telemetry [baseline] (7.939 ms) : 0, 7939
Telemetry [candidate] (7.953 ms) : 0, 7953
Flare Poller [baseline] (3.467 ms) : 0, 3467
Flare Poller [candidate] (3.401 ms) : 0, 3401
IAST [baseline] (28.114 ms) : 0, 28114
IAST [candidate] (28.342 ms) : 0, 28342
section profiling
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.173 ms) : 0, 1173
BytebuddyAgent [baseline] (691.56 ms) : 0, 691560
BytebuddyAgent [candidate] (691.124 ms) : 0, 691124
AgentMeter [baseline] (9.016 ms) : 0, 9016
AgentMeter [candidate] (9.274 ms) : 0, 9274
GlobalTracer [baseline] (208.729 ms) : 0, 208729
GlobalTracer [candidate] (206.367 ms) : 0, 206367
AppSec [baseline] (32.874 ms) : 0, 32874
AppSec [candidate] (32.671 ms) : 0, 32671
Debugger [baseline] (65.927 ms) : 0, 65927
Debugger [candidate] (65.703 ms) : 0, 65703
Remote Config [baseline] (574.013 µs) : 0, 574
Remote Config [candidate] (568.947 µs) : 0, 569
Telemetry [baseline] (8.022 ms) : 0, 8022
Telemetry [candidate] (8.25 ms) : 0, 8250
Flare Poller [baseline] (3.5 ms) : 0, 3500
Flare Poller [candidate] (3.588 ms) : 0, 3588
ProfilingAgent [baseline] (93.615 ms) : 0, 93615
ProfilingAgent [candidate] (94.129 ms) : 0, 94129
Profiling [baseline] (94.171 ms) : 0, 94171
Profiling [candidate] (94.682 ms) : 0, 94682
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~5a01757080, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section baseline
no_agent (1.26 ms) : 1248, 1272
. : milestone, 1260,
iast (3.465 ms) : 3416, 3513
. : milestone, 3465,
iast_FULL (6.107 ms) : 6045, 6169
. : milestone, 6107,
iast_GLOBAL (3.951 ms) : 3894, 4009
. : milestone, 3951,
profiling (2.409 ms) : 2385, 2434
. : milestone, 2409,
tracing (1.862 ms) : 1845, 1878
. : milestone, 1862,
section candidate
no_agent (1.249 ms) : 1236, 1261
. : milestone, 1249,
iast (3.369 ms) : 3324, 3415
. : milestone, 3369,
iast_FULL (5.957 ms) : 5897, 6016
. : milestone, 5957,
iast_GLOBAL (3.789 ms) : 3726, 3851
. : milestone, 3789,
profiling (2.461 ms) : 2435, 2487
. : milestone, 2461,
tracing (1.919 ms) : 1902, 1935
. : milestone, 1919,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~5a01757080, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section baseline
no_agent (18.529 ms) : 18339, 18720
. : milestone, 18529,
appsec (18.422 ms) : 18236, 18608
. : milestone, 18422,
code_origins (17.833 ms) : 17659, 18007
. : milestone, 17833,
iast (17.969 ms) : 17792, 18146
. : milestone, 17969,
profiling (18.302 ms) : 18119, 18485
. : milestone, 18302,
tracing (17.976 ms) : 17798, 18154
. : milestone, 17976,
section candidate
no_agent (19.283 ms) : 19087, 19479
. : milestone, 19283,
appsec (18.351 ms) : 18169, 18534
. : milestone, 18351,
code_origins (17.809 ms) : 17631, 17986
. : milestone, 17809,
iast (17.877 ms) : 17704, 18050
. : milestone, 17877,
profiling (18.268 ms) : 18090, 18446
. : milestone, 18268,
tracing (17.685 ms) : 17512, 17858
. : milestone, 17685,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~5a01757080, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section baseline
no_agent (1.492 ms) : 1480, 1503
. : milestone, 1492,
appsec (3.861 ms) : 3638, 4084
. : milestone, 3861,
iast (2.293 ms) : 2223, 2363
. : milestone, 2293,
iast_GLOBAL (2.333 ms) : 2263, 2404
. : milestone, 2333,
profiling (2.114 ms) : 2059, 2169
. : milestone, 2114,
tracing (2.092 ms) : 2039, 2146
. : milestone, 2092,
section candidate
no_agent (1.492 ms) : 1481, 1504
. : milestone, 1492,
appsec (2.565 ms) : 2509, 2621
. : milestone, 2565,
iast (2.296 ms) : 2226, 2366
. : milestone, 2296,
iast_GLOBAL (2.331 ms) : 2260, 2401
. : milestone, 2331,
profiling (2.121 ms) : 2066, 2176
. : milestone, 2121,
tracing (2.094 ms) : 2040, 2147
. : milestone, 2094,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~5a01757080, baseline=1.62.0-SNAPSHOT~f551ff99c2
dateFormat X
axisFormat %s
section baseline
no_agent (15.615 s) : 15615000, 15615000
. : milestone, 15615000,
appsec (15.042 s) : 15042000, 15042000
. : milestone, 15042000,
iast (18.662 s) : 18662000, 18662000
. : milestone, 18662000,
iast_GLOBAL (17.9 s) : 17900000, 17900000
. : milestone, 17900000,
profiling (15.464 s) : 15464000, 15464000
. : milestone, 15464000,
tracing (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
section candidate
no_agent (15.424 s) : 15424000, 15424000
. : milestone, 15424000,
appsec (14.691 s) : 14691000, 14691000
. : milestone, 14691000,
iast (18.998 s) : 18998000, 18998000
. : milestone, 18998000,
iast_GLOBAL (18.022 s) : 18022000, 18022000
. : milestone, 18022000,
profiling (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
tracing (15.111 s) : 15111000, 15111000
. : milestone, 15111000,
|
amarziali
approved these changes
Apr 30, 2026
amarziali
left a comment
Contributor
There was a problem hiding this comment.
thanks for having done the suggested changes. lgtm for the platform
gnufede
approved these changes
Apr 30, 2026
daniel-mohedano
commented
Apr 30, 2026
ContributorAuthor
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
anmarchenko
approved these changes
Apr 30, 2026
Uh oh!
There was an error while loading. Please reload this page.
gh-worker-dd-mergequeue-cf854dBot
deleted the
daniel.mohedano/bazel-fixes
branch
April 30, 2026 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
java.nio.*classes during pre-main through the bazel mode resolution.Additional Notes
test-environment-trigger: skip
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note:Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.