Skip to content

Migrate dd-trace-core groovy files to java part 6 - #11362

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
jpbempel/g2j-core-pt6
May 15, 2026
Merged

Migrate dd-trace-core groovy files to java part 6#11362
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
jpbempel/g2j-core-pt6

Conversation

@jpbempel

@jpbempeljpbempel commented May 13, 2026

Copy link
Copy Markdown
Member

What Does This Do

we migrate 6 tests

  • PendingTracerBufferTest
  • PendingTraceStrictWriteTest
  • PendingTraceTest
  • PendingTraceTestBase
  • TraceInterceptorTest
  • TracingConfigPollerTest

Motivation

this is part of the effort to migrate groovy tests to Java/JUnit
part1: #11053
part2: #11062
part3: #11085
part4: #11146
part5: #11217

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note:Once your PR is ready to merge, add it to the merge queue by commenting /merge./merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@jpbempel
jpbempel requested a review from a team as a code ownerMay 13, 2026 07:25
@jpbempel
jpbempel requested a review from dougqhMay 13, 2026 07:25
@dd-octo-sts

dd-octo-stsBot commented May 13, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@jpbempel
Migrate dd-trace-core groovy files to java part 6
66b5f3c
we migrate 6 tests
- PendingTracerBufferTest
- PendingTraceStrictWriteTest
- PendingTraceTest
- PendingTraceTestBase
- TraceInterceptorTest
- TracingConfigPollerTest
@jpbempel
jpbempelforce-pushed the jpbempel/g2j-core-pt6 branch from abcd3c1 to 66b5f3cCompareMay 13, 2026 08:09
@jpbempeljpbempel added comp: testing Testing tag: no release notes Changes to exclude from release notes labels May 13, 2026
dougqh
dougqh reviewed May 13, 2026
View reviewed changes
Comment threaddd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java
return "0";
}

// @VisibleForTesting

@dougqhdougqhMay 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine with package visible member variables, but I don't feel strongly either way.

bric3
bric3 reviewed May 13, 2026
View reviewed changes
Comment threaddd-trace-core/src/test/groovy/datadog/trace/core/PendingTraceBufferTest.groovy
bric3
bric3 reviewed May 14, 2026
View reviewed changes

@bric3bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few issues in the port on PendingTraceBufferTest, that's strange that the llm didn't caught them

Comment threaddd-trace-core/src/test/java/datadog/trace/core/PendingTraceBufferTest.java Outdated
Comment threaddd-trace-core/src/test/java/datadog/trace/core/PendingTraceBufferTest.java Outdated
Comment threaddd-trace-core/src/test/java/datadog/trace/core/PendingTraceBufferTest.java Outdated
Comment threaddd-trace-core/src/test/java/datadog/trace/core/PendingTraceBufferTest.java
@jpbempel
jpbempelforce-pushed the jpbempel/g2j-core-pt6 branch from 2bc0b33 to 04c28fcCompareMay 15, 2026 07:36
@jpbempel
jpbempel added this pull request to the merge queueMay 15, 2026
@dd-octo-sts

dd-octo-stsBot commented May 15, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented May 15, 2026•
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-05-15 10:29:31 UTC ℹ️ Start processing command /merge

2026-05-15 10:29:36 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-05-15 12:16:03 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks May 15, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit 86eece6 into masterMay 15, 2026
735 of 758 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the jpbempel/g2j-core-pt6 branch May 15, 2026 12:15
@github-actionsgithub-actionsBot added this to the 1.63.0 milestone May 15, 2026
@jpbempeljpbempel mentioned this pull request May 15, 2026
Merged
kaahos pushed a commit that referenced this pull request May 15, 2026
@jpbempeldevflow.devflow-routing-intake@kaahos
Migrate dd-trace-core groovy files to java part 6 (#11362)
e32c4f7
Migrate dd-trace-core groovy files to java part 6
we migrate 6 tests
- PendingTracerBufferTest
- PendingTraceStrictWriteTest
- PendingTraceTest
- PendingTraceTestBase
- TraceInterceptorTest
- TracingConfigPollerTest
address comments
Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
@sarahchen6sarahchen6 mentioned this pull request May 15, 2026
Merged
This was referenced May 21, 2026
Merged
Merged
This was referenced Jun 3, 2026
Merged
Merged
This was referenced Jun 10, 2026
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougqhdougqhdougqh approved these changes
@bric3bric3bric3 approved these changes

Assignees

No one assigned

Labels

comp: testingTestingtag: no release notesChanges to exclude from release notes

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jpbempel@dougqh@bric3