Uh oh!
There was an error while loading. Please reload this page.
Allow Gradle smoke tests to run on Gradle 9.x - #11490
Conversation
Gradle 9 bundles Groovy 4. The :dd-smoke-tests:gradle module uses `gradleTestKit()`, as a result Gradle's groovy 4.x ends up on the p project classpath. Groovy 4 tightened `MetaClassImpl` overload resolution. While the previous `super.handle(...)` call in `MethodSpec`, `HandlerSpec` and `PrefixHandlerSpec` relied on Groovy 3 _widening_ the shaded `datadog.eclipse.jetty.server.Request` argument to the parent's declared `HttpServletRequest` parameter type ; under Groovy 4 the metaclass **no longer performs that widening**, the lookup falls through to `methodMissing`, raising a `MissingMethodException` when executing `super.handle(target, baseRequest, request, response)` in the `TestHttpServer.handle` method. Annotating the three subclass `handle` overrides with `@CompileStatic` forces Java-like static dispatch. The bytecode emits `INVOKESPECIAL` against the parent's declared signature, bypassing the runtime metaclass lookup entirely. `AllHandlerSpec` is left untouched since its body uses dynamic Groovy idioms.
Gradle 9.5.1 raises TestKit's minimum supported Gradle version above the old 3.5 fixture. Skip Gradle versions that the current TestKit cannot run, so the smoke test does not fail before CI Visibility assertions can run. Also isolate nested launcher wrapper invocations with a temporary GRADLE_USER_HOME. This prevents user or CI init scripts from breaking older Gradle/Kotlin runtimes during wrapper setup. Update legacy expected events to include the ITR tests-skipping metadata emitted by the current tracer.
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master resultsStartup Time
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
bric3
commented
May 28, 2026
@codex review |
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
Uh oh!
There was an error while loading. Please reload this page.
d7affab
into
masterUh oh!
There was an error while loading. Please reload this page.
What Does This Do
Fix
:dd-smoke-tests:gradleunder Gradle 9.5.1.Smoke test uses the Gradle Test provided by the current Gradle version. Bumping to major 9.x also bumped the minimum legacy version. 3.x is not anymore available under Gradle 9. This PR allow to skip the tests if it's untestable with the current test kit. Given this PR still runs on Gradle 8.x 3.5 remains listed.
Note
It's worth noting this smoke test is a best-effort to test old legacy Gradle versions.
Also, this now isolates the nested distribution setup with a temporary
GRADLE_USER_HOME, it also ensure a static dispatch on theTestHttpServer.handleoverrides used by this path, to cover Groovy 4 restriction in that area.The legacy Gradle event fixtures are also refreshed for the ITR tests-skipping metadata emitted by the current tracer. THis appear to take the same approach as #11453.
Part of #10402 and #11272.
Motivation
Gradle 9.5.1's TestKit no longer runs the old Gradle 3.5 fixture. We still want coverage for the earliest Gradle version the current TestKit can execute, and the test now says that explicitly instead of letting the policy live only in CI behavior.
Additional Notes
Validation used while preparing this branch:
./gradlew :dd-smoke-tests:gradle:test -PtestJvm=8./gradlew :dd-smoke-tests:gradle:test./gradlew :dd-smoke-tests:gradle:spotlessJavaCheckContributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-levelJira ticket: [PROJ-IDENT]