Skip to content

Improve JUnit Type Converter and clean up AI generated code - #11606

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 22 commits into
masterfrom
bbujon/groovy-to-java
Jun 12, 2026
Merged

Improve JUnit Type Converter and clean up AI generated code#11606
gh-worker-dd-mergequeue-cf854d[bot] merged 22 commits into
masterfrom
bbujon/groovy-to-java

Conversation

@PerfectSlayer

@PerfectSlayerPerfectSlayer commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

What Does This Do

Clean up AI generated code including:

  • Fix magic constant
  • Fix context API using
  • Remove comment with arg names - always injected by editor and will be out of sync on refactoring
  • Reuse constants from implementations

Introduce new generic TypeConvertor for class constants - will port more existing converters to - that supports both class name qualified constant and constant name only.

Motivation

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@PerfectSlayerPerfectSlayer added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Jun 9, 2026
@datadog-official

This comment has been minimized.

@dd-octo-sts

dd-octo-stsBot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

SuiteStatus
Startup🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
ScenarioCandidatemasterΔ (95% CI of mean)
startup:insecure-bank:iast:Agent13.88 s13.97 s[-1.3%; -0.0%] (maybe better)
startup:insecure-bank:tracing:Agent12.90 s12.94 s[-1.1%; +0.6%] (no difference)
startup:petclinic:appsec:Agent16.88 s16.46 s[+1.7%; +3.4%] (significantly worse)
startup:petclinic:iast:Agent16.85 s16.44 s[-2.1%; +7.1%] (no difference)
startup:petclinic:profiling:Agent16.66 s16.88 s[-2.4%; -0.2%] (maybe better)
startup:petclinic:sca:Agent16.88 s16.63 s[+0.5%; +2.4%] (maybe worse)
startup:petclinic:tracing:Agent15.53 s16.33 s[-9.0%; -0.9%] (maybe better)

Commit:c4193ebc · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@PerfectSlayer
PerfectSlayer marked this pull request as ready for review June 9, 2026 15:38
@PerfectSlayer
PerfectSlayer requested review from a team as code ownersJune 9, 2026 15:38
@PerfectSlayer
PerfectSlayer requested review from manuel-alvarez-alvarez and mtoffl01 and removed request for a teamJune 9, 2026 15:38
@PerfectSlayer
PerfectSlayer requested a review from a team as a code ownerJune 12, 2026 19:55
@PerfectSlayerPerfectSlayer changed the title Clean up AI generated codeImprove JUnit Type Converter and clean up AI generated codeJun 12, 2026
@PerfectSlayer

Copy link
Copy Markdown
CollaboratorAuthor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Jun 12, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-12 21:11:38 UTC ℹ️ Start processing command /merge


2026-06-12 21:11:46 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-06-12 22:04:16 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-12 22:57:11 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit 26573a6 into masterJun 12, 2026
584 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the bbujon/groovy-to-java branch June 12, 2026 22:57
@github-actionsgithub-actionsBot added this to the 1.64.0 milestone Jun 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: coreTracer coretag: no release notesChanges to exclude from release notestype: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@PerfectSlayer@bric3