Add support for Vert.x 5.1 in tracing by vandonr · Pull Request #11655 · DataDog/dd-trace-java

vandonr · 2026-06-16T15:49:29Z

What Does This Do

the existing muzzle guard for vertx4.0 excluded v5.1 because the type used for the guard was (re)moved.
Andrea suggested a new type to use so that 4.0 instrumentations would continue to apply.

Motivation

#11611

Additional Notes

There are other issues with v5.1 that impact iast code. To be able to test my fix without having to fix IAST code, I excluded their tests from latest deps temporarily after having updated the versions in the gradle lockfile.

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors
Add your completed PR to the merge queue by commenting /merge. You can also:
- Customize the commit message associated with the merge with /merge --commit-message "..."
- Remove your PR from the merge queue with /merge -c
- Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
- Get more information in this doc

Jira ticket: [PROJ-IDENT]

dd-octo-sts · 2026-06-16T15:49:50Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:94f46421d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

dd-octo-sts · 2026-06-16T16:14:32Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.95 s	13.85 s	[+0.1%; +1.4%] (maybe worse)
startup:insecure-bank:tracing:Agent	12.93 s	12.94 s	[-0.7%; +0.6%] (no difference)
startup:petclinic:appsec:Agent	16.31 s	16.64 s	[-6.4%; +2.5%] (no difference)
startup:petclinic:iast:Agent	16.95 s	17.01 s	[-1.3%; +0.6%] (no difference)
startup:petclinic:profiling:Agent	16.78 s	17.01 s	[-2.6%; -0.1%] (maybe better)
startup:petclinic:sca:Agent	16.91 s	16.81 s	[-0.3%; +1.5%] (no difference)
startup:petclinic:tracing:Agent	16.09 s	16.19 s	[-1.6%; +0.3%] (no difference)

Commit:0875a1bf · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

vandonr · 2026-06-17T09:21:58Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:4e94baa47e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

vandonr · 2026-06-17T10:40:50Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:54058ba1a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-17T10:47:11Z

+ className + "$GetCookieAdvice");
+ }
+
+ public static class ParamsAdvice {


Add the request-context guard to ParamsAdvice
This advice declares an @ActiveRequestContext parameter but, unlike the other IAST advices in this file, the advice class is not annotated with @RequiresRequestContext(RequestContextSlot.IAST). The request-context build-time rewriter only converts @ActiveRequestContext for classes annotated with @RequiresRequestContext, so Vert.x 5.1 calls to params()/params(boolean) can end up with an unbound request-context parameter and the query parameter map will not be tainted for IAST.
Useful? React with 👍 / 👎.

amarziali

@vandonr the proposed change involves duplicating all the vertx-4 instrumentation. However, the only part that looks having linkage issues is the appsec one (under core). Now another approach is to remove the muzzle gate on VertxVersionMatcher and replace with io.vertx.core.http.impl.headers.HeadersAdaptor since it has been introduced on 4.0 (so gates against 3.x) and is survives on 5.1+.
Concerning appsec changes I think a trade-off can also be to port first the tracing (and add java tests using the migration skill as latestDepTests) and then later on track a ticket for appsec to support that version. Happy to chat about it and pair

vandonr · 2026-06-17T13:29:37Z

I removed all the previous changes which were too much, and pushed a more targeted fix, that leaves iast out for now.

vandonr · 2026-06-17T13:29:43Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1d7b84344c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

amarziali

Thanks for having simplified the PR. I suggested test improvements. Also muzzle seems unrelately failing. Perhaps merging master will help

amarziali

looks good

vandonr · 2026-06-18T12:52:23Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-06-18T12:52:28Z

View all feedbacks in Devflow UI.

2026-06-18 12:52:28 UTC ℹ️ Start processing command /merge

2026-06-18 12:52:33 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-06-18 13:58:43 UTC ℹ️ MergeQueue: This merge request was merged

vandonr requested review from a team as code owners June 16, 2026 15:49

vandonr requested review from ValentinZakharov, amarziali, dromanol and manuel-alvarez-alvarez and removed request for a teamJune 16, 2026 15:49

This comment has been minimized.
Sign in to view

dd-octo-stsBot added the tag: ai generated Largely based on code generated by an AI or LLM label Jun 16, 2026

vandonr added type: feature Enhancements and improvements inst: vertx Eclipse Vert.x instrumentation tag: override groovy enforcement Override the "Enforce Groovy Migration" check labels Jun 16, 2026

chatgpt-codex-connectorBot reviewed Jun 16, 2026
View reviewed changes

vandonr force-pushed the vandonr/vertx51 branch from d90868d to 4e94baaCompare June 17, 2026 09:21

chatgpt-codex-connectorBot reviewed Jun 17, 2026
View reviewed changes

Comment threaddd-java-agent/instrumentation/vertx/vertx-web/vertx-web-5.0/build.gradle Outdated
Comment thread...in/java/datadog/trace/instrumentation/vertx_5_1/server/HttpServerRequestInstrumentation.java Outdated

chatgpt-codex-connectorBot reviewed Jun 17, 2026
View reviewed changes

amarziali requested changes Jun 17, 2026
View reviewed changes

fix muzzle guard in vertx5 to not exclude 5.1
1d7b843

vandonr force-pushed the vandonr/vertx51 branch from 54058ba to 1d7b843Compare June 17, 2026 13:26

vandonr changed the title ~~support for vertx 5.1~~support for vertx 5.1 in tracingJun 17, 2026

chatgpt-codex-connectorBot reviewed Jun 17, 2026
View reviewed changes

Comment threaddd-java-agent/instrumentation/vertx/vertx-web/vertx-web-5.0/build.gradle Outdated

also exclude iast forked latest tests
e282718

amarziali reviewed Jun 18, 2026
View reviewed changes

Comment threaddd-java-agent/instrumentation/vertx/vertx-web/vertx-web-5.0/build.gradle

Merge branch 'master' into vandonr/vertx51
0875a1b

amarziali approved these changes Jun 18, 2026
View reviewed changes

gh-worker-dd-mergequeue-cf854dBot merged commit 4e8d69f into masterJun 18, 2026
581 checks passed

gh-worker-dd-mergequeue-cf854dBot deleted the vandonr/vertx51 branch June 18, 2026 13:58

github-actionsBot added this to the 1.64.0 milestone Jun 18, 2026

vandonr mentioned this pull request Jul 2, 2026
Fix missing instrumentation for vertx 5.1 responses #11840
Merged

PerfectSlayer changed the title ~~support for vertx 5.1 in tracing~~Add support for Vert.x 5.1 in tracingJul 7, 2026

Uh oh!

Conversation

vandonr commented Jun 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

This comment has been minimized.

dd-octo-stsBot commented Jun 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dd-octo-stsBot commented Jun 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

vandonr commented Jun 17, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

vandonr commented Jun 17, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connectorBotJun 17, 2026

Choose a reason for hiding this comment

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

vandonr commented Jun 17, 2026

Uh oh!

vandonr commented Jun 17, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

amarziali left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

vandonr commented Jun 18, 2026

Uh oh!

gh-worker-devflow-routing-ef8351Bot commented Jun 18, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vandonr commented Jun 16, 2026•
edited
Loading

dd-octo-stsBot commented Jun 16, 2026•
edited
Loading

dd-octo-stsBot commented Jun 16, 2026•
edited
Loading

amarziali left a comment •
edited
Loading

gh-worker-devflow-routing-ef8351Bot commented Jun 18, 2026•
edited
Loading