Uh oh!
There was an error while loading. Please reload this page.
remove(appsec): delete dead DD_APPSEC_REPORTING_INBAND and DD_APPSEC_REPORT_TIMEOUT config keys - #11664
Conversation
…REPORT_TIMEOUT config keys Both config keys were introduced in 2021 (reporting inband in #1d1fc13, report timeout in #2fd53d8) but the classes that consumed them (InbandReportServiceImpl and ReportServiceImpl) were subsequently removed. The getters isAppSecReportingInband(), getAppSecReportMinTimeout() and getAppSecReportMaxTimeout() are now dead code — no caller exists in the codebase. Remove the constants, defaults, fields, assignments and getters. Refs: APPSEC-68459
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:7365c890b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
…REPORT_TIMEOUT from supported-configurations metadata Follow-up to the previous commit removing these keys from Config.java. The metadata/supported-configurations.json entries for DD_APPSEC_REPORTING_INBAND and DD_APPSEC_REPORT_TIMEOUT were still advertising these config keys as supported, which caused GeneratedSupportedConfigurations to include them even though Config no longer reads them.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
What does this PR do?
Removes two AppSec configuration keys that became dead code after the classes that consumed them were deleted:
DD_APPSEC_REPORTING_INBAND(appsec.reporting.inband) — introduced in 1d1fc13 ("Send AppSec attack information together with Trace") to control inband vs. out-of-band attack reporting. TheInbandReportServiceImplthat read this value was subsequently removed. The getterisAppSecReportingInband()had zero callers in the codebase.DD_APPSEC_REPORT_TIMEOUT(appsec.report.timeout) — introduced in 2fd53d8 ("Added AppSec smoke test to validate WAF") as a periodic flush timeout forReportServiceImpl. That class was also removed. The gettersgetAppSecReportMinTimeout()andgetAppSecReportMaxTimeout()had zero callers.Both keys were confirmed private/internal in the FPD review (APPSEC-68459) and their null descriptions reflected the fact that they no longer serve any purpose.
Motivation
Surfaced during the Java config key public/private visibility review (APPSEC-68459). Removing dead configuration avoids confusion and prevents these keys from accidentally appearing in generated documentation.
Additional Notes
Refs: APPSEC-68459