Cleanup of Spotbugs annotations. Removed Spotbugs from test scope.

[AlexeyKuznetsov-DD]

What Does This Do

1. Replaces usages of edu.umd.cs.findbugs.annotations.* annotations with the appropriate javax.annotation.* equivalents.
2. Removes SpotBugs dependencies from the test scope, where they are unnecessary and were primarily present because of the annotations mentioned above.

Motivation

• javax.annotation.* annotations are more standard and widely adopted.
• Running SpotBugs in the test scope provides little to no value while introducing an unnecessary dependency.
• This change simplifies dependency management and reduces reliance on SpotBugs-specific annotations.

Additional Notes

This is a cleanup/refactoring change only. No functional behavior is affected.

Contributor Checklist

• Format the title according to the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any other useful labels
• Avoid using close, fix, or any linking keywords when referencing an issue
  Use solves instead, and assign the PR milestone to the issue
• Update the CODEOWNERS file on source file addition, migration, or deletion
• Update public documentation with any new configuration flags or behaviors
• Add your completed PR to the merge queue by commenting /merge. You can also:
  • Customize the commit message associated with the merge with /merge --commit-message "..."
  • Remove your PR from the merge queue with /merge -c
  • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
  • Get more information in this doc

Jira ticket: [PROJ-IDENT]

[AlexeyKuznetsov-DD]

Removed this annotation, as it was a copy-paste, not checked in test and usage of Spotbugs in test scope make almost no sense.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:3b9e51969f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[pr-commenter]

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1782135971	1782136368
end_time	2026-06-22T13:47:37	2026-06-22T13:54:15
git_branch	master	alexeyk/cleanup-fb
git_commit_sha	3006004	90085d9
start_time	2026-06-22T13:46:12	2026-06-22T13:52:50

See matching parameters

	Baseline	Candidate
ci_job_id	1791411524	1791411524
ci_pipeline_id	120207643	120207643
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1782135313	1782135313

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:loop	better [-3.444ms; -2.784ms] or [-28.695%; -23.191%]	better [-3.523ms; -2.850ms] or [-28.989%; -23.450%]	better [-3.490ms; -2.824ms] or [-28.554%; -23.103%]	better [-3.544ms; -2.856ms] or [-28.618%; -23.063%]	better [+21.734op/s; +27.095op/s] or [+25.429%; +31.701%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-25.385µs; +15.099µs] or [-8.650%; +5.145%]	unstable [-40.248µs; +21.200µs] or [-11.855%; +6.245%]	unstable [-54.164µs; +30.323µs] or [-15.194%; +8.506%]	unstable [+76.961µs; +317.077µs] or [+6.679%; +27.516%]	same
scenario:basic	unsure [-5.588µs; -0.049µs] or [-2.098%; -0.018%]	same	same	unstable [+205.957µs; +488.823µs] or [+19.714%; +46.790%]	same

Request duration reports for reports

gantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (339.492 µs) : 304, 375
. : milestone, 339,
basic (297.515 µs) : 291, 304
. : milestone, 298,
loop (12.154 ms) : 11711, 12596
. : milestone, 12154,
section candidate
noprobe (329.968 µs) : 308, 352
. : milestone, 330,
basic (292.849 µs) : 287, 299
. : milestone, 293,
loop (8.967 ms) : 8962, 8972
. : milestone, 8967,

Loading

• baseline results

Scenario	Request median duration [CI 0.99]
noprobe	339.492 µs [304.372 µs, 374.613 µs]
basic	297.515 µs [290.787 µs, 304.243 µs]
loop	12.154 ms [11.711 ms, 12.596 ms]

• candidate results

Scenario	Request median duration [CI 0.99]
noprobe	329.968 µs [308.229 µs, 351.708 µs]
basic	292.849 µs [286.574 µs, 299.124 µs]
loop	8.967 ms [8.962 ms, 8.972 ms]

[dd-octo-sts]

🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)

Suite	Status
Startup	🟡 warning

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.95 s	13.97 s	[-1.1%; +0.7%] (no difference)
startup:insecure-bank:tracing:Agent	12.87 s	13.01 s	[-1.8%; -0.4%] (maybe better)
startup:petclinic:appsec:Agent	17.48 s	17.29 s	[+0.2%; +2.0%] (maybe worse)
startup:petclinic:iast:Agent	17.52 s	17.54 s	[-0.9%; +0.7%] (no difference)
startup:petclinic:profiling:Agent	17.44 s	17.39 s	[-0.6%; +1.2%] (no difference)
startup:petclinic:sca:Agent	17.58 s	17.49 s	[-0.5%; +1.6%] (no difference)
startup:petclinic:tracing:Agent	16.60 s	16.73 s	[-1.9%; +0.3%] (no difference)

Commit:90085d9a · CI Pipeline · Benchmarking Platform UI

---

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

[PerfectSlayer]

Overall looking good but I would like to know more about this first:

Running SpotBugs in the test scope provides little to no value while introducing an unnecessary dependency.

Don't you think it could be useful to catch test implementation issue?

[AlexeyKuznetsov-DD]

Overall looking good but I would like to know more about this first:

Running SpotBugs in the test scope provides little to no value while introducing an unnecessary dependency.

Don't you think it could be useful to catch test implementation issue?

@PerfectSlayer
Good question — but it's actually a no-op for bug detection here. SpotBugs analysis has never run against the test scope: in gradle/spotbugs.gradle (line 10) the configureEach block disables every spotbugs* task whose name doesn't end in Main/Main_java11 (it.enabled = false), so spotbugsTest is and always has been off.
BTW @bric3 do you recall why we have that?

The testImplementation(libs.spotbugs.annotations) line wasn't enabling any test analysis — it only put the edu.umd.cs.findbugs.annotations.* classes on the test compile classpath so test code using those annotations would compile. The only test-scope usages were a handful of annotation imports (@NonNull, @SuppressFBWarnings), which this PR swaps for the standard javax.annotation.* equivalents. To keep those available at compile time I kept testImplementation(libs.jsr305).

So this drops a heavier dependency that was only ever there for a few annotation imports (one of which was a copy-paste leftover), without losing any actual analysis. If we ever want SpotBugs to catch test implementation issues, that'd be a separate change — enabling the spotbugsTest tasks — which isn't wired up today.

[PerfectSlayer]

Thanks @AlexeyKuznetsov-DD for the clarification 🙏 Approval confirmed 👍

[AlexeyKuznetsov-DD]

/merge

[gh-worker-devflow-routing-ef8351]

View all feedbacks in Devflow UI.

2026-06-22 16:53:34 UTC ℹ️ Start processing command /merge

---

2026-06-22 16:53:47 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

---

2026-06-22 18:28:00 UTC ℹ️ MergeQueue: This merge request was merged