Skip to content

Cover disabled ratelimited logging. - #11776

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
alexeyk/fixed-coverage-rate-limited-logger
Jun 29, 2026
Merged

Cover disabled ratelimited logging.#11776
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
alexeyk/fixed-coverage-rate-limited-logger

Conversation

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

What Does This Do

Adds test coverage for RatelimitedLogger when debug and warn logging are both disabled.

Motivation

Fixed test coverage.

Additional Notes

Checked with ./gradlew :utils:logging-utils:jacocoTestCoverageVerification -PtestJvm=8 -PcheckCoverage

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@AlexeyKuznetsov-DDAlexeyKuznetsov-DD self-assigned this Jun 29, 2026
@AlexeyKuznetsov-DDAlexeyKuznetsov-DD added type: bug fix Bug fix comp: core Tracer core tag: no release notes Changes to exclude from release notes labels Jun 29, 2026
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review June 29, 2026 14:04
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested a review from a team as a code ownerJune 29, 2026 14:04
@dd-octo-sts

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

SuiteStatus
Startup🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
ScenarioCandidatemasterΔ (95% CI of mean)
startup:insecure-bank:iast:Agent14.70 s14.55 s[+0.3%; +1.8%] (maybe worse)
startup:insecure-bank:tracing:Agent13.67 s13.60 s[-0.3%; +1.3%] (no difference)
startup:petclinic:appsec:Agent16.72 s16.64 s[-0.6%; +1.5%] (no difference)
startup:petclinic:iast:Agent16.75 s16.91 s[-1.7%; -0.2%] (maybe better)
startup:petclinic:profiling:Agent16.81 s16.83 s[-1.4%; +1.1%] (no difference)
startup:petclinic:sca:Agent16.86 s16.59 s[+0.8%; +2.4%] (maybe worse)
startup:petclinic:tracing:Agent16.01 s16.19 s[-2.1%; -0.1%] (maybe better)

Commit:b6d9f6fb · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
ContributorAuthor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Jun 29, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-29 16:37:43 UTC ℹ️ Start processing command /merge


2026-06-29 16:37:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-29 17:35:40 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit 4399027 into masterJun 29, 2026
584 of 590 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the alexeyk/fixed-coverage-rate-limited-logger branch June 29, 2026 17:35
@github-actionsgithub-actionsBot added this to the 1.64.0 milestone Jun 29, 2026
TophrC-dd pushed a commit that referenced this pull request Jun 29, 2026
Cover disabled ratelimited logging.
Co-authored-by: alexey.kuznetsov <alexey.kuznetsov@datadoghq.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: coreTracer coretag: no release notesChanges to exclude from release notestype: bug fixBug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexeyKuznetsov-DD@bric3@amarziali