Skip to content

Add missing coverage tests for OptimizedTagMap and EntryReadingHelper - #11778

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
dougqh/tagmap-coverage-fix
Jun 29, 2026
Merged

Add missing coverage tests for OptimizedTagMap and EntryReadingHelper#11778
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
dougqh/tagmap-coverage-fix

Conversation

@dougqh

@dougqhdougqh commented Jun 29, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

What This Does

Increases coverage of TagMap & related classes

Motivation

Additional Notes

Test plan

  • ./gradlew :internal-api:test --tests "datadog.trace.api.TagMapTest.stream" --tests "datadog.trace.api.TagMapTest.compute" --tests "datadog.trace.api.TagMapTest.computeIfAbsent" --tests "datadog.trace.api.TagMapTest.computeIfPresent" --tests "datadog.trace.api.EntryReadingHelperTest" passes

🤖 Generated with Claude Code

@dougqh@claude
Add missing coverage tests for OptimizedTagMap and EntryReadingHelper
905fe18
Tests for stream(), compute(), computeIfAbsent(), and computeIfPresent() on
OptimizedTagMap were absent; EntryReadingHelper had no test coverage at all
since LegacyTagMap (its sole caller) was removed.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@dd-octo-sts

dd-octo-stsBot commented Jun 29, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

SuiteStatus
Startup🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
ScenarioCandidatemasterΔ (95% CI of mean)
startup:insecure-bank:iast:Agent14.00 s13.99 s[-0.6%; +0.8%] (no difference)
startup:insecure-bank:tracing:Agent12.93 s12.97 s[-1.0%; +0.3%] (no difference)
startup:petclinic:appsec:Agent16.80 s15.91 s[+1.5%; +9.8%] (significantly worse)
startup:petclinic:iast:Agent16.81 s16.91 s[-1.6%; +0.4%] (no difference)
startup:petclinic:profiling:Agent16.83 s16.35 s[-1.7%; +7.5%] (no difference)
startup:petclinic:sca:Agent16.76 s16.65 s[-0.3%; +1.6%] (no difference)
startup:petclinic:tracing:Agent16.00 s15.98 s[-0.9%; +1.2%] (no difference)

Commit:f299fc3f · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@dougqhdougqh added type: feature Enhancements and improvements tag: flaky test Flaky tests comp: core Tracer core labels Jun 29, 2026
@dougqh
dougqh marked this pull request as ready for review June 29, 2026 15:20
@dougqh
dougqh requested a review from a team as a code ownerJune 29, 2026 15:20
@dougqh
dougqh added this pull request to the merge queueJun 29, 2026
@dd-octo-sts

dd-octo-stsBot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Jun 29, 2026•
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-29 16:24:47 UTC ℹ️ Start processing command /merge

2026-06-29 16:24:52 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-06-29 17:26:12 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jun 29, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit 6fd35b5 into masterJun 29, 2026
583 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the dougqh/tagmap-coverage-fix branch June 29, 2026 17:26
@github-actionsgithub-actionsBot added this to the 1.64.0 milestone Jun 29, 2026
TophrC-dd pushed a commit that referenced this pull request Jun 29, 2026
@dougqhdevflow.devflow-routing-intake@TophrC-dd
Add missing coverage tests for OptimizedTagMap and EntryReadingHelper (…
f2ccbf7
…#11778)
Add missing coverage tests for OptimizedTagMap and EntryReadingHelper
Tests for stream(), compute(), computeIfAbsent(), and computeIfPresent() on
OptimizedTagMap were absent; EntryReadingHelper had no test coverage at all
since LegacyTagMap (its sole caller) was removed.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Merge branch 'master' into dougqh/tagmap-coverage-fix
Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
@bric3bric3 mentioned this pull request Jun 30, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3bric3bric3 approved these changes
@PerfectSlayerPerfectSlayerAwaiting requested review from PerfectSlayerPerfectSlayer was automatically assigned from DataDog/dd-trace-java-admin

Assignees

No one assigned

Labels

comp: coreTracer coretag: flaky testFlaky teststype: featureEnhancements and improvements

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dougqh@bric3