Skip to content

Add missing coverage tests for Hashtable.D2 - #11779

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
dougqh/hashtable-d2-coverage-fix
Jun 29, 2026
Merged

Add missing coverage tests for Hashtable.D2#11779
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
dougqh/hashtable-d2-coverage-fix

Conversation

@dougqh

@dougqhdougqh commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

What This Does

Improves coverage of Hashtable

Motivation

Better test coverage

Additional Notes

  • Add removeReturnsNullForMissingKeyremove() was only tested for the found case; the null-return path was uncovered
  • Add clearEmptiesTableclear() had no test at all

Test plan

  • ./gradlew :internal-api:test --tests "datadog.trace.util.HashtableD2Test" passes

🤖 Generated with Claude Code

clear() had no test; remove() had no test for the not-found (null return) case.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@dd-octo-sts

dd-octo-stsBot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

SuiteStatus
Startup🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
ScenarioCandidatemasterΔ (95% CI of mean)
startup:insecure-bank:iast:Agent13.92 s14.02 s[-1.6%; +0.1%] (no difference)
startup:insecure-bank:tracing:Agent12.99 s13.06 s[-1.5%; +0.4%] (no difference)
startup:petclinic:appsec:Agent16.91 s16.87 s[-0.5%; +1.0%] (no difference)
startup:petclinic:iast:Agent16.89 s16.93 s[-1.0%; +0.6%] (no difference)
startup:petclinic:profiling:Agent16.89 s17.04 s[-1.9%; +0.1%] (no difference)
startup:petclinic:sca:Agent17.00 s16.79 s[+0.3%; +2.1%] (maybe worse)
startup:petclinic:tracing:Agent16.03 s15.61 s[-1.6%; +7.0%] (no difference)

Commit:0c207443 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@dougqhdougqh added tag: flaky test Flaky tests type: feature Enhancements and improvements comp: core Tracer core labels Jun 29, 2026
@dougqh
dougqh marked this pull request as ready for review June 29, 2026 15:23
@dougqh
dougqh requested a review from a team as a code ownerJune 29, 2026 15:23
@dd-octo-stsdd-octo-stsBot added the tag: ai generated Largely based on code generated by an AI or LLM label Jun 29, 2026
@dougqh
dougqh added this pull request to the merge queueJun 29, 2026
@dd-octo-sts

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Jun 29, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-29 16:24:24 UTC ℹ️ Start processing command /merge


2026-06-29 16:24:29 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-29 17:25:29 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jun 29, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit 810268d into masterJun 29, 2026
586 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the dougqh/hashtable-d2-coverage-fix branch June 29, 2026 17:25
@github-actionsgithub-actionsBot added this to the 1.64.0 milestone Jun 29, 2026
TophrC-dd pushed a commit that referenced this pull request Jun 29, 2026
Add missing coverage tests for Hashtable.D2
clear() had no test; remove() had no test for the not-found (null return) case.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Merge branch 'master' into dougqh/hashtable-d2-coverage-fix
Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: coreTracer coretag: ai generatedLargely based on code generated by an AI or LLMtag: flaky testFlaky teststype: featureEnhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dougqh@bric3