Uh oh!
There was an error while loading. Please reload this page.
Add missing coverage tests for Matchers.AnyMatcher primitive overloads - #11780
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intoJun 29, 2026
Merged
Conversation
The existing parameterized tests always dispatch through matches(Object), leaving the 9 primitive overloads uncovered. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
dougqh
marked this pull request as ready for review
June 29, 2026 15:28
mcculls
approved these changes
Jun 29, 2026
dougqh
enabled auto-merge
June 29, 2026 15:36
bric3
approved these changes
Jun 29, 2026
Contributor
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Jun 29, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gh-worker-dd-mergequeue-cf854dBot
deleted the
dougqh/matchers-anymatcher-coverage-fix
branch
June 29, 2026 17:16
TophrC-dd pushed a commit
that referenced
this pull request
Jun 29, 2026
#11780) Add missing coverage tests for Matchers.AnyMatcher primitive overloads The existing parameterized tests always dispatch through matches(Object), leaving the 9 primitive overloads uncovered. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Split AnyMatcher overload tests into individual test cases Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Merge branch 'master' into dougqh/matchers-anymatcher-coverage-fix Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds coverage to AnyMatcher for primitive types
Motivation
Increase test coverage
Additional Notes
The existing parameterized tests in
MatchersTestalways dispatch throughmatches(Object), leaving the 9 primitive overloads onAnyMatcher(boolean,byte,short,int,long,float,double,BigInteger,BigDecimal) at 0% coverage.Adds
anyMatcherMatchesAllPrimitiveOverloadswhich calls each overload directly viaMatchers.ANY.Test plan
./gradlew :dd-trace-core:test --tests "datadog.trace.core.util.MatchersTest"passes🤖 Generated with Claude Code