Skip to content

Test explicit histogram boundaries and per-thread recordings - #11783

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
mcculls/fix-metrics-coverage
Jun 29, 2026
Merged

Test explicit histogram boundaries and per-thread recordings#11783
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
mcculls/fix-metrics-coverage

Conversation

@mcculls

Copy link
Copy Markdown
Contributor

Motivation

Get ./gradlew :products:metrics:metrics-lib:check to pass locally

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@mcculls
mcculls requested a review from a team as a code ownerJune 29, 2026 15:44
@mcculls
mcculls requested a review from amarzialiJune 29, 2026 15:44
@mccullsmcculls added comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring labels Jun 29, 2026
@dd-octo-sts

Copy link
Copy Markdown
Contributor

🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)

SuiteStatus
Startup🟡 warning

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
ScenarioCandidatemasterΔ (95% CI of mean)
startup:insecure-bank:iast:Agent14.74 s14.71 s[-0.7%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent13.58 s13.70 s[-1.6%; -0.2%] (maybe better)
startup:petclinic:appsec:Agent17.46 s17.14 s[+0.5%; +3.2%] (maybe worse)
startup:petclinic:iast:Agent17.53 s17.57 s[-1.2%; +0.8%] (no difference)
startup:petclinic:profiling:Agent17.45 s17.55 s[-1.7%; +0.5%] (no difference)
startup:petclinic:sca:Agent17.60 s16.94 s[-0.6%; +8.4%] (no difference)
startup:petclinic:tracing:Agent16.49 s16.68 s[-2.3%; -0.0%] (maybe better)

Commit:bc9c49d1 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@amarzialiamarziali left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mcculls
mcculls added this pull request to the merge queueJun 29, 2026
@dd-octo-sts

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Jun 29, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-29 16:49:06 UTC ℹ️ Start processing command /merge


2026-06-29 16:49:11 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-29 17:49:57 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jun 29, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit a8e41c5 into masterJun 29, 2026
585 of 592 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the mcculls/fix-metrics-coverage branch June 29, 2026 17:49
@github-actionsgithub-actionsBot added this to the 1.64.0 milestone Jun 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testingTestingtag: no release notesChanges to exclude from release notestype: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls@amarziali