Skip to content

Add LLMObsContextTest - #11792

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/fix-LLMObsContext-coverage
Jun 30, 2026
Merged

Add LLMObsContextTest#11792
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/fix-LLMObsContext-coverage

Conversation

@mcculls

Copy link
Copy Markdown
Contributor

Motivation

Meet expected test coverage.

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@mcculls
mcculls requested a review from a team as a code ownerJune 29, 2026 20:43
@mcculls
mcculls requested a review from amarzialiJune 29, 2026 20:43
@mccullsmcculls added comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring labels Jun 29, 2026
@dd-octo-sts

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

SuiteStatus
Startup🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
ScenarioCandidatemasterΔ (95% CI of mean)
startup:insecure-bank:iast:Agent13.99 s14.00 s[-0.9%; +0.8%] (no difference)
startup:insecure-bank:tracing:Agent13.00 s13.09 s[-1.3%; -0.0%] (maybe better)
startup:petclinic:appsec:Agent16.96 s16.70 s[+0.5%; +2.6%] (maybe worse)
startup:petclinic:iast:Agent16.89 s16.92 s[-1.1%; +0.7%] (no difference)
startup:petclinic:profiling:Agent16.82 s16.81 s[-0.7%; +0.9%] (no difference)
startup:petclinic:sca:Agent16.25 s16.74 s[-7.5%; +1.6%] (no difference)
startup:petclinic:tracing:Agent16.00 s15.55 s[-1.5%; +7.2%] (no difference)

Commit:fb276bab · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much the context API, but looking the test looks ok to me.

@mcculls
mcculls enabled auto-merge June 29, 2026 21:24
@mcculls
mcculls disabled auto-merge June 29, 2026 23:44
@mcculls
mcculls enabled auto-merge June 29, 2026 23:44
@mccullsmcculls added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Jun 29, 2026
@mcculls
mcculls added this pull request to the merge queueJun 29, 2026
@dd-octo-sts

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Jun 29, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-29 23:45:54 UTC ℹ️ Start processing command /merge


2026-06-29 23:46:00 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-06-30 00:48:25 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jun 29, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit 750f363 into masterJun 30, 2026
588 of 594 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the mcculls/fix-LLMObsContext-coverage branch June 30, 2026 00:48
@github-actionsgithub-actionsBot added this to the 1.64.0 milestone Jun 30, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testingTestingtag: no release notesChanges to exclude from release notestype: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls@bric3@amarziali