Skip to content

Add direct coverage tests for Hashtable.D2.Entry - #11794

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
dougqh/coverage-fix-d2-entry
Jun 30, 2026
Merged

Add direct coverage tests for Hashtable.D2.Entry#11794
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
dougqh/coverage-fix-d2-entry

Conversation

@dougqh

@dougqhdougqh commented Jun 29, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

What This Does

  • Adds direct tests for D2.Entry.matches() (true and false branches) and D2.Entry.hash() to HashtableD2Test
  • The existing D2 operation tests call matches() indirectly, but the false branch is not guaranteed to fire since different key pairs typically hash to different buckets

Motivation

Code coverage

tag: no release note
tag: ai generated

🤖 Generated with Claude Code

@dougqh@claude
Add direct coverage tests for Hashtable.D2.Entry
efd1054
Tests matches() with both true and false branches, and hash() for
consistency and key-sensitivity, since existing D2 operation tests
don't guarantee the false branch fires (different key pairs hash
to different buckets, so matches() is never called with a mismatch).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@dougqhdougqh added tag: flaky test Flaky tests type: feature Enhancements and improvements comp: core Tracer core labels Jun 29, 2026
@dougqh
dougqh marked this pull request as ready for review June 29, 2026 21:31
@dougqh
dougqh requested a review from a team as a code ownerJune 29, 2026 21:31
@dougqh
dougqh requested a review from mccullsJune 29, 2026 21:31
@dd-octo-stsdd-octo-stsBot added the tag: ai generated Largely based on code generated by an AI or LLM label Jun 29, 2026
@dd-octo-sts

dd-octo-stsBot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)

SuiteStatus
Startup🟡 warning

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
ScenarioCandidatemasterΔ (95% CI of mean)
startup:insecure-bank:iast:Agent14.77 s14.71 s[-0.7%; +1.5%] (no difference)
startup:insecure-bank:tracing:Agent13.70 s13.77 s[-1.6%; +0.6%] (no difference)
startup:petclinic:appsec:Agent17.44 s17.02 s[+1.4%; +3.6%] (significantly worse)
startup:petclinic:iast:Agent17.43 s17.54 s[-1.5%; +0.2%] (no difference)
startup:petclinic:profiling:Agent17.49 s17.36 s[-0.3%; +1.7%] (no difference)
startup:petclinic:sca:Agent17.58 s17.52 s[-0.6%; +1.2%] (no difference)
startup:petclinic:tracing:Agent16.48 s16.07 s[-3.0%; +8.1%] (unstable)

Commit:efd1054a · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3
bric3 added this pull request to the merge queueJun 30, 2026
@dd-octo-sts

dd-octo-stsBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-30 09:14:03 UTC ℹ️ Start processing command /merge

2026-06-30 09:14:08 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).

2026-06-30 10:14:56 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jun 30, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit e280daf into masterJun 30, 2026
594 of 603 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the dougqh/coverage-fix-d2-entry branch June 30, 2026 10:14
@github-actionsgithub-actionsBot added this to the 1.64.0 milestone Jun 30, 2026
@bric3bric3 mentioned this pull request Jun 30, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mccullsmccullsmcculls approved these changes
@bric3bric3bric3 approved these changes

Assignees

No one assigned

Labels

comp: coreTracer coretag: ai generatedLargely based on code generated by an AI or LLMtag: flaky testFlaky teststype: featureEnhancements and improvements

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dougqh@mcculls@bric3