Uh oh!
There was an error while loading. Please reload this page.
Exclude OptimizedTagMap.EmptyHolder from coverage checks - #11795
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intoJun 30, 2026
Conversation
Tests matches() with both true and false branches, and hash() for consistency and key-sensitivity, since existing D2 operation tests don't guarantee the false branch fires (different key pairs hash to different buckets, so matches() is never called with a mismatch). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
EmptyHolder is a lazy-holder idiom class used to avoid class-init ordering issues between TagMap and OptimizedTagMap. It has no methods of its own and is exercised indirectly via TagMap.EMPTY, but JaCoCo tracks it as a separate class with its own coverage thresholds. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dougqh
marked this pull request as ready for review
June 29, 2026 21:33
bric3
approved these changes
Jun 29, 2026
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Contributor
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Jun 30, 2026
Uh oh!
There was an error while loading. Please reload this page.
gh-worker-dd-mergequeue-cf854dBot
merged commit Jun 30, 2026
29d82dd
into
master
589 of 606 checks passed
Uh oh!
There was an error while loading. Please reload this page.
gh-worker-dd-mergequeue-cf854dBot
deleted the
dougqh/coverage-fix-emptyholder
branch
June 30, 2026 09:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds
OptimizedTagMap.EmptyHolderto the coverage exclusion list ininternal-api/build.gradle.ktsMotivation
EmptyHolderis a lazy-holder idiom class (no methods, just a static initializer) used to avoid class-init ordering issues betweenTagMapandOptimizedTagMap; it is exercised indirectly viaTagMap.EMPTYbut JaCoCo tracks it as a separate classAdditional Notes
🤖 Generated with Claude Code