Skip to content

Add ProtocolVersion tests and exclude specific classes from coverage - #11801

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
bdu/api-coverage
Jun 30, 2026
Merged

Add ProtocolVersion tests and exclude specific classes from coverage#11801
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
bdu/api-coverage

Conversation

@bric3

Copy link
Copy Markdown
Contributor

What Does This Do

  • This pull request adds tests for 128-bit trace IDs and updates protocol version handling.
  • It also updates the coverage configuration to exclude the AIGuard and LLMObs classes.

Motivation

Additional Notes

N/A

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@bric3
bric3 requested a review from a team as a code ownerJune 30, 2026 09:41
@bric3
bric3 requested a review from amarzialiJune 30, 2026 09:41
@bric3bric3 added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 30, 2026
@bric3bric3 mentioned this pull request Jun 30, 2026
@bric3bric3 changed the title Add tests for 128-bit trace IDs and exclude specific classes from coverageAdd tests ProtocolVersion and exclude specific classes from coverageJun 30, 2026
@bric3bric3 changed the title Add tests ProtocolVersion and exclude specific classes from coverageAdd ProtocolVersion tests and exclude specific classes from coverageJun 30, 2026
@bric3
bric3 enabled auto-merge June 30, 2026 09:59
@dd-octo-sts

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

SuiteStatus
Startup🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
ScenarioCandidatemasterΔ (95% CI of mean)
startup:insecure-bank:iast:Agent13.98 s13.93 s[-0.5%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent12.91 s13.01 s[-1.5%; -0.0%] (maybe better)
startup:petclinic:appsec:Agent16.81 s16.74 s[-0.8%; +1.6%] (no difference)
startup:petclinic:iast:Agent16.80 s16.91 s[-1.4%; +0.2%] (no difference)
startup:petclinic:profiling:Agent16.59 s16.86 s[-2.6%; -0.7%] (maybe better)
startup:petclinic:sca:Agent16.36 s16.83 s[-7.1%; +1.5%] (no difference)
startup:petclinic:tracing:Agent15.95 s16.16 s[-2.3%; -0.3%] (maybe better)

Commit:4577a43f · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3
bric3 added this pull request to the merge queueJun 30, 2026
@dd-octo-sts

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Jun 30, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-30 10:42:20 UTC ℹ️ Start processing command /merge


2026-06-30 10:42:25 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-06-30 12:09:11 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jun 30, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit ba6d7c6 into masterJun 30, 2026
589 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the bdu/api-coverage branch June 30, 2026 12:09
@github-actionsgithub-actionsBot added this to the 1.64.0 milestone Jun 30, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: toolingBuild & Toolingtag: no release notesChanges to exclude from release notestype: bug fixBug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bric3@PerfectSlayer