Skip to content

Unify usage of OperatingSystem.architecture() - #11816

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
alexeyk/cleanup-arm64-detection
Jul 1, 2026
Merged

Unify usage of OperatingSystem.architecture()#11816
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
alexeyk/cleanup-arm64-detection

Conversation

@AlexeyKuznetsov-DD

@AlexeyKuznetsov-DDAlexeyKuznetsov-DD commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Unifies all call sites to use OperatingSystem.architecture() instead of the statically-imported architecture(), removing the import static datadog.environment.OperatingSystem.architecture imports across the codebase.

Motivation

Addresses PR #11364 review feedback to keep usage of the OperatingSystem utility consistent. Qualifying calls with OperatingSystem.architecture() makes it explicit where the architecture check comes from and avoids ambiguity at the call site.

Additional Notes

  • Pure refactor — no behavioral change.

@AlexeyKuznetsov-DD@claude
Unify usage of OperatingSystem.architecture()
3f9a4f4
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@AlexeyKuznetsov-DDAlexeyKuznetsov-DD self-assigned this Jun 30, 2026
@AlexeyKuznetsov-DDAlexeyKuznetsov-DD added tag: no release notes Changes to exclude from release notes type: refactoring comp: tooling Build & Tooling labels Jun 30, 2026
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review June 30, 2026 20:53
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from a team as code ownersJune 30, 2026 20:53
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from evanchooly, jordan-wong and mhlidd and removed request for a teamJune 30, 2026 20:53
@dd-octo-stsdd-octo-stsBot added the tag: ai generated Largely based on code generated by an AI or LLM label Jun 30, 2026
@AlexeyKuznetsov-DDAlexeyKuznetsov-DD mentioned this pull request Jun 30, 2026
Merged
@datadog-prod-us1-3

This comment has been minimized.

Sign in to view
@dd-octo-sts

dd-octo-stsBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

SuiteStatus
Startup🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
ScenarioCandidatemasterΔ (95% CI of mean)
startup:insecure-bank:iast:Agent14.01 s13.97 s[-0.4%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent12.94 s13.05 s[-1.8%; +0.1%] (no difference)
startup:petclinic:appsec:Agent16.80 s15.96 s[+1.0%; +9.6%] (maybe worse)
startup:petclinic:iast:Agent16.69 s16.80 s[-1.4%; +0.1%] (no difference)
startup:petclinic:profiling:Agent16.79 s16.63 s[-0.1%; +2.1%] (no difference)
startup:petclinic:sca:Agent16.81 s16.58 s[+0.4%; +2.3%] (maybe worse)
startup:petclinic:tracing:Agent15.59 s16.04 s[-6.9%; +1.3%] (no difference)

Commit:3f9a4f46 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@AlexeyKuznetsov-DD

AlexeyKuznetsov-DD commented Jul 1, 2026

Copy link
Copy Markdown
ContributorAuthor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Jul 1, 2026•
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-01 12:45:48 UTC ℹ️ Start processing command /merge

2026-07-01 12:45:53 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).

2026-07-01 13:49:51 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit 466cc7c into masterJul 1, 2026
783 of 791 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the alexeyk/cleanup-arm64-detection branch July 1, 2026 13:49
@github-actionsgithub-actionsBot added this to the 1.64.0 milestone Jul 1, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3bric3bric3 approved these changes
@evanchoolyevanchoolyAwaiting requested review from evanchoolyevanchooly is a code owner automatically assigned from DataDog/debugger-java
@jordan-wongjordan-wongAwaiting requested review from jordan-wongjordan-wong is a code owner automatically assigned from DataDog/apm-idm-java
@mhliddmhliddAwaiting requested review from mhliddmhlidd was automatically assigned from DataDog/dd-trace-java-admin

Assignees

@AlexeyKuznetsov-DDAlexeyKuznetsov-DD

Labels

comp: toolingBuild & Toolingtag: ai generatedLargely based on code generated by an AI or LLMtag: no release notesChanges to exclude from release notestype: refactoring

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexeyKuznetsov-DD@bric3