Skip to content

Disallow AgentTracer.forceRegister(null) - #11942

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/disallow-forceregister-null
Jul 14, 2026
Merged

Disallow AgentTracer.forceRegister(null)#11942
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/disallow-forceregister-null

Conversation

@mcculls

Copy link
Copy Markdown
Contributor

What Does This Do

Disallow AgentTracer.forceRegister(null); callers should pass NOOP_TRACER explicitly instead of null.

Motivation

Helps ensure AgentTracer.get() is never null

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Callers should pass NOOP_TRACER explicitly instead of null.
@mccullsmcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes labels Jul 14, 2026
@mcculls
mcculls requested review from a team as code ownersJuly 14, 2026 09:47
@mcculls
mcculls requested review from jpbempel and mtoffl01 and removed request for a teamJuly 14, 2026 09:47

@datadog-prod-us1-5datadog-prod-us1-5Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

PR tightens the null-safety contract of AgentTracer.forceRegister() by rejecting null with a clear error message, ensuring AgentTracer.get() never returns null. All two existing usages of forceRegister(null) are updated in this diff to pass NOOP_TRACER explicitly; no call sites outside the repository depend on the previous null-accepting behavior.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 5bfb1ae · What is Autotest? · Any feedback? Reach out in #autotest

@datadog-prod-us1-5

This comment has been minimized.

@pr-commenter

Copy link
Copy Markdown

Debugger benchmarks

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
ci_job_date17840228501784023197
end_time2026-07-14T09:55:362026-07-14T10:01:23
git_branchmastermcculls/disallow-forceregister-null
git_commit_sha871f5b65bfb1ae
start_time2026-07-14T09:54:112026-07-14T09:59:58
See matching parameters
BaselineCandidate
ci_job_id18571772221857177222
ci_pipeline_id124489867124489867
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date17840220151784022015

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenarioΔ mean agg_http_req_duration_minΔ mean agg_http_req_duration_p50Δ mean agg_http_req_duration_p75Δ mean agg_http_req_duration_p99Δ mean throughput
scenario:noprobeunstable
[-59.604µs; +24.471µs] or [-19.409%; +7.969%]
unstable
[-72.119µs; +31.625µs] or [-20.434%; +8.960%]
unstable
[-86.298µs; +38.396µs] or [-23.239%; +10.340%]
unstable
[-277.831µs; +426.876µs] or [-20.676%; +31.767%]
same
scenario:basicsamesamesameunstable
[-64.420µs; +225.104µs] or [-5.461%; +19.081%]
unstable
[-113.966op/s; +235.917op/s] or [-4.673%; +9.673%]
scenario:loopsamesamesamesamesame
Request duration reports for reports
gantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (352.941 µs) : 289, 417
. : milestone, 353,
basic (296.101 µs) : 288, 304
. : milestone, 296,
loop (8.987 ms) : 8981, 8994
. : milestone, 8987,
section candidate
noprobe (332.694 µs) : 305, 361
. : milestone, 333,
basic (295.092 µs) : 288, 302
. : milestone, 295,
loop (8.985 ms) : 8981, 8990
. : milestone, 8985,
Loading
  • baseline results
ScenarioRequest median duration [CI 0.99]
noprobe352.941 µs [288.992 µs, 416.89 µs]
basic296.101 µs [287.744 µs, 304.459 µs]
loop8.987 ms [8.981 ms, 8.994 ms]
  • candidate results
ScenarioRequest median duration [CI 0.99]
noprobe332.694 µs [304.882 µs, 360.506 µs]
basic295.092 µs [288.493 µs, 301.691 µs]
loop8.985 ms [8.981 ms, 8.99 ms]

@dd-octo-sts

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

SuiteStatus
Startup🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
ScenarioCandidatemasterΔ (95% CI of mean)
startup:insecure-bank:iast:Agent13.95 s13.98 s[-0.9%; +0.4%] (no difference)
startup:insecure-bank:tracing:Agent12.85 s13.03 s[-2.0%; -0.8%] (maybe better)
startup:petclinic:appsec:Agent16.97 s16.56 s[+1.4%; +3.5%] (significantly worse)
startup:petclinic:iast:Agent16.94 s16.92 s[-0.7%; +0.9%] (no difference)
startup:petclinic:profiling:Agent16.50 s16.92 s[-3.6%; -1.4%] (significantly better)
startup:petclinic:sca:Agent16.98 s16.54 s[+1.7%; +3.6%] (significantly worse)
startup:petclinic:tracing:Agent16.12 s16.04 s[-0.4%; +1.3%] (no difference)

Commit:5bfb1aef · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@mcculls
mcculls enabled auto-merge July 14, 2026 12:13
@mcculls
mcculls added this pull request to the merge queueJul 14, 2026
@dd-octo-sts

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Jul 14, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-14 16:09:46 UTC ℹ️ Start processing command /merge


2026-07-14 16:09:51 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-14 17:15:44 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jul 14, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit 1913e33 into masterJul 14, 2026
603 of 604 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the mcculls/disallow-forceregister-null branch July 14, 2026 17:15
@github-actionsgithub-actionsBot added this to the 1.65.0 milestone Jul 14, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: coreTracer coretag: no release notesChanges to exclude from release notestype: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls@jpbempel