Skip to content

Move perf-review skill to .agents/skills to match repo convention - #11950

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
dougqh/perf-review-skill-dir
Jul 15, 2026
Merged

Move perf-review skill to .agents/skills to match repo convention#11950
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
dougqh/perf-review-skill-dir

Conversation

@dougqh

@dougqhdougqh commented Jul 14, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

What Does This Do

Fixes problem with skill visibility - now under generic agents dir rather than claude specific dir
Symlink-ed under old path for claude

Motivation

Work with both Codex & Claude

Additional Notes

From Claude...

Follow-up to #11912. The perf-review skill landed as real files under .claude/skills/perf-review, but the repo convention is: skills live canonically under .agents/skills/<name>, with .claude/skills/<name> a symlink into them so Claude Code still discovers them. The other five skills (apm-integrations, techdebt, migrate-groovy-to-java, migrate-junit-source-to-tabletest, review-groovy-migration) are all set up this way — perf-review was the outlier.

Change

  • Move .claude/skills/perf-review/ → .agents/skills/perf-review/ (pure move, no content change).
  • Add the compatibility symlink .claude/skills/perf-review → ../../.agents/skills/perf-review, matching the other skills (so Claude Code keeps finding it).
  • Point the AGENTS.md reference at the canonical .agents/skills/perf-review/SKILL.md path.

Addresses the review comment on the merged #11912 ("looks like this landed in the wrong directory").

tag: ai generated
tag: no release note

🤖 Generated with Claude Code

@dougqh@claude
Move perf-review skill to .agents/skills to match repo convention
416ffdd
Skills live canonically under .agents/skills/<name>, with a
.claude/skills/<name> symlink so Claude Code still discovers them.
perf-review (landed in #11912) was the outlier -- stored as real files
under .claude/skills. Move it to .agents/skills/perf-review, add the
compatibility symlink matching the other five skills, and point the
AGENTS.md reference at the canonical path.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@dougqh
dougqh requested a review from a team as a code ownerJuly 14, 2026 20:42
@dougqhdougqh added tag: no release notes Changes to exclude from release notes type: refactoring comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM labels Jul 14, 2026
@dougqh
dougqh requested a review from mccullsJuly 14, 2026 20:42
datadog-official[bot]
datadog-officialBot reviewed Jul 14, 2026
View reviewed changes

@datadog-officialdatadog-officialBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

Pure file-move + symlink PR — files renamed from .claude/skills/perf-review/ to .agents/skills/perf-review/, symlink added matching the exact pattern of all five other skills, and AGENTS.md updated to the canonical path. All five skill files confirm readable via both canonical and symlink paths.

Was this helpful? React 👍 or 👎

📊 Validated against 5 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 416ffdd · What is Autotest? · Any feedback? Reach out in #autotest

@datadog-official

datadog-officialBot commented Jul 14, 2026•
edited by datadog-datadog-us1-prod Bot
Loading

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 57.17% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 416ffdd | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-stsBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

SuiteStatus
Startup🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
ScenarioCandidatemasterΔ (95% CI of mean)
startup:insecure-bank:iast:Agent14.05 s13.91 s[+0.3%; +1.7%] (maybe worse)
startup:insecure-bank:tracing:Agent12.89 s13.11 s[-2.5%; -0.9%] (maybe better)
startup:petclinic:appsec:Agent16.45 s16.28 s[-5.0%; +7.0%] (unstable)
startup:petclinic:iast:Agent16.85 s16.89 s[-1.2%; +0.8%] (no difference)
startup:petclinic:profiling:Agent16.26 s16.84 s[-7.7%; +0.8%] (no difference)
startup:petclinic:sca:Agent16.81 s16.55 s[+0.4%; +2.8%] (maybe worse)
startup:petclinic:tracing:Agent15.61 s16.06 s[-7.0%; +1.2%] (no difference)

Commit:416ffdd0 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@dougqh
dougqh added this pull request to the merge queueJul 14, 2026
@dd-octo-sts

dd-octo-stsBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351Bot commented Jul 14, 2026•
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-14 23:17:32 UTC ℹ️ Start processing command /merge

2026-07-14 23:17:37 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).

2026-07-15 00:35:52 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jul 14, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot merged commit 80d5008 into masterJul 15, 2026
591 of 595 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854dBot deleted the dougqh/perf-review-skill-dir branch July 15, 2026 00:35
@github-actionsgithub-actionsBot added this to the 1.65.0 milestone Jul 15, 2026
mcculls
mcculls reviewed Jul 15, 2026
View reviewed changes

@mccullsmcculls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mccullsmccullsmcculls left review comments
@datadog-officialdatadog-official[bot]datadog-official[bot] left review comments
@bm1549bm1549bm1549 approved these changes

Assignees

No one assigned

Labels

comp: toolingBuild & Toolingtag: ai generatedLargely based on code generated by an AI or LLMtag: no release notesChanges to exclude from release notestype: refactoring

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dougqh@mcculls@bm1549