Skip to content

Improving smoke test capabilities - #12051

Draft
PerfectSlayer wants to merge 6 commits into
masterfrom
bbujon/smoke-tests-tooling
Draft

Improving smoke test capabilities#12051
PerfectSlayer wants to merge 6 commits into
masterfrom
bbujon/smoke-tests-tooling

Conversation

@PerfectSlayer

@PerfectSlayerPerfectSlayer commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

This PR was created to preview the end goal of the task. It is still early work and will be split into reviewable chunks once ready. Check additional notes for the PRs ready to review.

What Does This Do

This PR introduces smoke tests framework based on JUnit.

It provides the following capabilities:

  • Register smoke applications
    • Either web server application or CLI application
    • Can be extended to new kind of applications too
    • Lifecycle handled as part of the JUnit engine
    • Registered for parameter resolution
  • Provide full trace content and structure verification
    • With assert rules and matchers (similar to instrumentation testing)
  • Receive traces from test agent
    • No longer test against our own instrumentation
    • Open to snapshot testing
    • Introduce test agent session support to tracer headers
  • Rely on the existing CI test agent
    • Will run test agent locally if docker engine is found
    • Can run the old mock server as alternative when no docker env is available

Additionally, this PR ports two smoke tests as example:

  • opentelemetry - a basic CLI app
  • spring-boot-rabbit - a complex multiple apps / queues setup
  • dynamic-config - a use case that relies on remote config push and poll

Motivation

Additional Notes

This will make some tests run with the test agent side car and enable trace invariant gate too (check_test_agent_results.sh).

Related pull-requests ready for review:

Contributor Checklist

Jira ticket: APMLP-1247

@PerfectSlayerPerfectSlayer added type: feature Enhancements and improvements comp: testing Testing tag: do not merge Do not merge changes labels Jul 23, 2026
@PerfectSlayer
PerfectSlayerforce-pushed the bbujon/smoke-tests-tooling branch from 29804b8 to 817d668CompareJuly 28, 2026 08:49
@datadog-prod-us1-5

This comment has been minimized.

@PerfectSlayer
PerfectSlayerforce-pushed the bbujon/smoke-tests-tooling branch from 817d668 to c659547CompareJuly 28, 2026 09:11
@dd-octo-sts

dd-octo-stsBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

SuiteStatus
Startup🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
ScenarioCandidatemasterΔ (95% CI of mean)
startup:insecure-bank:iast:Agent14.04 s13.98 s[-0.5%; +1.3%] (no difference)
startup:insecure-bank:tracing:Agent12.91 s12.97 s[-1.3%; +0.4%] (no difference)
startup:petclinic:appsec:Agent16.94 s16.80 s[-0.0%; +1.8%] (no difference)
startup:petclinic:iast:Agent16.92 s16.98 s[-1.0%; +0.3%] (no difference)
startup:petclinic:profiling:Agent16.78 s16.81 s[-1.1%; +0.8%] (no difference)
startup:petclinic:sca:Agent16.69 s16.48 s[+0.3%; +2.2%] (maybe worse)
startup:petclinic:tracing:Agent15.62 s16.01 s[-6.6%; +1.7%] (no difference)

Commit:f0ef1a5f · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@datadog-prod-us1-5

datadog-prod-us1-5Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Bits found no code fix to apply

🟢 Investigated · ⚪ No code fix needed

main / End-to-end #3 / spring-boot-payara 3 fails because five Payara system tests cannot find the expected IAST span tag; the downstream Check system tests success gate only reports that failure. The failure is in an unchanged system-test path and is classified as a flaky test failure, while this PR changes smoke-test tooling and migrations, so no code change was made.


View in Datadog | Reviewed commit e39c84d · Any feedback? Reach out in #deveng-pr-agent

@PerfectSlayer
PerfectSlayerforce-pushed the bbujon/smoke-tests-tooling branch from c659547 to 089af14CompareJuly 29, 2026 06:09
@PerfectSlayer
PerfectSlayerforce-pushed the bbujon/smoke-tests-tooling branch 6 times, most recently from f45d96b to 89f412fCompareAugust 7, 2026 08:13
@PerfectSlayer
PerfectSlayerforce-pushed the bbujon/smoke-tests-tooling branch 2 times, most recently from e39c84d to adca11cCompareAugust 13, 2026 12:33
@PerfectSlayer
PerfectSlayerforce-pushed the bbujon/smoke-tests-tooling branch from adca11c to f0ef1a5CompareAugust 20, 2026 16:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testingTestingtag: do not mergeDo not merge changestype: featureEnhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@PerfectSlayer