Skip to content

🍒 11949 - Fix RUM injection for offset response writes - #12064

Merged
pawelchcki merged 1 commit into
release/v1.64.xfrom
bruce.bujon/backport-pr-11949
Jul 27, 2026
Merged

🍒 11949 - Fix RUM injection for offset response writes#12064
pawelchcki merged 1 commit into
release/v1.64.xfrom
bruce.bujon/backport-pr-11949

Conversation

@PerfectSlayer

@PerfectSlayerPerfectSlayer commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Backport #11949 to release/v1.64.x

@pawelchckidevflow.devflow-routing-intake@PerfectSlayer
Fix RUM injection for offset response writes (#11949)
bed0fd5
Add RUM offset write regression coverage
Fix RUM injection for offset writes
Merge branch 'master' into codex/fix-rum-injection-offset-writes
Preserve boundary-spanning RUM injection matches
Refine RUM injection offset writes
Consolidate Spring Boot WebMVC smoke tests
Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
(cherry picked from commit 8f323b5)
@PerfectSlayerPerfectSlayer added type: bug fix Bug fix tag: ai generated Largely based on code generated by an AI or LLM comp: rum Realtime User Monitoring tag: override groovy enforcement Override the "Enforce Groovy Migration" check labels Jul 24, 2026
@PerfectSlayer
PerfectSlayer requested review from a team as code ownersJuly 24, 2026 11:58
@PerfectSlayer
PerfectSlayer requested review from manuel-alvarez-alvarez and vandonr and removed request for a teamJuly 24, 2026 11:58
datadog-datadog-us1-prod[bot]
datadog-datadog-us1-prodBot reviewed Jul 24, 2026
View reviewed changes

@datadog-datadog-us1-proddatadog-datadog-us1-prodBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The offset-write fix preserves response content and injects exactly once across sliced bulk writes, marker-at-end inputs, and markers split across write boundaries. Direct execution of both byte and character implementations matched a reference injector across 20,000 randomized scenarios; the Gradle test task itself could not start because the wrapper distribution download was unavailable.

Was this helpful? React 👍 or 👎

📊 Validated against 20000 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit bed0fd5 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-datadog-us1-prod

This comment has been minimized.

Sign in to view
@dd-octo-sts

dd-octo-stsBot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

SuiteStatus
Startup🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
ScenarioCandidatemasterΔ (95% CI of mean)
startup:insecure-bank:iast:Agent13.99 s13.86 s[+0.3%; +1.6%] (maybe worse)
startup:insecure-bank:tracing:Agent12.97 s13.00 s[-1.0%; +0.6%] (no difference)
startup:petclinic:appsec:Agent17.00 s16.91 s[-0.3%; +1.4%] (no difference)
startup:petclinic:iast:Agent16.94 s16.98 s[-1.0%; +0.5%] (no difference)
startup:petclinic:profiling:Agent16.70 s16.81 s[-1.8%; +0.5%] (no difference)
startup:petclinic:sca:Agent16.95 s16.81 s[-0.1%; +1.8%] (no difference)
startup:petclinic:tracing:Agent15.66 s16.15 s[-7.2%; +1.1%] (no difference)

Commit:bed0fd59 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@pawelchcki

pawelchcki commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

thanks @PerfectSlayer

@pawelchcki
pawelchcki enabled auto-merge (squash) July 24, 2026 22:57
@PerfectSlayerPerfectSlayer added tag: override groovy enforcement Override the "Enforce Groovy Migration" check and removed tag: override groovy enforcement Override the "Enforce Groovy Migration" check labels Jul 27, 2026
@pawelchcki
pawelchcki merged commit 9f82727 into release/v1.64.xJul 27, 2026
588 of 596 checks passed
@pawelchcki
pawelchcki deleted the bruce.bujon/backport-pr-11949 branch July 27, 2026 07:19
@github-actionsgithub-actionsBot added this to the 1.64.2 milestone Jul 27, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datadog-datadog-us1-proddatadog-datadog-us1-prod[bot]datadog-datadog-us1-prod[bot] left review comments
@pawelchckipawelchckipawelchcki approved these changes
@vandonrvandonrAwaiting requested review from vandonrvandonr is a code owner automatically assigned from DataDog/apm-idm-java
@manuel-alvarez-alvarezmanuel-alvarez-alvarezAwaiting requested review from manuel-alvarez-alvarezmanuel-alvarez-alvarez is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: rumRealtime User Monitoringtag: ai generatedLargely based on code generated by an AI or LLMtag: override groovy enforcementOverride the "Enforce Groovy Migration" checktype: bug fixBug fix

Projects

None yet

Milestone

1.64.2

Development

Successfully merging this pull request may close these issues.

2 participants

@PerfectSlayer@pawelchcki