Skip to content

JAX-WS WebService and WebServiceProvider instrumentation - #2473

Merged
mcculls merged 1 commit into
masterfrom
mcculls/jax-ws
Mar 10, 2021
Merged

JAX-WS WebService and WebServiceProvider instrumentation#2473
mcculls merged 1 commit into
masterfrom
mcculls/jax-ws

Conversation

@mcculls

@mccullsmcculls commented Mar 8, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Instruments endpoints annotated with @WebService (JAX-WS 1.x) and @WebServiceProvider (JAX-WS 2.x)

This support is turned off by default, but can be enabled with -Ddd.integration.jax-ws.enabled=true or by setting

DD_INTEGRATION_JAX_WS_ENABLED=true

@mccullsmcculls added the inst: others All other instrumentations label Mar 8, 2021
@mcculls
mcculls requested a review from a team as a code ownerMarch 8, 2021 22:42
@richardstartin

richardstartin commented Mar 9, 2021

Copy link
Copy Markdown
Contributor

Given the complexity of the matching, and SOAP being a relatively rare format these days, I think the quickest path to getting this merged without impacting non-SOAP users would be to disable this by default and have SOAP users opt in.

tylerbenson
tylerbenson approved these changes Mar 9, 2021
View reviewed changes

@tylerbensontylerbenson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You can combine the instrumentation if you want or leave separate. (I'm ok either way.)

Comment threaddd-java-agent/instrumentation/jax-ws-annotations-1/jax-ws-annotations-1.gradle
Comment threaddd-java-agent/instrumentation/jax-ws-annotations-2/jax-ws-annotations-2.gradle
Comment thread...otations-1/src/main/java/datadog/trace/instrumentation/jaxws1/WebServiceInstrumentation.java
@mcculls
mcculls merged commit 1bc3d70 into masterMar 10, 2021
@mcculls
mcculls deleted the mcculls/jax-ws branch March 10, 2021 10:34
@github-actionsgithub-actionsBot added this to the 0.76.0 milestone Mar 10, 2021
This was referenced Mar 11, 2021
Closed
Closed
@andrewsouthard1andrewsouthard1 mentioned this pull request Jul 19, 2021
Merged
@jordan-wongjordan-wong mentioned this pull request Oct 30, 2024
Merged
5 tasks
@bm1549bm1549 mentioned this pull request Jun 25, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bantonssonbantonssonbantonsson approved these changes
+2 more reviewers
@richardstartinrichardstartinrichardstartin approved these changes
@tylerbensontylerbensontylerbenson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

inst: othersAll other instrumentations

Projects

None yet

Milestone

0.76.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mcculls@richardstartin@tylerbenson@bantonsson