Skip to content

String builder taint tracking - #3904

Merged
smola merged 1 commit into
masterfrom
malvarez/string-builder-taint-tracking
Nov 16, 2022
Merged

String builder taint tracking#3904
smola merged 1 commit into
masterfrom
malvarez/string-builder-taint-tracking

Conversation

@manuel-alvarez-alvarez

@manuel-alvarez-alvarezmanuel-alvarez-alvarez commented Sep 27, 2022

Copy link
Copy Markdown
Member

What Does This Do

Adds all the instrumentation needed to perform taint tacking in the tracer for common string operations.

Motivation

IAST requires to track all modifications that happen to strings in the code, this PR uses CSI to instrument the most common string operations.

Additional Notes

Future PR will complete the support with other operations and classes

@smolasmola added the comp: asm iast Application Security Management (IAST) label Sep 27, 2022
@manuel-alvarez-alvarezmanuel-alvarez-alvarez added the tag: no release notes Changes to exclude from release notes label Sep 27, 2022
@manuel-alvarez-alvarezmanuel-alvarez-alvarez changed the title Malvarez/string builder taint trackingString builder taint trackingSep 28, 2022
@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/string-builder-taint-tracking branch 4 times, most recently from 8ef9993 to be1472aCompareSeptember 30, 2022 15:31
@manuel-alvarez-alvarezmanuel-alvarez-alvarez added the tag: do not merge Do not merge changes label Oct 3, 2022
@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/string-builder-taint-tracking branch 6 times, most recently from 13140d4 to 74191bdCompareOctober 6, 2022 10:55
@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/string-builder-taint-tracking branch from 74191bd to 5fd71b3CompareOctober 10, 2022 09:39
@manuel-alvarez-alvarez
manuel-alvarez-alvarez marked this pull request as ready for review October 10, 2022 09:43
@manuel-alvarez-alvarez
manuel-alvarez-alvarez requested a review from a teamOctober 10, 2022 09:43
@manuel-alvarez-alvarez
manuel-alvarez-alvarez requested a review from a team as a code ownerOctober 10, 2022 09:43
@manuel-alvarez-alvarezmanuel-alvarez-alvarez removed the tag: do not merge Do not merge changes label Oct 10, 2022
@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/string-builder-taint-tracking branch 2 times, most recently from cda5a8a to 4c87cbcCompareOctober 10, 2022 11:38
@jandro996

jandro996 commented Oct 11, 2022

Copy link
Copy Markdown
Member

Maybe we must discuss if we have to instrument this methods that are not available in this PR

append(char[])

append(char[] str, int offset, int len)

append(CharSequence s, int start, int end)

@manuel-alvarez-alvarez

Copy link
Copy Markdown
MemberAuthor

Maybe we must discuss if we have to instrument this methods that are not available in this PR

append(char[])

append(char[] str, int offset, int len)

append(CharSequence s, int start, int end)

Yep we should create new JIRAS for them.

@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/string-builder-taint-tracking branch from 4c87cbc to 542efb2CompareOctober 11, 2022 10:37
@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/string-builder-taint-tracking branch 3 times, most recently from 73668b4 to 96a496aCompareOctober 18, 2022 08:08
@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/string-builder-taint-tracking branch 2 times, most recently from 42cede2 to bae3cacCompareOctober 21, 2022 08:17
@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/string-builder-taint-tracking branch 4 times, most recently from 7e80c3e to 376bc40CompareOctober 31, 2022 15:21
@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/string-builder-taint-tracking branch from 376bc40 to 314c928CompareNovember 9, 2022 16:44
Comment threaddd-java-agent/agent-iast/README.MD Outdated
@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/string-builder-taint-tracking branch from 24c275e to b77d278CompareNovember 14, 2022 11:33
@smola
smola merged commit e128595 into masterNov 16, 2022
@smola
smola deleted the malvarez/string-builder-taint-tracking branch November 16, 2022 13:58
@github-actionsgithub-actionsBot added this to the 1.1.0 milestone Nov 16, 2022
@bantonssonbantonsson modified the milestones: 1.0.1, 1.1.0Nov 17, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: asm iastApplication Security Management (IAST)tag: no release notesChanges to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@manuel-alvarez-alvarez@jandro996@smola@DDJavierSantos@bantonsson