Skip to content

[testing]Lib injection and system-tests integration - #4194

Merged
robertomonteromiguel merged 103 commits into
masterfrom
robertomonteromiguel/lib_injection_system_tests_integration
Dec 22, 2022
Merged

[testing]Lib injection and system-tests integration#4194
robertomonteromiguel merged 103 commits into
masterfrom
robertomonteromiguel/lib_injection_system_tests_integration

Conversation

@robertomonteromiguel

Copy link
Copy Markdown
Contributor

What Does This Do

Remove lib injection scripts and move them to system-tests repository. When a branch is built we will clone system-tests repository and launch the lib injeciton tests

Motivation

Create system-tests ecosystem centralized on system-tests repository

Additional Notes

Remove lib injection scripts and move them to system-tests repository.
When a branch is built we will clone system-tests repository and launch the
lib injeciton tests
@robertomonteromiguel
robertomonteromiguel requested a review from a team as a code ownerNovember 9, 2022 10:47
@robertomonteromiguel
robertomonteromiguel marked this pull request as draft November 9, 2022 10:47
@robertomonteromiguel
robertomonteromiguel removed the request for review from a teamNovember 9, 2022 10:47
Comment thread.github/workflows/lib-injection.yaml Outdated
DOCKER_IMAGE_NAME_WITH_TAG=$(echo ${DOCKER_IMAGE_NAME}:${{ github.sha }} | tr '[:upper:]' '[:lower:]')

#If we are building main branch, we also tag as latest_snapshot
if [ $(echo ${GITHUB_HEAD_REF-${GITHUB_REF#refs/heads/}} | tr / -) == 'robertomonteromiguel-lib_injection_system_tests_integration' ]; then

@robertomonteromiguelrobertomonteromiguelDec 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to master before merge

@robertomonteromiguel
robertomonteromiguel merged commit 29095dc into masterDec 22, 2022
@robertomonteromiguel
robertomonteromiguel deleted the robertomonteromiguel/lib_injection_system_tests_integration branch December 22, 2022 09:20
@github-actionsgithub-actionsBot added this to the 1.4.0 milestone Dec 22, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testingTestingtag: no release notesChanges to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@robertomonteromiguel@smola@devinsba