Skip to content

Do not add the _dd.p.dm tag for spans selected by SSS#4682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ygree merged 1 commit into from
Feb 7, 2023
Merged

Do not add the _dd.p.dm tag for spans selected by SSS #4682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dd-trace-core/src/main/java/datadog/trace/core/DDSpanContext.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -392,8 +392,6 @@ public void setSpanSamplingPriority(double rate, int limit) {
if (limit != Integer.MAX_VALUE) {
unsafeSetTag(SPAN_SAMPLING_MAX_PER_SECOND_TAG, limit);
}
propagationTags.updateTraceSamplingPriority(
PrioritySampling.USER_KEEP, SamplingMechanism.SPAN_SAMPLING_RATE);
isSelectedBySingleSpanSampling = true;
}
}
Expand Down
3 changes: 2 additions & 1 deletion dd-trace-core/src/test/groovy/datadog/trace/core/DDSpanContextTest.groovy
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -229,7 +229,8 @@ class DDSpanContextTest extends DDCoreSpecification {
// single span sampling should not change the trace sampling priority
context.getSamplingPriority() == UNSET
context.effectiveSamplingPriority == USER_KEEP
context.getPropagationTags().createTagMap() == ["_dd.p.dm":"-" + SPAN_SAMPLING_RATE]
// make sure the `_dd.p.dm` tag has not been set by single span sampling
context.getPropagationTags().createTagMap() == [:]

where:
rate | limit
Expand Down