Uh oh!
There was an error while loading. Please reload this page.
Run tests on Java 11 - #480
Conversation
tylerbenson
commented
Sep 7, 2018
@realark Looks like we have some work to do to get that ready. |
96ae43f to
14dc87aCompare0f528a2 to
17c2336CompareThere was a problem hiding this comment.
is this the correct change or should this be .asTerminalTransformation()?
There was a problem hiding this comment.
No, that would imply that no other transformers could apply. He basically inverted the meaning, so we want the default now.
There was a problem hiding this comment.
I do not think this is correct - you probably do not want this excluded for 9+.
Also - I have a parallel PR I'm working on which rewrites this part heavily. I would prefer if you could just add 11-th version by just copy-pasting version 10 without this refactoring for now. It will be refactored in that PR (#522). This is just to avoid too many conflicts that would be hard to resolve.
There was a problem hiding this comment.
Good point. I forgot about that distinction.
I think that would still have conflicts. I'll just fix this bug, but then we can resolve the conflict by just using your whole file. Yours should cover everything anyway.
There was a problem hiding this comment.
It would be nice to check if zulu provides this already. Also early_access seems wrong - if we are to get this from java.net we may get GA version.
7013995 to
d308b87Compared308b87 to
335af8cCompare
No description provided.