Skip to content

Add utilities to simplify IAST smoke testing - #5234

Merged
manuel-alvarez-alvarez merged 1 commit into
masterfrom
malvarez/iast-improve-smoke-test
May 24, 2023
Merged

Add utilities to simplify IAST smoke testing#5234
manuel-alvarez-alvarez merged 1 commit into
masterfrom
malvarez/iast-improve-smoke-test

Conversation

@manuel-alvarez-alvarez

Copy link
Copy Markdown
Member

What Does This Do

Updates IAST smoke tests to reuse logic in common base class

Motivation

Additional Notes

@manuel-alvarez-alvarezmanuel-alvarez-alvarez added tag: no release notes Changes to exclude from release notes comp: asm iast Application Security Management (IAST) labels May 18, 2023
@manuel-alvarez-alvarez
manuel-alvarez-alvarez requested a review from a teamMay 18, 2023 10:51
@manuel-alvarez-alvarez
manuel-alvarez-alvarez requested a review from a team as a code ownerMay 18, 2023 10:51
@pr-commenter

pr-commenterBot commented May 18, 2023

Copy link
Copy Markdown

Benchmarks

Parameters

BaselineCandidate
commit1.15.0-SNAPSHOT~40c941b9251.15.0-SNAPSHOT~6a70c29c92
configbaselinecandidate
See matching parameters
BaselineCandidate
moduleAgentAgent
parentNoneNone

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 20 cases.

scenarioΔ mean execution_time
scenario:Startup-iast-Telemetryworse
[+0.125ms; +0.317ms] or [+2.213%; +5.606%]
scenario:Startup-waf-Telemetryworse
[+0.120ms; +0.234ms] or [+2.352%; +4.585%]
See unchanged results
scenarioΔ mean execution_time
scenario:Startup-base-Agentsame
scenario:Startup-base-Agent.startsame
scenario:Startup-base-BytebuddyAgentsame
scenario:Startup-base-GlobalTracersame
scenario:Startup-base-AppSecsame
scenario:Startup-base-Remote Configsame
scenario:Startup-base-Telemetryunsure
[+0.049ms; +0.244ms] or [+0.858%; +4.311%]
scenario:Startup-iast-Agentsame
scenario:Startup-iast-Agent.startsame
scenario:Startup-iast-BytebuddyAgentsame
scenario:Startup-iast-GlobalTracersame
scenario:Startup-iast-AppSecsame
scenario:Startup-iast-IASTsame
scenario:Startup-iast-Remote Configsame
scenario:Startup-waf-Agentsame
scenario:Startup-waf-Agent.startsame
scenario:Startup-waf-BytebuddyAgentsame
scenario:Startup-waf-GlobalTracersame
scenario:Startup-waf-AppSecsame
scenario:Startup-waf-Remote Configsame

@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/iast-improve-smoke-test branch 2 times, most recently from 4ff7db3 to fb8486cCompareMay 18, 2023 11:28
@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/iast-improve-smoke-test branch from fb8486c to 46502d1CompareMay 18, 2023 14:09
@smolasmola added the comp: testing Testing label May 18, 2023
@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/iast-improve-smoke-test branch 7 times, most recently from 3915b40 to 0f8fce9CompareMay 23, 2023 17:04
@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/iast-improve-smoke-test branch from 0f8fce9 to 6a70c29CompareMay 24, 2023 07:40
@manuel-alvarez-alvarez
manuel-alvarez-alvarez deleted the malvarez/iast-improve-smoke-test branch May 24, 2023 08:24
@github-actionsgithub-actionsBot added this to the 1.15.0 milestone May 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: asm iastApplication Security Management (IAST)comp: testingTestingtag: no release notesChanges to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@manuel-alvarez-alvarez@smola@jandro996