Uh oh!
There was an error while loading. Please reload this page.
Disable embedded Git metadata extraction - #5242
Merged
nikita-tkachenko-datadog merged 1 commit intoMay 22, 2023
Merged
Conversation
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. See unchanged results
|
nikita-tkachenko-datadog
marked this pull request as ready for review
May 22, 2023 10:06
richardstartin
approved these changes
May 22, 2023
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/disable-embedded-git-metadata
branch
May 22, 2023 11:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Disables embedded Git metadata extraction.
Motivation
Component that extracts embedded Git metadata looks for it in
git.propertiesfiles that are available on the classpath.The idea is that customers should configure build system plugins that would add this file to their release artifacts.
The problem is that these files can be found inside 3rd party libraries too, and there is no telling whether a file comes from the customer's jar or from a dependency.
Additional Notes
The feature is disabled temporarily until a long-term solution is agreed upon (most likely the filename will be changed to a non-standard one).