Skip to content

Fix tests related to IAST source values - #6700

Merged
manuel-alvarez-alvarez merged 1 commit into
masterfrom
malvarez/iast-fix-source-values-tests
Feb 19, 2024
Merged

Fix tests related to IAST source values#6700
manuel-alvarez-alvarez merged 1 commit into
masterfrom
malvarez/iast-fix-source-values-tests

Conversation

@manuel-alvarez-alvarez

@manuel-alvarez-alvarezmanuel-alvarez-alvarez commented Feb 19, 2024

Copy link
Copy Markdown
Member

What Does This Do

Fixes source values related tests, IAST now is capable to attach source values when the source is coming from an object. This PR fixes the tests that #6675 broke.

@manuel-alvarez-alvarezmanuel-alvarez-alvarez added tag: flaky test Flaky tests comp: asm iast Application Security Management (IAST) labels Feb 19, 2024
@manuel-alvarez-alvarez
manuel-alvarez-alvarez requested a review from a team as a code ownerFebruary 19, 2024 16:16
@smolasmola added the tag: no release notes Changes to exclude from release notes label Feb 19, 2024
@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/iast-fix-source-values-tests branch from ac4cb05 to 8a34f7aCompareFebruary 19, 2024 16:53
@manuel-alvarez-alvarezmanuel-alvarez-alvarez changed the title Fix tests related to IAST sourcesFix tests related to IAST source valuesFeb 19, 2024
@pr-commenter

pr-commenterBot commented Feb 19, 2024

Copy link
Copy Markdown

Benchmarks

Startup

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
git_branchmastermalvarez/iast-fix-source-values-tests
git_commit_date17083504161708361551
git_commit_sha79327cd8a34f7a9fa
release_version1.31.0-SNAPSHOT~79327cd5f21.31.0-SNAPSHOT~8a34f7a9fa
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17083644471708364447
ci_job_id437504548437504548
ci_pipeline_id2852508928525089
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
moduleAgentAgent
parentNoneNone
variantiastiast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 9 unstable metrics.

Load

Parameters

BaselineCandidate
baseline_or_candidatebaselinecandidate
end_time2024-02-19T17:17:122024-02-19T17:35:47
git_branchmastermalvarez/iast-fix-source-values-tests
git_commit_date17083504161708361551
git_commit_sha79327cd8a34f7a9fa
release_version1.31.0-SNAPSHOT~79327cd5f21.31.0-SNAPSHOT~8a34f7a9fa
start_time2024-02-19T17:16:592024-02-19T17:35:34
See matching parameters
BaselineCandidate
applicationinsecure-bankinsecure-bank
ci_job_date17083644471708364447
ci_job_id437504548437504548
ci_pipeline_id2852508928525089
cpu_modelIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHzIntel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variantiastiast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 14 unstable metrics.

Request duration reports for insecure-bank
gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~8a34f7a9fa, baseline=1.31.0-SNAPSHOT~79327cd5f2
dateFormat X
axisFormat %s
section baseline
no_agent (374.547 µs) : 354, 395
. : milestone, 375,
iast (479.06 µs) : 458, 500
. : milestone, 479,
iast_FULL (542.131 µs) : 521, 563
. : milestone, 542,
iast_GLOBAL (489.521 µs) : 469, 510
. : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (475.926 µs) : 456, 496
. : milestone, 476,
iast_INACTIVE (453.166 µs) : 433, 474
. : milestone, 453,
iast_TELEMETRY_OFF (472.505 µs) : 452, 493
. : milestone, 473,
tracing (445.043 µs) : 425, 465
. : milestone, 445,
section candidate
no_agent (369.036 µs) : 349, 389
. : milestone, 369,
iast (478.951 µs) : 458, 500
. : milestone, 479,
iast_FULL (537.164 µs) : 517, 558
. : milestone, 537,
iast_GLOBAL (508.572 µs) : 487, 530
. : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (474.626 µs) : 454, 495
. : milestone, 475,
iast_INACTIVE (463.045 µs) : 442, 484
. : milestone, 463,
iast_TELEMETRY_OFF (468.581 µs) : 448, 489
. : milestone, 469,
tracing (446.878 µs) : 426, 467
. : milestone, 447,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent374.547 µs [353.957 µs, 395.137 µs]-
iast479.06 µs [458.199 µs, 499.921 µs]104.513 µs (27.9%)
iast_FULL542.131 µs [521.464 µs, 562.799 µs]167.584 µs (44.7%)
iast_GLOBAL489.521 µs [469.33 µs, 509.711 µs]114.974 µs (30.7%)
iast_HARDCODED_SECRET_DISABLED475.926 µs [455.555 µs, 496.297 µs]101.379 µs (27.1%)
iast_INACTIVE453.166 µs [432.69 µs, 473.643 µs]78.619 µs (21.0%)
iast_TELEMETRY_OFF472.505 µs [451.584 µs, 493.427 µs]97.958 µs (26.2%)
tracing445.043 µs [424.888 µs, 465.198 µs]70.496 µs (18.8%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent369.036 µs [348.669 µs, 389.402 µs]-
iast478.951 µs [458.316 µs, 499.586 µs]109.915 µs (29.8%)
iast_FULL537.164 µs [516.705 µs, 557.623 µs]168.129 µs (45.6%)
iast_GLOBAL508.572 µs [487.026 µs, 530.118 µs]139.536 µs (37.8%)
iast_HARDCODED_SECRET_DISABLED474.626 µs [453.801 µs, 495.452 µs]105.591 µs (28.6%)
iast_INACTIVE463.045 µs [442.474 µs, 483.616 µs]94.01 µs (25.5%)
iast_TELEMETRY_OFF468.581 µs [447.864 µs, 489.299 µs]99.546 µs (27.0%)
tracing446.878 µs [426.392 µs, 467.364 µs]77.842 µs (21.1%)
Request duration reports for petclinic
gantt
title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~8a34f7a9fa, baseline=1.31.0-SNAPSHOT~79327cd5f2
dateFormat X
axisFormat %s
section baseline
no_agent (1.366 ms) : 1347, 1385
. : milestone, 1366,
appsec (1.803 ms) : 1779, 1827
. : milestone, 1803,
iast (1.537 ms) : 1514, 1560
. : milestone, 1537,
profiling (1.525 ms) : 1500, 1549
. : milestone, 1525,
tracing (1.488 ms) : 1464, 1512
. : milestone, 1488,
section candidate
no_agent (1.36 ms) : 1341, 1379
. : milestone, 1360,
appsec (1.752 ms) : 1728, 1775
. : milestone, 1752,
iast (1.521 ms) : 1498, 1544
. : milestone, 1521,
profiling (1.516 ms) : 1492, 1541
. : milestone, 1516,
tracing (1.512 ms) : 1489, 1535
. : milestone, 1512,
Loading
  • baseline results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent1.366 ms [1.347 ms, 1.385 ms]-
appsec1.803 ms [1.779 ms, 1.827 ms]437.347 µs (32.0%)
iast1.537 ms [1.514 ms, 1.56 ms]170.692 µs (12.5%)
profiling1.525 ms [1.5 ms, 1.549 ms]158.73 µs (11.6%)
tracing1.488 ms [1.464 ms, 1.512 ms]122.227 µs (8.9%)
  • candidate results
VariantRequest duration [CI 0.99]Δ no_agent
no_agent1.36 ms [1.341 ms, 1.379 ms]-
appsec1.752 ms [1.728 ms, 1.775 ms]391.588 µs (28.8%)
iast1.521 ms [1.498 ms, 1.544 ms]160.873 µs (11.8%)
profiling1.516 ms [1.492 ms, 1.541 ms]156.213 µs (11.5%)
tracing1.512 ms [1.489 ms, 1.535 ms]151.888 µs (11.2%)

@manuel-alvarez-alvarez
manuel-alvarez-alvarezforce-pushed the malvarez/iast-fix-source-values-tests branch from 8a34f7a to c551545CompareFebruary 19, 2024 17:09
@manuel-alvarez-alvarez
manuel-alvarez-alvarez deleted the malvarez/iast-fix-source-values-tests branch February 19, 2024 18:00
@github-actionsgithub-actionsBot added this to the 1.31.0 milestone Feb 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: asm iastApplication Security Management (IAST)tag: flaky testFlaky teststag: no release notesChanges to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@manuel-alvarez-alvarez@smola@mcculls