Preserve `unix:` agent URLs by mcculls · Pull Request #7094 · DataDog/dd-trace-java

mcculls · 2024-05-30T12:43:55Z

What Does This Do

Avoids merging in any additional host/port settings when dealing with unix: URLs.

If the user has configured a unix: agent URL that means they want the tracer to communicate over the given UDS file, in which case we shouldn't then check for any additional agent host or agent port settings, because they won't be applicable. Instead it should just use the default host/port and not rebuild the agent URL.

This does mean that consumers of the agent URL should handle that it might now start with unix: - in practice this only affects one place, SharedCommunicationObjects which now uses a placeholder http://{agent.host}:{agent.port} for unix: URLs. Note this is just to satisfy the OkHttp API, the actual communication will be tunnelled over UDS.

The other updates were to a couple of products still using the raw agent URL - they now use SharedCommunicationObjects / DDAgentFeaturesDiscovery to get the parsed agent URL for use with OkHttp.

Motivation

Merging in additional host/port settings triggers a rebuild of the agent URL in Config, which is misleading because the actual agent URL is the original one that starts with unix:.

pr-commenter · 2024-05-30T13:24:48Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/preserve-unix-agent-urls
git_commit_date	1717061093	1717076899
git_commit_sha	`4b5cad9`	`0964835`
release_version	1.35.0-SNAPSHOT~4b5cad9604	1.35.0-SNAPSHOT~096483556f

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1717082037	1717082037
ci_job_id	527436353	527436353
ci_pipeline_id	35460985	35460985
cpu_model	Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~096483556f, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.58 s) : 0, 1580344
Total [baseline] (11.952 s) : 0, 11951843
Agent [candidate] (1.571 s) : 0, 1571225
Total [candidate] (11.947 s) : 0, 11947383
section iast
Agent [baseline] (1.704 s) : 0, 1703858
Total [baseline] (12.559 s) : 0, 12559282
Agent [candidate] (1.708 s) : 0, 1708491
Total [candidate] (12.557 s) : 0, 12557230
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.71 s) : 0, 1709633
Total [baseline] (12.574 s) : 0, 12574236
Agent [candidate] (1.702 s) : 0, 1702107
Total [candidate] (12.496 s) : 0, 12495569
section iast_TELEMETRY_OFF
Agent [baseline] (1.731 s) : 0, 1731146
Total [baseline] (12.605 s) : 0, 12605087
Agent [candidate] (1.712 s) : 0, 1712103
Total [candidate] (12.578 s) : 0, 12578345

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.58 s	-
Agent	iast	1.704 s	123.513 ms (7.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.71 s	129.288 ms (8.2%)
Agent	iast_TELEMETRY_OFF	1.731 s	150.802 ms (9.5%)
Total	tracing	11.952 s	-
Total	iast	12.559 s	607.439 ms (5.1%)
Total	iast_HARDCODED_SECRET_DISABLED	12.574 s	622.394 ms (5.2%)
Total	iast_TELEMETRY_OFF	12.605 s	653.244 ms (5.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.571 s	-
Agent	iast	1.708 s	137.267 ms (8.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.702 s	130.882 ms (8.3%)
Agent	iast_TELEMETRY_OFF	1.712 s	140.879 ms (9.0%)
Total	tracing	11.947 s	-
Total	iast	12.557 s	609.847 ms (5.1%)
Total	iast_HARDCODED_SECRET_DISABLED	12.496 s	548.186 ms (4.6%)
Total	iast_TELEMETRY_OFF	12.578 s	630.961 ms (5.3%)

gantt
title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~096483556f, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (972.548 ms) : 0, 972548
BytebuddyAgent [candidate] (967.663 ms) : 0, 967663
GlobalTracer [baseline] (464.22 ms) : 0, 464220
GlobalTracer [candidate] (461.332 ms) : 0, 461332
AppSec [baseline] (71.81 ms) : 0, 71810
AppSec [candidate] (70.898 ms) : 0, 70898
Remote Config [baseline] (859.539 µs) : 0, 860
Remote Config [candidate] (836.933 µs) : 0, 837
Telemetry [baseline] (10.12 ms) : 0, 10120
Telemetry [candidate] (9.876 ms) : 0, 9876
section iast
BytebuddyAgent [baseline] (1.145 s) : 0, 1144899
BytebuddyAgent [candidate] (1.146 s) : 0, 1146006
GlobalTracer [baseline] (430.395 ms) : 0, 430395
GlobalTracer [candidate] (431.145 ms) : 0, 431145
AppSec [baseline] (66.653 ms) : 0, 66653
AppSec [candidate] (66.217 ms) : 0, 66217
IAST [baseline] (29.852 ms) : 0, 29852
IAST [candidate] (33.886 ms) : 0, 33886
Remote Config [baseline] (783.939 µs) : 0, 784
Remote Config [candidate] (778.314 µs) : 0, 778
Telemetry [baseline] (11.532 ms) : 0, 11532
Telemetry [candidate] (10.652 ms) : 0, 10652
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.149 s) : 0, 1148994
BytebuddyAgent [candidate] (1.142 s) : 0, 1141630
GlobalTracer [baseline] (430.361 ms) : 0, 430361
GlobalTracer [candidate] (430.259 ms) : 0, 430259
AppSec [baseline] (67.234 ms) : 0, 67234
AppSec [candidate] (67.121 ms) : 0, 67121
IAST [baseline] (30.753 ms) : 0, 30753
IAST [candidate] (32.482 ms) : 0, 32482
Remote Config [baseline] (768.145 µs) : 0, 768
Remote Config [candidate] (792.906 µs) : 0, 793
Telemetry [baseline] (11.611 ms) : 0, 11611
Telemetry [candidate] (10.009 ms) : 0, 10009
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.162 s) : 0, 1161810
BytebuddyAgent [candidate] (1.151 s) : 0, 1150729
GlobalTracer [baseline] (437.194 ms) : 0, 437194
GlobalTracer [candidate] (432.464 ms) : 0, 432464
AppSec [baseline] (69.318 ms) : 0, 69318
AppSec [candidate] (67.763 ms) : 0, 67763
IAST [baseline] (31.014 ms) : 0, 31014
IAST [candidate] (28.015 ms) : 0, 28015
Remote Config [baseline] (785.999 µs) : 0, 786
Remote Config [candidate] (779.928 µs) : 0, 780
Telemetry [baseline] (10.867 ms) : 0, 10867
Telemetry [candidate] (12.35 ms) : 0, 12350

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~096483556f, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.577 s) : 0, 1577282
Total [baseline] (14.237 s) : 0, 14236786
Agent [candidate] (1.573 s) : 0, 1573275
Total [candidate] (14.26 s) : 0, 14260226
section appsec
Agent [baseline] (1.752 s) : 0, 1752058
Total [baseline] (14.496 s) : 0, 14495687
Agent [candidate] (1.754 s) : 0, 1754299
Total [candidate] (14.323 s) : 0, 14322904
section iast
Agent [baseline] (1.714 s) : 0, 1714223
Total [baseline] (14.713 s) : 0, 14712799
Agent [candidate] (1.705 s) : 0, 1705287
Total [candidate] (14.778 s) : 0, 14778038
section profiling
Agent [baseline] (1.881 s) : 0, 1881264
Total [baseline] (14.674 s) : 0, 14673673
Agent [candidate] (1.883 s) : 0, 1882646
Total [candidate] (14.548 s) : 0, 14547629

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.577 s	-
Agent	appsec	1.752 s	174.776 ms (11.1%)
Agent	iast	1.714 s	136.941 ms (8.7%)
Agent	profiling	1.881 s	303.983 ms (19.3%)
Total	tracing	14.237 s	-
Total	appsec	14.496 s	258.901 ms (1.8%)
Total	iast	14.713 s	476.013 ms (3.3%)
Total	profiling	14.674 s	436.887 ms (3.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.573 s	-
Agent	appsec	1.754 s	181.025 ms (11.5%)
Agent	iast	1.705 s	132.013 ms (8.4%)
Agent	profiling	1.883 s	309.371 ms (19.7%)
Total	tracing	14.26 s	-
Total	appsec	14.323 s	62.679 ms (0.4%)
Total	iast	14.778 s	517.812 ms (3.6%)
Total	profiling	14.548 s	287.403 ms (2.0%)

gantt
title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~096483556f, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (971.826 ms) : 0, 971826
BytebuddyAgent [candidate] (969.3 ms) : 0, 969300
GlobalTracer [baseline] (463.058 ms) : 0, 463058
GlobalTracer [candidate] (461.823 ms) : 0, 461823
AppSec [baseline] (71.016 ms) : 0, 71016
AppSec [candidate] (70.785 ms) : 0, 70785
Remote Config [baseline] (840.492 µs) : 0, 840
Remote Config [candidate] (846.207 µs) : 0, 846
Telemetry [baseline] (9.893 ms) : 0, 9893
Telemetry [candidate] (9.884 ms) : 0, 9884
section appsec
BytebuddyAgent [baseline] (1.0 s) : 0, 1000476
BytebuddyAgent [candidate] (1.003 s) : 0, 1002667
GlobalTracer [baseline] (437.286 ms) : 0, 437286
GlobalTracer [candidate] (437.744 ms) : 0, 437744
AppSec [baseline] (231.728 ms) : 0, 231728
AppSec [candidate] (231.113 ms) : 0, 231113
Remote Config [baseline] (785.294 µs) : 0, 785
Remote Config [candidate] (784.141 µs) : 0, 784
Telemetry [baseline] (9.19 ms) : 0, 9190
Telemetry [candidate] (9.227 ms) : 0, 9227
IAST [baseline] (24.19 ms) : 0, 24190
IAST [candidate] (24.26 ms) : 0, 24260
section iast
BytebuddyAgent [baseline] (1.15 s) : 0, 1149801
BytebuddyAgent [candidate] (1.145 s) : 0, 1144829
GlobalTracer [baseline] (432.678 ms) : 0, 432678
GlobalTracer [candidate] (431.096 ms) : 0, 431096
AppSec [baseline] (67.888 ms) : 0, 67888
AppSec [candidate] (66.499 ms) : 0, 66499
Remote Config [baseline] (797.761 µs) : 0, 798
Remote Config [candidate] (762.155 µs) : 0, 762
Telemetry [baseline] (12.365 ms) : 0, 12365
Telemetry [candidate] (10.651 ms) : 0, 10651
IAST [baseline] (30.973 ms) : 0, 30973
IAST [candidate] (31.702 ms) : 0, 31702
section profiling
ProfilingAgent [baseline] (147.194 ms) : 0, 147194
ProfilingAgent [candidate] (148.693 ms) : 0, 148693
BytebuddyAgent [baseline] (980.062 ms) : 0, 980062
BytebuddyAgent [candidate] (980.826 ms) : 0, 980826
GlobalTracer [baseline] (577.312 ms) : 0, 577312
GlobalTracer [candidate] (577.24 ms) : 0, 577240
AppSec [baseline] (72.563 ms) : 0, 72563
AppSec [candidate] (71.687 ms) : 0, 71687
Remote Config [baseline] (1.083 ms) : 0, 1083
Remote Config [candidate] (1.107 ms) : 0, 1107
Telemetry [baseline] (9.794 ms) : 0, 9794
Telemetry [candidate] (9.838 ms) : 0, 9838
Profiling [baseline] (147.25 ms) : 0, 147250
Profiling [candidate] (148.751 ms) : 0, 148751

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-05-30T14:33:25	2024-05-30T14:42:26
git_branch	master	mcculls/preserve-unix-agent-urls
git_commit_date	1717061093	1717076899
git_commit_sha	`4b5cad9`	`0964835`
release_version	1.35.0-SNAPSHOT~4b5cad9604	1.35.0-SNAPSHOT~096483556f
start_time	2024-05-30T14:33:08	2024-05-30T14:42:10

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1717080602	1717080602
ci_job_id	527436410	527436410
ci_pipeline_id	35460985	35460985
cpu_model	Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 7 metrics, 21 unstable metrics.

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~096483556f, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section baseline
no_agent (1.703 ms) : 1679, 1728
. : milestone, 1703,
appsec (2.187 ms) : 2153, 2220
. : milestone, 2187,
appsec_no_iast (2.186 ms) : 2153, 2220
. : milestone, 2186,
iast (1.901 ms) : 1872, 1930
. : milestone, 1901,
profiling (1.895 ms) : 1864, 1926
. : milestone, 1895,
tracing (1.894 ms) : 1861, 1926
. : milestone, 1894,
section candidate
no_agent (1.706 ms) : 1680, 1732
. : milestone, 1706,
appsec (2.173 ms) : 2140, 2206
. : milestone, 2173,
appsec_no_iast (2.191 ms) : 2159, 2224
. : milestone, 2191,
iast (1.9 ms) : 1871, 1930
. : milestone, 1900,
profiling (1.923 ms) : 1890, 1957
. : milestone, 1923,
tracing (1.875 ms) : 1844, 1907
. : milestone, 1875,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.703 ms [1.679 ms, 1.728 ms]	-
appsec	2.187 ms [2.153 ms, 2.22 ms]	483.291 µs (28.4%)
appsec_no_iast	2.186 ms [2.153 ms, 2.22 ms]	482.808 µs (28.3%)
iast	1.901 ms [1.872 ms, 1.93 ms]	197.754 µs (11.6%)
profiling	1.895 ms [1.864 ms, 1.926 ms]	191.394 µs (11.2%)
tracing	1.894 ms [1.861 ms, 1.926 ms]	190.162 µs (11.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.706 ms [1.68 ms, 1.732 ms]	-
appsec	2.173 ms [2.14 ms, 2.206 ms]	466.667 µs (27.3%)
appsec_no_iast	2.191 ms [2.159 ms, 2.224 ms]	484.921 µs (28.4%)
iast	1.9 ms [1.871 ms, 1.93 ms]	194.003 µs (11.4%)
profiling	1.923 ms [1.89 ms, 1.957 ms]	217.108 µs (12.7%)
tracing	1.875 ms [1.844 ms, 1.907 ms]	169.097 µs (9.9%)

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~096483556f, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section baseline
no_agent (451.127 µs) : 422, 480
. : milestone, 451,
iast (588.027 µs) : 556, 620
. : milestone, 588,
iast_FULL (691.802 µs) : 660, 723
. : milestone, 692,
iast_GLOBAL (619.536 µs) : 588, 652
. : milestone, 620,
iast_HARDCODED_SECRET_DISABLED (584.296 µs) : 552, 616
. : milestone, 584,
iast_INACTIVE (558.429 µs) : 528, 589
. : milestone, 558,
iast_TELEMETRY_OFF (571.797 µs) : 539, 605
. : milestone, 572,
tracing (538.322 µs) : 508, 569
. : milestone, 538,
section candidate
no_agent (450.779 µs) : 422, 480
. : milestone, 451,
iast (589.476 µs) : 558, 621
. : milestone, 589,
iast_FULL (682.486 µs) : 651, 714
. : milestone, 682,
iast_GLOBAL (617.564 µs) : 587, 649
. : milestone, 618,
iast_HARDCODED_SECRET_DISABLED (590.873 µs) : 557, 625
. : milestone, 591,
iast_INACTIVE (553.463 µs) : 522, 585
. : milestone, 553,
iast_TELEMETRY_OFF (578.652 µs) : 548, 609
. : milestone, 579,
tracing (539.306 µs) : 509, 569
. : milestone, 539,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	451.127 µs [422.344 µs, 479.909 µs]	-
iast	588.027 µs [555.964 µs, 620.089 µs]	136.9 µs (30.3%)
iast_FULL	691.802 µs [660.307 µs, 723.297 µs]	240.676 µs (53.3%)
iast_GLOBAL	619.536 µs [587.501 µs, 651.571 µs]	168.41 µs (37.3%)
iast_HARDCODED_SECRET_DISABLED	584.296 µs [552.49 µs, 616.103 µs]	133.17 µs (29.5%)
iast_INACTIVE	558.429 µs [527.584 µs, 589.273 µs]	107.302 µs (23.8%)
iast_TELEMETRY_OFF	571.797 µs [538.88 µs, 604.713 µs]	120.67 µs (26.7%)
tracing	538.322 µs [508.116 µs, 568.529 µs]	87.196 µs (19.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	450.779 µs [421.902 µs, 479.655 µs]	-
iast	589.476 µs [557.549 µs, 621.402 µs]	138.697 µs (30.8%)
iast_FULL	682.486 µs [650.788 µs, 714.183 µs]	231.707 µs (51.4%)
iast_GLOBAL	617.564 µs [586.585 µs, 648.542 µs]	166.785 µs (37.0%)
iast_HARDCODED_SECRET_DISABLED	590.873 µs [557.205 µs, 624.542 µs]	140.095 µs (31.1%)
iast_INACTIVE	553.463 µs [522.061 µs, 584.865 µs]	102.684 µs (22.8%)
iast_TELEMETRY_OFF	578.652 µs [547.893 µs, 609.412 µs]	127.873 µs (28.4%)
tracing	539.306 µs [509.394 µs, 569.219 µs]	88.527 µs (19.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/preserve-unix-agent-urls
git_commit_date	1717061093	1717076899
git_commit_sha	`4b5cad9`	`0964835`
release_version	1.35.0-SNAPSHOT~4b5cad9604	1.35.0-SNAPSHOT~096483556f

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1717079850	1717079850
ci_job_id	527361295	527361295
ci_pipeline_id	35460985	35460985
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~096483556f, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (2.2 ms) : 2166, 2233
. : milestone, 2200,
iast (1.957 ms) : 1916, 1997
. : milestone, 1957,
iast_GLOBAL (1.981 ms) : 1941, 2021
. : milestone, 1981,
profiling (1.85 ms) : 1818, 1883
. : milestone, 1850,
tracing (1.828 ms) : 1796, 1861
. : milestone, 1828,
section candidate
no_agent (1.46 ms) : 1448, 1471
. : milestone, 1460,
appsec (2.204 ms) : 2170, 2238
. : milestone, 2204,
iast (1.957 ms) : 1916, 1997
. : milestone, 1957,
iast_GLOBAL (2.003 ms) : 1963, 2044
. : milestone, 2003,
profiling (1.85 ms) : 1817, 1884
. : milestone, 1850,
tracing (1.828 ms) : 1796, 1860
. : milestone, 1828,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.459 ms, 1.482 ms]	-
appsec	2.2 ms [2.166 ms, 2.233 ms]	729.398 µs (49.6%)
iast	1.957 ms [1.916 ms, 1.997 ms]	486.443 µs (33.1%)
iast_GLOBAL	1.981 ms [1.941 ms, 2.021 ms]	510.246 µs (34.7%)
profiling	1.85 ms [1.818 ms, 1.883 ms]	379.905 µs (25.8%)
tracing	1.828 ms [1.796 ms, 1.861 ms]	357.755 µs (24.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.46 ms [1.448 ms, 1.471 ms]	-
appsec	2.204 ms [2.17 ms, 2.238 ms]	744.639 µs (51.0%)
iast	1.957 ms [1.916 ms, 1.997 ms]	497.271 µs (34.1%)
iast_GLOBAL	2.003 ms [1.963 ms, 2.044 ms]	543.939 µs (37.3%)
profiling	1.85 ms [1.817 ms, 1.884 ms]	390.964 µs (26.8%)
tracing	1.828 ms [1.796 ms, 1.86 ms]	368.322 µs (25.2%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~096483556f, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section baseline
no_agent (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
appsec (15.319 s) : 15319000, 15319000
. : milestone, 15319000,
iast (19.025 s) : 19025000, 19025000
. : milestone, 19025000,
iast_GLOBAL (18.092 s) : 18092000, 18092000
. : milestone, 18092000,
profiling (15.809 s) : 15809000, 15809000
. : milestone, 15809000,
tracing (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
section candidate
no_agent (15.042 s) : 15042000, 15042000
. : milestone, 15042000,
appsec (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
iast (18.543 s) : 18543000, 18543000
. : milestone, 18543000,
iast_GLOBAL (17.997 s) : 17997000, 17997000
. : milestone, 17997000,
profiling (15.899 s) : 15899000, 15899000
. : milestone, 15899000,
tracing (14.979 s) : 14979000, 14979000
. : milestone, 14979000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.998 s [14.998 s, 14.998 s]	-
appsec	15.319 s [15.319 s, 15.319 s]	321.0 ms (2.1%)
iast	19.025 s [19.025 s, 19.025 s]	4.027 s (26.9%)
iast_GLOBAL	18.092 s [18.092 s, 18.092 s]	3.094 s (20.6%)
profiling	15.809 s [15.809 s, 15.809 s]	811.0 ms (5.4%)
tracing	15.102 s [15.102 s, 15.102 s]	104.0 ms (0.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.042 s [15.042 s, 15.042 s]	-
appsec	15.037 s [15.037 s, 15.037 s]	-5.0 ms (-0.0%)
iast	18.543 s [18.543 s, 18.543 s]	3.501 s (23.3%)
iast_GLOBAL	17.997 s [17.997 s, 17.997 s]	2.955 s (19.6%)
profiling	15.899 s [15.899 s, 15.899 s]	857.0 ms (5.7%)
tracing	14.979 s [14.979 s, 14.979 s]	-63.0 ms (-0.4%)

…nix: URLs

mcculls added the comp: core Tracer core label May 30, 2024

Avoid merging in supplementary host/port settings when dealing with u…
0964835
…nix: URLs

mcculls force-pushed the mcculls/preserve-unix-agent-urls branch from 678a09e to 0964835Compare May 30, 2024 13:48

mcculls marked this pull request as ready for review May 30, 2024 14:42

mcculls requested review from a team as code owners May 30, 2024 14:42

mcculls requested review from PerfectSlayer, dougqh and jpbempel and removed request for a teamMay 30, 2024 14:42

jpbempel approved these changes May 30, 2024
View reviewed changes

dougqh approved these changes May 30, 2024
View reviewed changes

mcculls merged commit c2fa83f into masterMay 30, 2024

mcculls deleted the mcculls/preserve-unix-agent-urls branch May 30, 2024 16:10

github-actionsBot added this to the 1.35.0 milestone May 30, 2024

mcculls mentioned this pull request May 30, 2024
With Unix Domain Socket, DD_AGENT_HOST not ignored despite DD_TRACE_AGENT_URL #7036
Closed

kevinfrommelt mentioned this pull request Jun 11, 2024
Dynamic Instrumentation fails to start when tracing is configured to use UDS #7165
Closed

mcculls mentioned this pull request Jun 11, 2024
Fix debugger batch upload URL when using UDS #7166
Merged

Navigation Menu

Uh oh!

Preserve `unix:` agent URLs - #7094

Preserve `unix:` agent URLs#7094
mcculls merged 1 commit into
masterfrom
mcculls/preserve-unix-agent-urls

mcculls commented May 30, 2024

Uh oh!

pr-commenterBot commented May 30, 2024•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

mcculls commented May 30, 2024

What Does This Do

Motivation

Uh oh!

pr-commenterBot commented May 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pr-commenterBot commented May 30, 2024•
edited
Loading